1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts/lib
Mark Stacey 22f931e6b2
Prevent automatic rejection of confirmations (#13194)
* Prevent automatic rejection of confirmations

Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.

This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.

It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.

* Fix bug that prevented automatic closure detection

All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.

* Re-open popup when necessary

After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
..
ens-ipfs Feat/collectibles the return (#12970) 2021-12-13 17:41:10 -06:00
migrator Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
rpc-method-middleware Add missing permissions middleware hook (#13205) 2022-01-04 12:57:18 -08:00
account-tracker.js Setting balance to 0x0 when the original value is undefined (#10634) 2021-03-12 10:20:33 -05:00
buy-eth-url.js Update ESLint config to v8 (#12886) 2021-12-09 15:36:24 -03:30
buy-eth-url.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
cleanErrorStack.js Fix 12145 - Ledger errors being set as Error: [object, object] (#12176) 2021-09-22 10:41:23 -07:00
cleanErrorStack.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
ComposableObservableStore.js Fix typo in ComposableObservableStore.js (#13151) 2022-01-04 12:59:08 -06:00
ComposableObservableStore.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
createLoggerMiddleware.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
createMetaRPCHandler.js Remove nodeify (#13003) 2021-12-08 18:06:53 -03:30
createMetaRPCHandler.test.js Remove nodeify (#13003) 2021-12-08 18:06:53 -03:30
createOnboardingMiddleware.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
createOriginMiddleware.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
createStreamSink.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
createTabIdMiddleware.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
decrypt-message-manager.js Reject popup confirmations on close (#12643) 2021-11-15 17:13:51 +01:00
encryption-public-key-manager.js Reject popup confirmations on close (#12643) 2021-11-15 17:13:51 +01:00
extractEthjsErrorMessage.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
get-first-preferred-lang-code.js fix issue where regional locales are not matched against our locales list (#12403) 2021-10-19 14:32:13 -05:00
getObjStructure.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
local-store.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
message-manager.js Fix: eth_sign does not validate input (#12679) 2021-11-19 17:05:24 +01:00
message-manager.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
metaRPCClientFactory.js fix metaRPCClientFactory id handling (#11116) 2021-05-17 14:46:00 -07:00
metaRPCClientFactory.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
network-store.js Using values from shared/constants/time to represent timing values (#11241) 2021-06-10 12:27:03 -07:00
notification-manager.js Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
personal-message-manager.js Fix: eth_sign does not validate input (#12679) 2021-11-19 17:05:24 +01:00
personal-message-manager.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
seed-phrase-verifier.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
seed-phrase-verifier.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
segment.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
setupSentry.js Update the Sentry setup log with the build type (#13157) 2022-01-03 10:29:44 -03:30
stream-utils.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
typed-message-manager.js Reject popup confirmations on close (#12643) 2021-11-15 17:13:51 +01:00
typed-message-manager.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00
util.js Improve browser detection code (#12456) 2021-11-05 17:28:44 -07:00
util.test.js Jestify app/scripts/lib/**/*.test.js (#12890) 2021-12-06 10:40:39 -06:00