m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix 12145 - Ledger errors being set as Error: [object, object] (#12176)

Browse Source 
* Fixes #12145

When transactions fail, preserve error message when presented with an error object. Fallback to stringified error for other cases.

* Perserve error stack when err.stack is present, else set stack to message.

* Use optional chaining
This commit is contained in:
Thomas Huang 2021-09-22 10:41:23 -07:00 committed by GitHub
parent 1ca02cb633
commit 02a4da9ad2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/scripts/controllers/transactions/tx-state-manager.js
View File

@ -521,7 +521,7 @@ export default class TransactionStateManager extends EventEmitter {
const txMeta = this.getTransaction(txId);
txMeta.err = {
message: error.toString(),
message: error.message?.toString() || error.toString(),
rpc: error.value,
stack: error.stack,
};

2
app/scripts/lib/cleanErrorStack.js
View File

@ -14,7 +14,7 @@ export default function cleanErrorStack(err) {
err.stack = err.message;
} else if (msg === '') {
err.stack = err.name;
} else {
} else if (!err.stack) {
err.stack = `${err.name}: ${err.message}`;
}