1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts
Mark Stacey 22f931e6b2
Prevent automatic rejection of confirmations (#13194)
* Prevent automatic rejection of confirmations

Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.

This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.

It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.

* Fix bug that prevented automatic closure detection

All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.

* Re-open popup when necessary

After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
..
account-import-strategies Use strict assertion mode everywhere (#11012) 2021-05-07 17:08:24 -02:30
constants Add support for fiat on-ramp via Transak (#11376) 2021-06-25 08:10:24 -05:00
controllers Feat/collectibles the return (#12970) 2021-12-13 17:41:10 -06:00
lib Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
migrations Update ESLint config to v8 (#12886) 2021-12-09 15:36:24 -03:30
platforms Update the Firefox prerelease version format (#13158) 2022-01-03 12:48:10 -03:30
background.js Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
contentscript.js @metamask/post-message-stream@4.0.0 (#10989) 2021-05-05 16:07:48 -07:00
disable-console.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
first-time-state.js Ensure one and only one localhost option appears in network list (#12786) 2021-11-22 12:54:42 -03:30
inpage.js @metamask/providers@8.1.1 (#11078) 2021-05-12 19:51:14 -07:00
lockdown-more.js Update build system lockdown parameter (#12556) 2021-11-01 22:13:22 -10:00
lockdown-run.js lockdown - breakout making globalThis properties non-writable (#12258) 2021-10-01 08:53:12 -10:00
metamask-controller.js Prevent automatic rejection of confirmations (#13194) 2022-01-05 13:39:19 -03:30
metamask-controller.test.js Remove nodeify (#13003) 2021-12-08 18:06:53 -03:30
phishing-detect.js Autofilling new issue link with url and domain (Phishing detect page) (#12000) 2021-09-03 11:22:28 -07:00
sentry-install.js Build - refactor for bundle factoring and swappable runtime (#11080) 2021-07-15 10:59:34 -07:00
ui.js bump @metamask/controllers to v15.0.2 and remove AbortController workaround in e2e tests (#11988) 2021-09-03 09:34:21 -05:00