m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-22 17:33:23 +01:00
Code
1,893 Commits 2 Branches 0 Tags 265 MiB
6e78494846
Commit Graph

1893 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Frances Pangilinan
6e78494846 First pass at revision requests 2016-12-21 13:41:32 -08:00
Frances Pangilinan
da9349fe63 Clean up and comment functions 2016-12-14 15:04:33 -08:00
Frances Pangilinan
5a292cc397 add to CHANGELOG.md 2016-12-14 13:03:40 -08:00
Frances Pangilinan
5aba096bd1 add Test for txManager. As well as fix tests to account for txManager. 2016-12-14 12:56:53 -08:00
Frances Pangilinan
090935f90a Create a TxManager 2016-12-14 12:55:41 -08:00
Dan Finlay
9e3fa3cfba Merge pull request #914 from MetaMask/FixUnitTestSuite 
Remove .only from unit test suite
 2016-12-08 10:01:59 -08:00
Dan Finlay
c93227ea72 Cranked up CI test suite wait duration to alleviate their nondeterminism for now 2016-12-07 16:55:15 -08:00
Dan Finlay
fe01ceb857 Remove .only from unit test suite 2016-12-07 16:32:49 -08:00
kumavis
eb7cf2bf31 Merge pull request #904 from MetaMask/BetterIntegrationTest 
Made integration test suite better, added a step to story
 2016-12-01 13:30:31 -05:00
Dan Finlay
c431783602 Remove redundant logging block 2016-12-01 10:21:56 -08:00
Dan Finlay
1880cda9b9 Fix vault encrypting & unlocking bug 
This is only a bug in dev, but was committed yesterday.

Sometimes the `encrypt` method was being passed values other than the password as the encryption key, leading to un-unlockable vaults.

To find this, and avoid it for all time hereafter, I added several more steps to our oft-neglected integration test suite, which now fully initializes a vault, locks it, and unlocks it again, to make sure all of those steps definitely work always.
 2016-11-30 19:36:24 -08:00
Dan Finlay
049e351c9d Add integration tests for logging out and back in 2016-11-30 16:01:51 -08:00
Dan Finlay
fe533bbef2 Add more integration tests 
Integration tests now:
- Scroll through terms
- Accept terms
- Confirm seed phrase
- Verify account detail screen
 2016-11-30 15:18:26 -08:00
Dan Finlay
549bbfd05f Made integration test create a first vault 2016-11-30 14:58:40 -08:00
Kevin Serrano
5af4157363 Merge pull request #899 from MetaMask/i893-DenodeifyKeyringController 
Fix incorrect nodeification and add descriptive error to help find in future
 2016-11-29 15:59:18 -08:00
Dan Finlay
95bcc21a06 Add useful nodeify error message 
If a nodified method does not return a Promise, it will throw an error, like this:
```
Error in event handler for (unknown): Error: The function setSelectedAccount did not return a Promise, but was nodeified.
```
 2016-11-29 15:54:10 -08:00
Dan Finlay
df0b89074b Return promise correctly from setSelectedAddress 2016-11-29 15:50:26 -08:00
Kevin Serrano
f8fbeb88ff Merge pull request #896 from MetaMask/i893-DenodeifyKeyringController 
Denodeify most of KeyringController
 2016-11-29 15:16:24 -08:00
Dan Finlay
5bf1018d75 Flattened addTx async methods 2016-11-29 14:56:58 -08:00
Dan Finlay
ff3f6cc36a Bind ethQuery to estimateGas to allow it to be moved around. 2016-11-29 14:13:12 -08:00
Dan Finlay
85d5b12f8d Fix tx adding code 
Broken in this commit:
bc39cd7b89

Synchronous methods were added to an `async.waterfall` array.

This commit also removes the delegate call checking, since we concluded it was misinformed.
 2016-11-29 12:46:08 -08:00
Dan Finlay
4b6b1db4f0 Ordered keyringController methods the same in metamask-controller 2016-11-29 12:05:23 -08:00
Dan Finlay
b81f00849d Annotated KeyringController 2016-11-29 11:40:49 -08:00
Dan Finlay
12906df601 Remove unused dep 2016-11-28 17:27:44 -08:00
Dan Finlay
9d401f9137 Fix nodeify usage 2016-11-28 17:27:28 -08:00
Dan Finlay
9e764b1935 Fix nodeify 2016-11-28 17:27:20 -08:00
Dan Finlay
80e76b45ee Denodeify most of KeyringController 
Mostly Fixes #893

A couple methods cache callbacks, and will require a larger refactor to fully denodeify.

Specifically, our methods involving web3 requests to sign a tx, sign a message, and approve or cancel either of those.

I think we should postpone those until the TxManager refactor, since it will likely handle this response caching itself.
 2016-11-28 16:13:03 -08:00
Kevin Serrano
da5be09a94 Merge pull request #890 from MetaMask/MergeMasterIntoDev 
Merge master into dev
 2016-11-28 13:22:27 -08:00
Dan Finlay
b899119582 Merge branch 'master' into dev 2016-11-23 16:54:27 -08:00
Kevin Serrano
b9b3ef8fed Merge pull request #887 from MetaMask/i865-erabe 
Modify forgot password flow to go back to init screen.
 2016-11-23 15:48:13 -08:00
Kevin Serrano
8dd298238d
Cosmetic changes, rename links. 2016-11-23 15:42:17 -08:00
Kevin Serrano
feae6235cb Merge pull request #888 from MetaMask/i844-AsyncKeyrings 
Modify Keyring protocol to always return promises for public methods
 2016-11-23 15:31:17 -08:00
Kevin Serrano
3a503d2ac2
Add link back to unlock. 2016-11-23 15:29:42 -08:00
Dan Finlay
9f67974133 Fix last async keyring test 2016-11-23 14:39:35 -08:00
Dan Finlay
d9dc2eac63 Fix more async usage of KeyringController 2016-11-23 14:35:29 -08:00
Kevin Serrano
5a02e58f62
Fix proper behavior for restoring accounts when password forgotten. 2016-11-23 13:49:54 -08:00
Kevin Serrano
5251fb373f
Modify forgot password flow to go back to init screen. 2016-11-23 13:05:02 -08:00
Dan Finlay
230a0ab876 Fix more keyring asyncifying tests 2016-11-23 11:58:34 -08:00
kumavis
323f3cb1a0 Merge pull request #884 from MetaMask/i883-sync-uninstallFilter 
Add support for sync RPC uninstallFilter
 2016-11-23 14:29:21 -05:00
kumavis
36c824889f changelog - add sync rpc eth_uninstallFilter note 2016-11-23 11:00:48 -08:00
kumavis
c0a2eb146a rpc - add sync uninstallFilter support 2016-11-23 10:48:20 -08:00
Dan Finlay
600f5c31db Mostly got async keyringController tests passing 2016-11-23 00:23:41 -08:00
Dan Finlay
c77d355e98 Complete first pass at asyncrhonizing keyring controller 2016-11-22 23:36:11 -08:00
Dan Finlay
2efab79f5b Asynced keyrings and started on controller 2016-11-22 23:16:36 -08:00
Kevin Serrano
ec8b0148f0 Merge pull request #879 from MetaMask/i843-MoveSaltIntoEncryptor 
Fix new encryptor implementation
 2016-11-22 17:55:22 -08:00
Dan Finlay
05c8658ff3 Fix new encryptor migration logic 2016-11-22 17:41:54 -08:00
Dan Finlay
1e46d858e9 Fix undefined provider menu item 2016-11-22 16:34:02 -08:00
Dan Finlay
822face7a3 Fix password reference 2016-11-22 16:29:46 -08:00
Dan Finlay
427a103083 Merge pull request #878 from MetaMask/i843-MoveSaltIntoEncryptor 
Simplify Encryptor API Surface
 2016-11-22 16:22:31 -08:00
Dan Finlay
6ebdebc0a5 Remove line of cruft 2016-11-22 16:18:18 -08:00