ricky
1f9e3b89d4
Add optional chaining ( #8052 )
...
* Add plugin-proposal-optional-chaining
* Use optional chaining to provide error fallback
2020-02-18 10:11:52 -05:00
Whymarrh Whitby
9c45ae0552
Use http-server@0.12.1 ( #8066 )
2020-02-18 08:58:06 -03:30
Whymarrh Whitby
b5cdbcb581
Update redux-related dependencies ( #8068 )
2020-02-18 08:56:54 -03:30
Jenny Pollack
fd170ef8c0
Merge pull request #8062 from whymarrh/no-mixed-operators
...
Enable core ESLint no-mixed-operators rule
2020-02-17 21:08:06 -07:00
Whymarrh Whitby
8a04642cd3
Update dependencies to resolve security advisories ( #8064 )
2020-02-17 22:16:17 -04:00
Mark Stacey
a71f56e5da
Remove unused sinon sandboxes ( #8063 )
...
These sandboxes were created, then not utilized at all.
2020-02-17 21:31:09 -04:00
Mark Stacey
c6db54cc6d
Attempt ENS resolution on any valid domain name ( #8059 )
...
ENS currently supports a variety of tlds in addition to `.eth`, and
more will be supported in the future. Rather than hard-code a list of
supported ENS tlds, all valid domain names will now be interpreted as
potential ENS addresses in our address input component.
Closes #7978
2020-02-17 21:20:01 -04:00
Whymarrh Whitby
126457dee6
Update transactions CODEOWNERS ( #8058 )
2020-02-17 21:38:31 -03:30
Whymarrh Whitby
da0300d3b1
Enable core ESLint no-mixed-operators rule
2020-02-17 21:06:36 -03:30
Mark Stacey
f26f52560d
Update packages to address security advisory ( #8061 )
...
Update packages to address the following security advisories:
* https://www.npmjs.com/advisories/1474
* https://www.npmjs.com/advisories/1475
* https://www.npmjs.com/advisories/1476
* https://www.npmjs.com/advisories/1480
* https://www.npmjs.com/advisories/1482
2020-02-17 20:33:01 -04:00
Jenny Pollack
befd580ab2
add parens to arrow function parameters ( #8060 )
2020-02-17 19:12:48 -04:00
Jenny Pollack
c1453c7528
Merge pull request #8056 from whymarrh/arrow-parens
...
Enable arrow-parens ESLint rule
2020-02-17 15:26:43 -07:00
Whymarrh Whitby
a78cf0ef3a
Enable arrow-parens ESLint rule
2020-02-15 17:04:21 -03:30
Mark Stacey
62c5ea4f80
Update Wyre ETH purchase url ( #8051 )
...
* Revert "Revert "Update Wyre ETH purchase url" (#7631 )"
This reverts commit bc67d1eeca
2020-02-14 14:07:24 -08:00
Dan Finlay
eb57763056
Add warning to watchAsset API when editing a known token ( #8049 )
...
* Add warning when editing a known token with watchAsset API
* Add warning when watchAsset attempts to reuse token symbol
* Linted
2020-02-14 12:32:56 -08:00
Dan Finlay
cfcccd266a
Inline the source text not the binary encoding for inpage script ( #8053 )
2020-02-14 15:27:12 -04:00
Vodopyanov Egor
b63b848ed4
add title to transaction action component ( #8050 )
2020-02-14 12:31:44 -04:00
Mark Stacey
dcc7d29511
Refactor QR scanner to move all error handling within component ( #7885 )
...
The QR scanner component error handling would sometimes redirect the
user to the wrong page. It was also confusingly handled in two places;
the action used to open the QR scanner, and the scanner component.
The error handling has now been corrected, simplified, and integrated
into the QR scanner component itself.
The old way of handling an error within the component was to close the
modal, then call the action to open it all over again. This action took
a route parameter, which instructed the action on which route to open
if the fullscreen UI needed to be opened (as the fullscreen UI is the
only one where the browser will show the camera permission prompt).
This redirection worked just fine for handling the initial opening
of the QR scanner modal. But for any subsequent errors the same action
was used with a _default route_, meaning the user could click "try
again" and find themselves on a completely different screen.
Instead, errors now trigger a state change instead of closing and re-
opening the modal. The permission checks in the action have been
integrated into the component as well.
One functional change is that the scenario where you have an invalid
QR code has been made an error. Previously this just showed the error
message below the video preview, but left the user with no way to try
again. There error page has a "Try again" button, so it seemed better
suited as an error. Also the message literally started with "Error:".
Another functional change is that _all_ errors during initialization
will result in the error UI being shown. Previously there was one error
case that would instead log to the console and leave the user stuck.
2020-02-13 16:07:50 -04:00
Dan Finlay
9c8fd38db4
Merge pull request #8048 from MetaMask/null-check
...
Fix faulty null checks
2020-02-12 12:03:28 -08:00
Erik Marks
9376c47dd1
update packages
2020-02-12 10:39:47 -08:00
Whymarrh Whitby
85430746ad
Update mocha version ( #8028 )
...
* Use mocha@7.0.1
* Remove bad async test
2020-02-12 14:47:36 -03:30
Erik Marks
0103bf8b29
fix faulty null checks
2020-02-12 08:17:13 -08:00
Whymarrh Whitby
7f3cf07f94
Update sinon and proxyquire ( #8027 )
...
* Use sinon@8.1.1
* Use proxyquire@2.1.3
* Move sinon mocking out of global scope into hooks
2020-02-11 17:03:32 -03:30
Whymarrh Whitby
4f3fc95d50
Update ESLint rules for test suite ( #8023 )
...
* Use @metamask/eslint-config@1.1.0
* Use eslint-plugin-mocha@6.2.2
* Mark root ESLint config as root
* Update Mocha ESLint rules with shared ESLint config
2020-02-11 13:21:13 -03:30
ryanml
3bbbe13311
Use contact name instead of address during send flow ( #7971 )
2020-02-11 12:10:15 -03:30
Whymarrh Whitby
1ae0933897
Use image hash for ShellCheck Docker image ( #8022 )
2020-02-10 14:17:31 -03:30
ricky
8c81f9d530
Ensure we pass history to UnlockPage component ( #8017 )
...
* Add .isRequired to history propType definition
* Ensure we pass history down to the component
2020-02-10 12:42:59 -05:00
Whymarrh Whitby
1a1e0b43d0
Remove unused test:single script ( #8025 )
2020-02-09 16:12:57 -03:30
Whymarrh Whitby
5b28fb3a1c
Enable Storybook deploy on CI ( #8009 )
2020-02-08 16:26:33 -03:30
Whymarrh Whitby
c0d6121cd9
Browser tests ( #8010 )
2020-02-07 13:19:32 -03:30
Whymarrh Whitby
1d654d6c4e
Remove version bump scripts ( #8006 )
2020-02-06 18:56:31 -03:30
William Morriss
1eb828f7f0
Add support for 24 word seed phrases ( #7987 )
2020-02-06 18:55:45 -03:30
Whymarrh Whitby
712f3eb637
Update README.md ( #8005 )
2020-02-06 18:42:22 -03:30
Whymarrh Whitby
96802b84c5
Delete limited_site_access.md ( #8007 )
2020-02-06 18:26:48 -03:30
Whymarrh Whitby
f928b1f69f
Delete developing-on-deps.md ( #8004 )
2020-02-06 16:52:38 -03:30
ricky
fbfaa6eb10
Use readOnly ( #7995 )
2020-02-06 14:34:23 -05:00
Whymarrh Whitby
d368464b7b
Delete adding-new-networks.md ( #7999 )
2020-02-06 13:15:46 -03:30
Whymarrh Whitby
dea8f0f24d
Use combineReducers for rootReducer ( #7964 )
2020-02-06 13:08:14 -03:30
Whymarrh Whitby
7e04be9b58
Delete send-screen-QA-checklist.md ( #7998 )
2020-02-06 13:07:48 -03:30
Whymarrh Whitby
6f8d65cc61
Delete video_script.txt ( #7989 )
2020-02-06 12:58:18 -03:30
Whymarrh Whitby
8196818f2e
Delete multi_vault_planning.md ( #7988 )
2020-02-06 12:52:12 -03:30
Erik Marks
8e307f8d71
update inpage-provider; minor fixes ( #7997 )
2020-02-06 07:57:54 -08:00
Whymarrh Whitby
08c7322203
Remove last remaining usages of npm run ( #7994 )
...
* Remove last remaining usages of `npm run`
* Use nyc@15.0.0
2020-02-06 12:22:40 -03:30
Whymarrh Whitby
667f4fa5f8
Revert CircleCI Node image ( #7996 )
...
This changeset "reverts" the image version of the CircleCI node image, to
work around a chromedriver/Chrome/WebDriver error. We were seeing the
following errors:
```
WebDriverError: unknown error: Chrome failed to start: exited abnormally
(unknown error: DevToolsActivePort file doesn't exist)
(The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
```
I can surmise that the content changes in the Docker image, from (1) to (2),
below did result in this breakage:
1. https://hub.docker.com/layers/circleci/node/10.18-browsers/images/sha256-e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
2. https://hub.docker.com/layers/circleci/node/10.18-browsers/images/sha256-14d76b9e092ca03543328409223a2d2fba29e3ee5b8274c90b0c98b80005ecf2
Alternative links:
1. circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
2. circleci/node@sha256:14d76b9e092ca03543328409223a2d2fba29e3ee5b8274c90b0c98b80005ecf2
2020-02-05 19:50:06 -04:00
Whymarrh Whitby
25bcdfcac8
Fix SendAmountRow tests ( #7968 )
...
* Rewrite SendAmountRow tests to avoid flakiness
* Use sinon@5.0.1
* Dedupe supports-color versions
2020-02-05 09:45:46 -03:30
Thomas Huang
6969e3984b
Fixes #5706 - Adds Dai/Sai to currency display ( #7986 )
...
With the change from infura to cryptocompare https://github.com/MetaMask/gaba/pull/30/files#diff-50c3c47cc5fa12e5213a6cc900476f41L41-R48 we have numerous conversion rates to go through and add if we like to.
2020-02-04 14:49:53 -08:00
Whymarrh Whitby
59937fe35a
Remove redundant eth-*-keyring versions from yarn.lock ( #7984 )
2020-02-04 10:54:03 -04:00
Whymarrh Whitby
2aa22fa9d7
Use gulp@4.0.2 ( #7982 )
2020-02-04 11:04:21 -03:30
Whymarrh Whitby
75769e5809
Use eth-keyring-controller@5.5.0 ( #7980 )
2020-02-04 10:41:34 -03:30
Whymarrh Whitby
8610c1cf47
Use eth-json-rpc-infura@4.0.2 ( #7981 )
2020-02-04 10:41:10 -03:30
