1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 01:47:00 +01:00

Revert CircleCI Node image (#7996)

This changeset "reverts" the image version of the CircleCI node image, to
work around a chromedriver/Chrome/WebDriver error. We were seeing the
following errors:

```
WebDriverError: unknown error: Chrome failed to start: exited abnormally
(unknown error: DevToolsActivePort file doesn't exist)
(The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
```

I can surmise that the content changes in the Docker image, from (1) to (2),
below did result in this breakage:

1. https://hub.docker.com/layers/circleci/node/10.18-browsers/images/sha256-e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
2. https://hub.docker.com/layers/circleci/node/10.18-browsers/images/sha256-14d76b9e092ca03543328409223a2d2fba29e3ee5b8274c90b0c98b80005ecf2

Alternative links:

1. circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
2. circleci/node@sha256:14d76b9e092ca03543328409223a2d2fba29e3ee5b8274c90b0c98b80005ecf2
This commit is contained in:
Whymarrh Whitby 2020-02-05 20:20:06 -03:30 committed by GitHub
parent 25bcdfcac8
commit 667f4fa5f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -92,7 +92,7 @@ workflows:
jobs:
create_release_pull_request:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- run:
@ -104,7 +104,7 @@ jobs:
prep-deps:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- run:
@ -123,7 +123,7 @@ jobs:
prep-build:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -142,7 +142,7 @@ jobs:
prep-build-test:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -160,7 +160,7 @@ jobs:
prep-scss:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -179,7 +179,7 @@ jobs:
test-lint:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -203,7 +203,7 @@ jobs:
test-lint-lockfile:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -214,7 +214,7 @@ jobs:
test-deps:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -225,7 +225,7 @@ jobs:
test-e2e-chrome:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -243,7 +243,7 @@ jobs:
test-e2e-firefox:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- run:
@ -264,7 +264,7 @@ jobs:
benchmark:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -285,7 +285,7 @@ jobs:
job-publish-prerelease:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -315,7 +315,7 @@ jobs:
job-publish-release:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -332,7 +332,7 @@ jobs:
command: .circleci/scripts/release-create-master-pr
# job-publish-storybook:
# docker:
# - image: circleci/node:10.18-browsers
# - image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
# steps:
# - checkout
# - attach_workspace:
@ -343,7 +343,7 @@ jobs:
test-unit:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -358,7 +358,7 @@ jobs:
- coverage
test-unit-global:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -368,7 +368,7 @@ jobs:
command: yarn test:unit:global
test-mozilla-lint:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -379,7 +379,7 @@ jobs:
test-integration-flat-firefox:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -395,7 +395,7 @@ jobs:
environment:
browsers: '["Chrome"]'
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace:
@ -406,7 +406,7 @@ jobs:
all-tests-pass:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- run:
name: All Tests Passed
@ -414,7 +414,7 @@ jobs:
coveralls-upload:
docker:
- image: circleci/node:10.18-browsers
- image: circleci/node@sha256:e16740707de2ebed45c05d507f33ef204902349c7356d720610b5ec6a35d3d88
steps:
- checkout
- attach_workspace: