David Walsh
0ef1d97061
UX: Icons: Stop using fa-address-book ( #17761 )
...
* UX: Icons: Stop using fa-address-book
* Remove locale string
* Fix positioning
2023-03-02 12:40:20 +00:00
David Walsh
de26c9e4a1
UX: Replace all fa-bell instances with Notification icon ( #17524 )
...
* UX: Replace all fa-bell instances with Notification icon
* Fix flask comment fencing
* Fix import error
2023-03-02 12:39:41 +00:00
seaona
44ac0d9567
e2e Send to Multisig Wallet ( #17565 )
...
* e2e Send to Multisig Wallet
* Update test-dapp dependency to 5.4.0
* Added test-dapp update version to yarn lock
* disable ff
---------
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-03-02 11:49:21 +00:00
Jyoti Puri
5691a00e20
Fix state in confirm transaction ( #17838 )
2023-03-02 11:38:53 +00:00
Ariella Vu
1d733194ea
Cleanup: clearTimeout on useEffect for gas estimation and prevent state update on unmounted ConfirmTransactionBase ( #17804 )
2023-03-02 11:38:42 +00:00
Jyoti Puri
49d84140d9
Confirm transaction test ( #17780 )
2023-03-02 11:38:34 +00:00
Ariella Vu
de5ea66d8d
Clean ConfirmTranscationPage component ( #17546 )
...
* ConfirmTransaction: rm unused metricEvent context
* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id
* ConfirmTransaction: convert to FC
* ConfirmTransaction: use const ORIGIN_METAMASK
* ConfirmTransaction: rm mapStateToProps
* ConfirmTransaction: mv confirm-transaction ducks
* ConfirmTransaction: mv getContractMethodData duck
* ConfirmTransaction: rm container file
* ConfirmTransaction: use ORIGIN_METAMASK const
* clean: rn totalUnapprovedCount -> totalUnapproved
* clean: reorder ConfirmTransaction & alphabetize
* clean: rn validTransactionId> isValidTransactionId
* clean: rn unconfirmedTransactions > unconfirmedTxs
* ConfirmationTransaction: add tests
* ConfirmTransaction: mv const
* ConfirmTransaction: update jest mock after merge
* ConfirmTransaction: fix from merge fault
* tests: update snapshot after mock-state updates
2023-03-02 11:38:24 +00:00
Ariella Vu
97013d8028
Fix GetEncryptionKey TypeError Cannot destructure property 'msgParams' of 'txData' ( #17808 )
...
* fix ConfirmEncryptionPublicKey txData
* encrypt/decrypt: fix missing txData state
* rm console.log
2023-03-02 10:55:07 +00:00
Brad Decker
591fe1a0a6
avoid mutation of state in signTransaction action ( #17772 )
...
Co-authored-by: ryanml <ryanlanese@gmail.com>
2023-03-02 10:54:55 +00:00
ryanml
2a6bcff4e2
Do not display experiment settings tab when there are no settings to show ( #17765 )
2023-03-02 10:52:58 +00:00
ryanml
970a5d4a77
Fix currency symbol in insufficient balance warning ( #17820 )
2023-03-02 10:48:09 +00:00
Brad Decker
d0aa143222
adds test and fix for conversion to use numeric ( #17758 )
2023-03-02 10:44:43 +00:00
Dan J Miller
48251a4189
Ensure simulation failure warning is shown on all networks and accounts ( #17458 )
...
* Ensure simulation failure warning is shown on all networks and accounts
* Add e2e test to cover failure warning behaviour on non-eip-1559 network
* Fix new e2e test
2023-03-02 10:44:36 +00:00
David Walsh
72ae54bfa3
UX: Icons: Use proper send icon on wallet and token overview pages ( #17720 )
2023-02-15 10:26:21 -07:00
MetaMask Bot
006242f096
Version v10.26.0
2023-02-09 20:41:43 +00:00
ryanml
3948e86fee
Merge pull request #17665 from MetaMask/master-sync
...
Sync `master` with `develop`
2023-02-09 13:35:21 -07:00
George Marshall
a5b908ccf3
Deprecating Typography component ( #17672 )
...
* Deprecating Typography component
* Fixing lint issue
2023-02-09 12:17:25 -08:00
Sam Gbafa
7aad1c9650
remove siwe feature flag ( #17690 )
...
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-10 02:05:16 +07:00
amerkadicE
0c2af508ef
Fix recent recipient order ( #16346 )
2023-02-09 23:15:52 +05:30
Pedro Figueiredo
26f6ae4c7c
Add testing documentation ( #17411 )
...
* Add testing documentation
* Implement diff filtering by regex
* change to relative import
2023-02-09 17:08:48 +00:00
ryanml
61ff47d71e
Merge branch 'develop' into master-sync
2023-02-09 10:07:39 -07:00
Olusegun Akintayo
6b64572f8d
Fix for error during sending to multisig address ( #17651 )
2023-02-09 10:49:39 -06:00
David Walsh
10be6fcfeb
UX: Update block explorer icon ( #17562 )
...
* UX: Update block explorer icon
* Removing unneeded CSS and some HTML bloat
* Removing unneeded className
* Removing unneeded CSS and reducing HTML bloat for ContractTokenValues
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-02-09 10:21:51 -06:00
ryanml
607b3d67e9
Merge branch 'develop' into master-sync
2023-02-09 04:45:39 -07:00
EresDev
58cd3deed5
fix test of useTransactionDisplayData for different timezone ( #17063 )
...
Co-authored-by: ryanml <ryanlanese@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Fixes https://github.com/MetaMask/metamask-extension/issues/17062
2023-02-08 17:13:39 -06:00
Jyoti Puri
61a7850afc
Sanitising string on signature request pages ( #17571 )
2023-02-09 04:35:52 +05:30
ryanml
c62e825f00
Conflict cleanup 10.25.0 master-sync
2023-02-08 13:54:51 -07:00
ryanml
e159c7987b
Merge remote-tracking branch 'origin/develop' into master-sync
2023-02-08 13:51:09 -07:00
Dan J Miller
d52ef73514
Merge pull request #17323 from MetaMask/Version-v10.25.0
...
Version v10.25.0
2023-02-08 12:31:44 -08:00
Elliot Winkler
7e97ff2be4
Expand network controller unit test coverage ( #17498 )
...
The network controller has some tests, but they are incomplete and don't
follow our latest best practices for writing unit tests.
This commit greatly increases the amount of test coverage for the API
that we want to retain in NetworkController, in particular the seemingly
myriad paths that the code takes starting from `initializeProvider`,
`resetConnection`, `setRpcTarget`, `setProviderType`,
`rollbackToPreviousProvider`, and `lookupNetwork`.
There were a couple of pieces of logic I noted which don't seem to have
any effect due to being redundant or unreachable, but they also don't
make our lives more difficult, either, so I opted to leave them in.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Zachary Belford <belfordz66@gmail.com>
2023-02-08 13:10:04 -07:00
Sam Gbafa
53205b6bff
Detect and track UI customizations on Personal Sign Requests ( #16222 )
...
* detect and track ui customizations on personal sign requests
* add feature flag check to metrics
* clean up comments
* get data only if it exists
* updated with PR feedback
* moved constants
* lint
* Apply suggestions from code review
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
---------
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-08 22:16:17 +07:00
Sam Gbafa
3233f76041
Sign-in with Ethereum Domain Binding ( #16616 )
...
* message error exploration
* validate siwe domain
* remove log
* added addUnapprovedMessage siwe tests
* updated error message + test
* improve detection test with counter-example
* fix test with mock
* added rejects
2023-02-08 22:06:01 +07:00
Mark Stacey
1d0522fd88
Update json-rpc-middleware-stream
from v2 to v4 ( #17588 )
...
This package has been updated to reduce the bundle size (we already use
the v4 version indirectly). The only breaking change applicable to the
usage of this package in the extension is to the package's exports. The
one import line has been updated accordingly.
This update comes with types (v3 was the TypeScript migration).
2023-02-08 11:15:00 -03:30
Nidhi Kumari
3be1fc6d0c
converted collectibles files to nfts ( #17658 )
...
* converted collectibles files to nfts
* updated relative import for scss
* updated scss for pages
2023-02-08 20:04:56 +05:30
Peter
523c90ade9
E2e test insights ( #17535 )
2023-02-08 08:34:44 -06:00
Elliot Winkler
75f2951f89
[TS dashboard] Reorganize files slightly ( #17335 )
2023-02-08 08:33:03 -06:00
Brad Decker
4cb2e573e5
add brad-decker as codeowner of .circle/ folder ( #17648 )
2023-02-08 08:29:15 -06:00
Maarten Zuidhoorn
ff85b040cb
Sort permissions based on weight ( #17660 )
2023-02-08 15:28:48 +01:00
Ariella Vu
b5c1de900d
Refactor ConfirmTransaction to Functional Component ( #17473 )
...
* ConfirmTransaction: rm unused metricEvent context
* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id
* ConfirmTransaction: convert to FC
* ConfirmTransaction: use const ORIGIN_METAMASK
* ConfirmTransaction: rm mapStateToProps
* ConfirmTransaction: mv confirm-transaction ducks
* ConfirmTransaction: mv getContractMethodData duck
* ConfirmTransaction: rm container file
* ConfirmTransaction: use ORIGIN_METAMASK const
* ConfirmationTransaction: add tests
* ConfirmTransaction: update jest mock after merge
* tests: update snapshot after mock-state updates
2023-02-08 18:00:25 +07:00
Matthew Walsh
92367dff79
Add desktop build type ( #17592 )
...
Implement build type inheritance.
Add CircleCI jobs for desktop build type.
2023-02-08 09:24:01 +00:00
Garrett Bear
661b5926ed
add double arrow icons ( #17654 )
2023-02-08 13:10:07 +05:30
chloeYue
82983694fe
Add e2e test: send nft ( #17638 )
...
* add e2e test send nft
2023-02-07 23:34:04 +01:00
George Marshall
b55f955243
Adding docs for layout and spacing for Icon component ( #17612 )
...
* Adding docs for layout and spacing for Icon component
* Adding close bracket
2023-02-07 10:07:50 -08:00
Thomas Huang
14efbf1eea
Collectible Unit Tests ( #17632 )
...
* Add ipfs gateway and collectible state to mock-state.json
* Add collectible-default-image test with snapshot and testids
* Add Collectible Details test, snapshot, and test-ids
* Add Collectible Options tests and test-ids
* Add Collectible Items test and test-ids.
* Add more tests to Add Collectible component
* Update Security Tab snapshot with ipfs gateway state value
* Add data-testid to Menu component for menu background
* Lint
* Bump coverage targets
* Remove commented import
---------
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-02-07 12:06:37 -06:00
PeterYinusa
4a2d7a7a2b
Reduce coverage targets
...
Updated in https://github.com/MetaMask/metamask-extension/pull/17325
Co-Authored-By: Brad Decker <bhdecker84@gmail.com>
2023-02-07 17:39:19 +00:00
Garrett Bear
fd53de6af5
Update BannerAlert component ( #17586 )
...
* update button alert component
* update test
* rename Banner to BannerAlert
* remove old banner snapshot
* fix banner alert border left
2023-02-07 09:32:35 -08:00
ryanml
0989678f03
Fixing yarn version command, adding yarn version plugin ( #17325 )
...
* Removing invalid flags for yarn version command
* Adding yarn version plugin
* remove .yarn from coverage
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-02-07 17:28:09 +00:00
PeterYinusa
26aa9f3ecb
Fixing yarn version command, adding yarn version plugin ( #17325 )
...
* Removing invalid flags for yarn version command
* Adding yarn version plugin
* remove .yarn from coverage
---------
Co-Authored-By: Brad Decker <bhdecker84@gmail.com>
2023-02-07 17:16:14 +00:00
ryanml
8a090c3618
Updating changelog for v10.25.0 ( #17573 )
...
* Updating changelog for v10.25.0
* Update changelog
---------
Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
2023-02-07 15:11:57 +00:00
PeterYinusa
e3777319ed
Reduce coverage targets
...
Updated in https://github.com/MetaMask/metamask-extension/pull/17326
2023-02-07 14:07:25 +00:00