1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/test
Mark Stacey 95f198550e
Declare variables before use (#6806)
While working on #6805, I noticed that many variables were being used
before they were declared. Technically this worked fine in practice
because we were using the `transform-es2015-block-scoping` Babel plugin,
which transforms `let` and `const` to `var`, which is hoisted. However,
after removing that Babel transformation, many things broke.

All instances of variables or classes being used before declared have
been fixed.

The `no-use-before-define` eslint rule has been added to catch these
cases going forward. The rule is disabled for function declarations for
the moment, because those are always hoisted. We could disable that too
if we want to, but it's purely stylistic and would require a lot more
changes.
2019-07-05 14:01:34 -03:00
..
data feature: add Goerli support (#6459) 2019-04-17 15:04:49 -02:30
e2e Move e2e tests out of beta dir (#6785) 2019-07-02 23:19:59 -02:30
integration Move e2e tests out of beta dir (#6785) 2019-07-02 23:19:59 -02:30
lib Check for unused function arguments (#6583) 2019-05-08 15:51:33 -04:00
screens fix warning for new-ui screen tests 2018-07-02 20:13:04 -04:00
stub Merge branch 'develop' into testing 2018-05-21 14:57:57 -07:00
unit Declare variables before use (#6806) 2019-07-05 14:01:34 -03:00
web3 Check for unused function arguments (#6583) 2019-05-08 15:51:33 -04:00
base.conf.js eslint --fix . 2018-07-02 18:49:33 -04:00
flat.conf.js eslint --fix . 2018-07-02 18:49:33 -04:00
helper.js 4byte fallback (#6551) 2019-06-18 09:47:14 -02:30
setup.js Adds not yet functional gas price chart. 2018-12-04 00:06:05 -03:30