1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
metamask-extension/development
Mark Stacey ec40b2a325
Check for invalid gas estimates from local storage (#6800)
* Remove unused state 'gas.basicPriceAndTimeEstimates'

* Check for invalid estimates from local storage

Gas estimates were being cached in local storage then later retrieved,
but the retrieved values were not being checked. If the data failed to
save, failed to load, or was cleared since being saved, it would result
in the gas estimates being set to undefined.

The estimates retrieved from local storage are now checked before they
are used. If they are falsy, the estimates are retrieved from the
network instead.

This should fix this Sentry issue:
[METAMASK-6W0T](https://sentry.io/share/issue/cfe470314a5741768b19050815322aa4/)

A few additional changes were made to the gas-duck tests to accommodate
the use of `sinon.restore`. `restore` is strongly recommended by the
`sinon` team, as neglecting to use it can result in memory leaks. It has
the additional benefit of ensuring you create fresh stubs/spies for each
test, which means they no longer need to be reset between tests.
2019-07-04 16:18:12 -03:00
..
notices
states Check for invalid gas estimates from local storage (#6800) 2019-07-04 16:18:12 -03:00
tools
announcer.js eslint --fix . 2018-07-02 18:49:33 -04:00
auto-changelog.sh Add rollback script, move auto-changelog script (#6252) 2019-03-20 09:48:50 -02:30
backGroundConnectionModifiers.js Check for unused function arguments (#6583) 2019-05-08 15:51:33 -04:00
genStates.js Speed up genStates script by using built-in require fn 2018-11-20 14:04:50 -03:30
index.html
metamaskbot-build-announce.js Remove broken image walkthrough from metamaskbot comment 2019-03-29 12:39:43 -02:30
mock-dev.js Folder restructure (#6304) 2019-03-21 20:33:30 -02:30
mockExtension.js eslint --fix . 2018-07-02 18:49:33 -04:00
README.md
rollback.sh Add rollback script, move auto-changelog script (#6252) 2019-03-20 09:48:50 -02:30
run-version-bump.js eslint --fix . 2018-07-02 18:49:33 -04:00
selector.js eslint --fix . 2018-07-02 18:49:33 -04:00
sentry-publish.js CI - Allow sourcemap uploads to sentry for empty version (#5403) 2018-10-10 10:24:25 -04:00
sourcemap-validator.js development - enhancement for sourcemap validator tool (#6277) 2019-03-11 09:55:43 -07:00
states.json
test.html
ui-dev.js Folder restructure (#6304) 2019-03-21 20:33:30 -02:30
uiStore.js Folder restructure (#6304) 2019-03-21 20:33:30 -02:30
verify-locale-strings.js development tools - fix i18n verify tool 2018-11-04 22:18:30 -05:00
version-bump.js Version 5.0.3 (#5785) 2018-11-20 08:34:14 -10:00

Development

Several files which are needed for developing on(!) MetaMask.

Usually each files contains information about its scope / usage.