1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts/controllers
Mark Stacey 52d25f0df8
Fix inflated gas estimates (#9984)
If a `gasPrice` was specified in a transaction sent via a dapp, we
would include it in our `eth_estimateGas` call, causing it to fail if
the user had insufficient balance (for either the transaction amount or
the gas fee). This resulted in the fallback gas estimate being used;
the block gas limit. The block gas limit is quite a bit larger than
most transactions need, so this resulted in wildly inflated gas costs
being shown on our confirmation screen.

The `gasPrice` has been removed from the `txParams` object we pass to
`eth_estimateGas`, so now it won't perform any balance checks anymore.
This ensures that we'll get a valid gas estimate, as long as geth is
able to simulate the contract execution properly.

Fixes #9967
2020-12-03 13:55:42 -03:30
..
ens [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
network add new MetaMetricsController (#9857) 2020-12-02 15:41:30 -06:00
permissions json-rpc-engine@6.1.0 (#9922) 2020-12-02 11:41:24 -08:00
transactions Fix inflated gas estimates (#9984) 2020-12-03 13:55:42 -03:30
alert.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
app-state.js Make JSDoc formatting more consistent (#9796) 2020-11-10 14:00:41 -03:30
cached-balances.js Make JSDoc formatting more consistent (#9796) 2020-11-10 14:00:41 -03:30
detect-tokens.js @metamask/contract-metadata (#9968) 2020-12-01 14:55:01 -08:00
incoming-transactions.js expand transaction constants coverage (#9790) 2020-11-07 01:38:12 -06:00
metametrics.js add new MetaMetricsController (#9857) 2020-12-02 15:41:30 -06:00
onboarding.js Track whether seed phrase has been backed up (#9830) 2020-11-10 12:34:20 -03:30
preferences.js Remove use of ethgasstation; use metaswap /gasPrices api for gas price estimates (#9867) 2020-12-02 19:55:19 -03:30
swaps.js Alternative savings fix (#9675) 2020-11-09 13:39:38 -03:30
threebox.js json-rpc-engine@6.1.0 (#9922) 2020-12-02 11:41:24 -08:00
token-rates.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00