1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app
Mark Stacey 52d25f0df8
Fix inflated gas estimates (#9984)
If a `gasPrice` was specified in a transaction sent via a dapp, we
would include it in our `eth_estimateGas` call, causing it to fail if
the user had insufficient balance (for either the transaction amount or
the gas fee). This resulted in the fallback gas estimate being used;
the block gas limit. The block gas limit is quite a bit larger than
most transactions need, so this resulted in wildly inflated gas costs
being shown on our confirmation screen.

The `gasPrice` has been removed from the `txParams` object we pass to
`eth_estimateGas`, so now it won't perform any balance checks anymore.
This ensures that we'll get a valid gas estimate, as long as geth is
able to simulate the contract execution properly.

Fixes #9967
2020-12-03 13:55:42 -03:30
..
_locales Remove use of ethgasstation; use metaswap /gasPrices api for gas price estimates (#9867) 2020-12-02 19:55:19 -03:30
fonts Add euclid fontface (#9018) 2020-07-27 17:15:44 -05:00
images Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
manifest Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00
scripts Fix inflated gas estimates (#9984) 2020-12-03 13:55:42 -03:30
vendor/trezor Close window after opening fullscreen (#6966) 2019-08-08 11:50:32 -03:00
home.html Add optional portal to Popover component (#8253) 2020-03-30 18:25:17 -02:30
loading.html refactor & change html pages 2019-05-04 18:57:19 +02:00
notification.html Provide alternative text for images where appropriate 2020-11-11 09:38:15 -06:00
phishing.html Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00
popup.html Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00
trezor-usb-permissions.html trezor v5 working on firefox 2018-08-05 02:43:02 -04:00