1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts
Akintayo A. Olusegun 319ab42bc1
Fix for #11503: when you send a transaction with value as 0x, you get a Bignumber error (#11996)
* Fix for #11503: when you send a transaction with value  as 0x, you get a
Bignumber error. Fix this by setting value to 0x0 is it's 0x.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* 1. Fix this in app/scripts/controllers/transactions/lib/utils.js
2. Make sure other non-hex non-valid strings for value return 0x0

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Linting Fixes.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Instead of returning 0x0 for invalid hex values, throw a descriptive
error

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Unit tests.
Lint fixes.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* assert.throws takes a function

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Lint Fixes.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Use standardized error message.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* remove fixHexValue
move code validating hex value to validateTxParams

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Change message displayed if hex string is invalid.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* Fixed missing second quote mark on message.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2021-10-15 13:04:14 +01:00
..
account-import-strategies Use strict assertion mode everywhere (#11012) 2021-05-07 17:08:24 -02:30
constants Add support for fiat on-ramp via Transak (#11376) 2021-06-25 08:10:24 -05:00
controllers Fix for #11503: when you send a transaction with value as 0x, you get a Bignumber error (#11996) 2021-10-15 13:04:14 +01:00
lib Fix 12145 - Ledger errors being set as Error: [object, object] (#12176) 2021-09-22 10:41:23 -07:00
migrations Jestify continue (#12173) 2021-09-22 08:15:40 -07:00
platforms Normalize extension verison to SemVer (#12254) 2021-10-14 18:50:14 -02:30
background.js bump @metamask/controllers to v15.0.2 and remove AbortController workaround in e2e tests (#11988) 2021-09-03 09:34:21 -05:00
contentscript.js @metamask/post-message-stream@4.0.0 (#10989) 2021-05-05 16:07:48 -07:00
disable-console.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
first-time-state.js @metamask/eslint config@5.0.0 (#10358) 2021-02-04 10:15:23 -08:00
inpage.js @metamask/providers@8.1.1 (#11078) 2021-05-12 19:51:14 -07:00
lockdown-more.js lockdown - breakout making globalThis properties non-writable (#12258) 2021-10-01 08:53:12 -10:00
lockdown-run.js lockdown - breakout making globalThis properties non-writable (#12258) 2021-10-01 08:53:12 -10:00
metamask-controller.js Fix inpage provider behavior on unlock (#12339) 2021-10-14 10:50:07 -07:00
metamask-controller.test.js Use hardware constants everywhere (#12329) 2021-10-13 09:25:27 -05:00
phishing-detect.js Autofilling new issue link with url and domain (Phishing detect page) (#12000) 2021-09-03 11:22:28 -07:00
sentry-install.js Build - refactor for bundle factoring and swappable runtime (#11080) 2021-07-15 10:59:34 -07:00
ui.js bump @metamask/controllers to v15.0.2 and remove AbortController workaround in e2e tests (#11988) 2021-09-03 09:34:21 -05:00