1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Commit Graph

15980 Commits

Author SHA1 Message Date
Harry
fd819451e1
🐛 Calldata validation (#17326)
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: brad-decker <bhdecker84@gmail.com>
2023-02-01 16:34:55 -06:00
Garrett Bear
b0ed6be77a
remove unused banner base proptype (#17531) 2023-02-01 13:44:57 -08:00
Mark Stacey
db2e461416
Add tests for retryOnEmpty middleware (#17364)
* Add tests for `retryOnEmpty` middleware

Tests have been added for the `retryOnEmpty` middleware.

This middleware is only used on the Infura network client, so the tests
that demonstrate this retry behavior are only enabled for the `infura`
provider type.

Most of the tests added were to cover cases where the retry middleware
is skipped, so they were applicable for both provider types.

Closes #17004

* Improve readability of block number tests

The test cases for passing a block number parameter have been made more
readable. Specifically, a comment has been added each time params are
built to call attention to the block parameter and what value it has,
so that it's clear whether it's larger or smaller than the current
block number.

Additionally the blocks for "less than the current block number" and
"equal to the current block number" have been combined using
`describe.each`.
2023-02-01 16:33:26 -03:30
Brad Decker
0885c6cd1f
prefer locale slice for locale state (#17499) 2023-02-01 11:53:35 -06:00
Brad Decker
d9275bb1c1
Fixing/extending type definitions for later usage (#17514) 2023-02-01 11:53:21 -06:00
Brad Decker
c43b1b6191
TypeScript tooling fixes (#17513)
* TypeScript tooling fixes

* refine the dashboard ignore patterns
2023-02-01 10:51:12 -06:00
David Walsh
03d8ee5eae
Onboarding V2: Remove old onboarding flow (#17081) 2023-02-01 09:28:09 -06:00
Jyoti Puri
8fd65a698e
Fix build (#17538) 2023-02-01 19:07:15 +05:30
Garrett Bear
db0492e042
fix button text props (#17478)
* fix button text props

* fix textProps size from being overriden

* Update ui/components/component-library/button-link/button-link.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-02-01 13:25:46 +05:30
Jyoti Puri
26222a9b27
Refactoring confirm-transaction-base component (#17484) 2023-02-01 11:24:41 +05:30
Jyoti Puri
80fb59f0a0
Refactor conf-tx.js (#17380) 2023-02-01 11:24:18 +05:30
ryanml
83a3ce1aa0
Fix RPC Url editing issue of existing network (#17451) 2023-01-31 18:22:47 -07:00
ryanml
5e863a297f
Adjust 'Confirm' button color on setApprovalForAll revocations (#17506) 2023-01-31 18:22:33 -07:00
Brad Decker
6e7f5c3e21
Move THEME_TYPE to new preferences.ts file (#17515) 2023-01-31 17:49:00 -06:00
David Walsh
7a29d896ad
Fix #17328 - Move NFT settings to Experimental (#17400)
* Fix #17328 - Move NFT settings to Experimental

* Don't indent second NFT setting

* Fix jest test
2023-01-31 12:50:53 -06:00
David Walsh
145cf1ec01
UX - Update all copy icons (#17445) 2023-01-31 11:00:26 -06:00
Vladimir Saric
8aa3263b82
Added navigation between multiple sign prompts and reject all sign prompts (#17093)
* Fixed navigation through multiple unapproved transactions for ERC20 tokens

* Fixed tx details activity-log currency

* Fixed e2e test failure

* Added navigation between multiple sign prompts and reject all sign prompts

* Resolving conflicts

* Creating SignatureRequestNavigation component and extracting the UI rendering part into a single component

* Fixing e2e tests and updating snapshot

* Using single component for navigation which shows both messages and transactions requests

* Fixing test-unit-jest-main

* Added more unit tests

* Fixing test-storybook

* Fixing test-storybook

---------

Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
2023-01-31 16:29:23 +01:00
David Walsh
6439d03075
Fix #17439 - Prevent event error when user presses enter key during onboarding (#17497) 2023-01-31 08:47:55 -06:00
David Walsh
18a1beb3dd
Update overview icons for buy, send, and swap (#17492) 2023-01-31 08:47:43 -06:00
David Walsh
d057410762
New Icons: Replace instance of fa-qr-code icon (#17474)
* New Icons: Replace instance of fa-qr-code icon

* Update ui/pages/send/send-content/add-recipient/domain-input.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-01-31 08:47:23 -06:00
David Walsh
edb2c9ea00
Fix #17441 - Update all MenuItem instances to use new icons (#17468) 2023-01-31 08:47:00 -06:00
David Walsh
ff843c1b10
Fix #17393 - Fix NFT collection header image (#17394) 2023-01-31 08:46:40 -06:00
chloeYue
812b57dcaf
Add e2e test: add custome network during onboarding (#17436)
* e2e test add custome network during onboarding
2023-01-31 13:58:39 +01:00
Danica Shen
2958d68af8
feat(mme-17214): migrate L33 files to typescript (#17372) 2023-01-31 12:01:10 +00:00
ryanml
8a7c897a1c
Update copy when revoking setApprovalForAll (#17500) 2023-01-31 04:27:41 -07:00
ryanml
25728563c8
Merge pull request #17504 from MetaMask/master-sync
master sync following v10.24.2
2023-01-31 03:49:46 -07:00
Dan Miller
ce9bc2236d Merge remote-tracking branch 'origin/develop' into master-sync 2023-01-30 21:58:52 -03:30
Dan J Miller
fdeb1e9dc9
Merge pull request #17472 from MetaMask/Version-v10.24.2
Version v10.24.2 RC
2023-01-30 17:21:16 -08:00
David Walsh
acafe7c4c5
Update home portfolio dapp icon to new icon (#17471)
* Update home portfolio dapp icon to new icon

* Using ButtonLink component so onClick isn't used on a div

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-01-30 12:33:08 -06:00
Mark Stacey
55d8ec0572
Document displayWarning as deprecated (#17465)
The `displayWarning` action creator will show the error in various
different places in the UI. This is confusing for users, we should stop
doing this.

Instead we can consider each error case separately. If there is a
scenario where it's appropriate to tell a user about an error, we
should build that case into the relevant UI and use localized error
messages.
2023-01-30 09:37:04 -03:30
Mark Stacey
e58800952c
Ignore storybook-build lint errors (#17373)
The `storybook-build` directory is the Storybook build output. These
are generated files that we do not need to lint.
2023-01-30 09:36:52 -03:30
Guillaume Roux
82f2ba15e6
remove snap notifications when uninstalled (#17487) 2023-01-30 13:43:47 +01:00
Dan J Miller
665f22d236 Update changelog for v10.24.2: adding entry for #17432 2023-01-30 08:55:31 -03:30
Dan J Miller
a31eccd01e Fix unit tests that were removed on develop in #16862, but broken in master with #17450 2023-01-30 06:23:59 -03:30
Jyoti Puri
58b5332b67 Improving getMemoizedMetadataContractName selector (#17432) 2023-01-27 12:33:02 -07:00
Peter Yinusa
245c32a99e
Nft build for e2e tests (#17430) 2023-01-27 12:45:35 -06:00
Danica Shen
c23bd4925b
feature: convert level 32 files to typescript (#17390) 2023-01-27 18:28:03 +00:00
ryanml
62bca62273 Updating changelog 2023-01-27 11:09:23 -07:00
Dan J Miller
5f5b75832f Fix cookiejar dependency vulnerability (#17355) 2023-01-27 11:06:43 -07:00
MetaMask Bot
76ebc3318c Version v10.24.2 2023-01-27 17:40:38 +00:00
Dan J Miller
c9acbfb973 Use network provider state, instead of CurrencyRateController state, to select 'nativeCurrency' (#17450)
* Use network provider state, instead of CurrencyRateController state, select 'nativeCurrency'

* Fix unit tests

* Lint fix

* Only use the network provider ticket for the native currency when useCurrencyRateCheck is false

* Fix unit test

* Fix tests for real
2023-01-27 10:37:38 -07:00
Dan J Miller
7a77c82514
Use network provider state, instead of CurrencyRateController state, to select 'nativeCurrency' (#17450)
* Use network provider state, instead of CurrencyRateController state, select 'nativeCurrency'

* Fix unit tests

* Lint fix

* Only use the network provider ticket for the native currency when useCurrencyRateCheck is false

* Fix unit test

* Fix tests for real
2023-01-27 13:47:47 -03:30
dzfjz
abb2532a3b
[e2e]Add e2e test for deleting custom network (#17254)
* add test for deleting added custom network

* update code because of failing on firefox browser

* changing steps for adding custom network

* chage code for custom network
2023-01-27 16:50:08 +00:00
David Walsh
6ee2d07706
Fix #17362 - Ensure NFT icons are correct (#17440)
* Fix #17362 - Ensure NFT icons are correct

* Update trash icon
2023-01-27 08:32:03 -06:00
David Walsh
b21e0df4fa
Fix #17385 - Provide autohide callback for ActionMessage (#17392)
* Fix #17385 - Provide autohide callback for ActionMessage

* Add autohide to the removeal message
2023-01-27 08:31:43 -06:00
Garrett Bear
30520a3352
button link housekeeping (#16885)
* button link housekeeping

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-01-26 10:32:11 -08:00
weizman
e33b8976cd
Bump lavapack version to 5 (#17431)
* Update package.json

* update
2023-01-26 14:34:13 -03:30
Danica Shen
787add7c70
feature: convert shared/modules/contract-utils.test.js to typescript (#17435) 2023-01-26 17:59:49 +00:00
amerkadicE
ab329e5186
Refactor confirm page container component from class to functional component (#16907) 2023-01-26 11:07:17 -06:00
Mark Stacey
001ea4c951
Test parameter change cache miss (#17346)
Tests have been added to ensure that our middleware will not return a
cached response to a request with unique parameters. Each parameter
supported by each method is tested independently.

Closes #17003
2023-01-26 12:27:46 -03:30