Monte Lai
f9a3bc8070
18566 firefox ledger u2f message ( #18570 )
...
* check for user agent
* fix regex
* fix lint
* update link
* add test
* update message
* update coverage
* fix test names
* update text
* add whats new notification for firefox and ledger users
* update action button link
* update notification text
* update viewed notification
* update coverage
* update coverage
2023-04-20 07:44:43 -02:30
Dan J Miller
baf0ad5c21
Fix swaps controller: update provider after networkIdStore state update ( #18670 )
...
* Fix swaps controller: update provider after networkIdStore state update
* Listen for changes on networkController.store, instead of networkController.networkIdStore, in the swaps controller
* Fix unit tests
2023-04-19 18:17:23 -02:30
Mark Stacey
cffce88e32
Fix Sentry console logs ( #18539 )
...
Sentry console logs were failing with the error "Error: TypeError:
Cannot read properties of undefined (reading 'log')". This error has
been fixed; now Sentry can log errors to the console.
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 16:58:49 -02:30
Danica Shen
5e95e8140f
fix(18574): fix new BigNumber() not a number: undefined for setApprovalForAll method ( #18660 )
2023-04-19 16:58:35 -02:30
David Drazic
525d5ff54e
[FLASK] Revert changes made to stable permission display (UI design) ( #18470 )
...
* Revert changes made to stable permission display (UI design)
* Add test for new component
* Update paddings for install flow
* Fix missing icons on snap installation flow
* Update storybook path
* Add targetSubjectMetadata param
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-04-19 14:09:09 -02:30
vthomas13
b7518c0810
adding notification 18 title ( #18526 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 13:07:33 -02:30
PeterYinusa
aef27db737
update policies
2023-04-19 16:24:47 +01:00
Dan J Miller
bffbfe1fad
Fix merge conflict introduced by cherry-picking ad11352
without also having 3577d3545f
on the branch
2023-04-19 11:31:30 -02:30
Jyoti Puri
e091e77674
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-19 07:50:37 -02:30
Brad Decker
ad11352199
use network did change instead of state update for assetsContractController ( #18629 )
2023-04-19 07:50:37 -02:30
Jyoti Puri
600909418c
Fix approve all warning modal ( #18613 )
...
* Fix approve all warning modal
* fix
* fix
* fix
2023-04-19 07:50:37 -02:30
Dan J Miller
3cc82898a6
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-19 07:50:37 -02:30
Dan J Miller
a97383d62e
Pass correct params to fetchEstimatedL1Fee in the swaps controller ( #18634 )
2023-04-19 07:50:37 -02:30
Jyoti Puri
b69e662ba5
Fix error in console on rejecting signature request ( #18614 )
2023-04-19 07:50:37 -02:30
Danica Shen
f8f1abf53c
fix/18577: Add title back for approving ERC20 token ( #18617 )
...
* fix/18577: Add title back for approving ERC20 token
* Apply suggestions from code review
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-19 07:50:36 -02:30
Jyoti Puri
9fa099f5fc
Fix issue with requests with empty data being forwarded to opensea ( #18598 )
2023-04-19 07:50:36 -02:30
Ariella Vu
7e14686ec7
siwe: add ledger instructions ( #18589 )
2023-04-19 07:50:36 -02:30
Matthew Walsh
58ed6af3a4
Disable rate limiting for signature approval requests ( #18594 )
2023-04-19 07:50:32 -02:30
George Marshall
2575fe1da8
Fix hold to reveal button ( #18496 )
2023-04-19 07:46:56 -02:30
Jyoti Puri
ca7f61126c
Improvement on approval pages ( #18545 )
2023-04-19 07:46:56 -02:30
MetaMask Bot
467858fb78
Version v10.29.0
2023-04-06 17:07:58 +00:00
vthomas13
c6cd3c9ff2
Bumping notification id's to 18 & 19 ( #18460 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-04-06 12:38:11 -02:30
Dan J Miller
afa09ddf6c
Fix switch-ethereum-chain handler by passing configuration id to setA… ( #18483 )
...
* Fix switch-ethereum-chain handler by passing configuration id to setActiveNetwork
* fix e2e test
* Fix e2e tests
* Update test/e2e/tests/switch-custom-network.spec.js
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
* Revert "Update test/e2e/tests/switch-custom-network.spec.js"
This reverts commit be533ff7f25e1fd42e951d9b817b8438035ae256.
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-06 12:37:34 -02:30
Bowen Sanders
90f4e47326
[FLASK] More Snaps E2E Optimization and Delay Reductions ( #18245 )
...
* bip32 delay reduction
* asserts changed to waitFors in 32/44
* scrollTo change
* replaced delay for firefox flake
* more reduced delays
* more delay reductions and changes
* raise paralellism to 4 for snaps tests
* additional delay changes
* fixed update code
* removed comment
* removed another comment
2023-04-06 10:57:11 -04:00
Dan J Miller
b2dc2c4639
Fix firsttimeloaded logic ( #18344 )
...
* use session storage, instead of chrome.runtime.onStartup and globalThis, for firstTimeLoaded architecture
* Ensure account tracker accounts remain defined upon service worker restart
* lint fix
* Simplify code
* Only call browser.storage.session in mv3
* Only call browser.storage.session.set after resetStates in mv3
* fix metamask controller reset states unit tests
* fix test
* fix test
* Actually fix tests
* lint fix
2023-04-06 12:13:01 -02:30
António Regadas
cf0b48a009
removes unnecessary images ( #18484 )
2023-04-06 15:32:01 +01:00
Danica Shen
f92e463a0f
fix: Pass correct optimism chain id to gas estimation ( #18478 )
2023-04-06 12:50:52 +01:00
Aditya Patel
18ff108627
Typography to text ( #18382 )
...
* Typography to text
* Update README.md
* Update README.md
* minor changes in custom file
* minor change
* Resolved Conflict issues
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-06 16:40:14 +05:30
legobeat
a816a6e592
Fix typo: detetcted-tokens-link -> detected-tokens-link ( #18408 )
2023-04-06 18:31:45 +09:00
Thomas Huang
baee6f185c
Bump coverage ( #18454 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-05 13:45:02 -02:30
George Marshall
4ce605f514
Updating icon imports to TS version in component-library folder ( #18449 )
2023-04-05 09:11:10 -07:00
George Marshall
94292fadc9
Small update to badgewrapper story ( #18450 )
2023-04-05 08:37:09 -07:00
Frederik Bolding
40628da3b4
[FLASK] Fix crash when requesting unknown snap permission ( #18447 )
2023-04-05 15:34:33 +02:00
Albert Olivé
c52d2131d3
[MMI] Confirm-add-institutional-feature page ( #18321 )
...
* Added confirm add institutional feature page
* Finished implementing component
* Added all institutional ducks
* Fixed tests
* Removed ducks and console log
* Fixed snapshots
* Fixed messages json
* Changed method name and using useEffect
* Replace useEffect hook with a simple if statement to check if connectRequest exists and add null return statement to avoid warnings
* Remove unneeded dependency
* Added back useEffect and added a extra check to return null if connectRequest is false
* Fixed eslint problem
* Fixed all issues commented in the pr
2023-04-05 09:50:30 +01:00
Vinicius Stevam
b9c5120332
Remove openPopup from preferences controller ( #18343 )
2023-04-05 08:39:58 +01:00
Thomas Huang
3a38140cb6
Onboarding app header onboarding unit test and snapshot ( #18254 )
2023-04-04 19:59:09 -07:00
George Marshall
739075662c
Migrating Icon to typescript and deprecating JS component ( #18431 )
...
* Migrating Icon to typescript and deprecating JS component
* gw suggestions (#18434 )
---------
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-04-04 09:48:04 -07:00
OGPoyraz
6e40a0eb7e
feat: use siwe detection from @metamask/controller-utils ( #18409 )
2023-04-04 17:25:57 +02:00
Dan J Miller
7a8d0273a0
Don't include document in scuttling config for mv3 builds ( #18356 )
...
* Don't include document in scuttling config for mv3 builds
* Fix env var comparison
* lint fix
2023-04-04 12:45:50 -02:30
Mark Stacey
2029fb28ff
Fix MMI build ( #18415 )
...
In the MMI build, the build fencing in this component resulted in an
`else` block with no preceding `if` block, which is a syntax error.
The fence in this case was meant to include "all non-Flask build
types", MMI was mistakenly missing from that list.
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-04-04 10:29:10 -02:30
Mark Stacey
b8422b0b43
Merge pull request #18439 from MetaMask/master-sync
...
Master sync for v10.28.1
2023-04-04 10:26:58 -02:30
Mark Stacey
8f4651332f
Merge branch 'develop' into master-sync
2023-04-04 09:28:14 -02:30
Mark Stacey
7059894399
Update @metamask/swappable-obj-proxy
( #18422 )
...
* Update `@metamask/swappable-obj-proxy`
The package `@metamask/swappable-obj-proxy` has been updated to the
latest version. The breaking changes include moving the package under
the `@metamask` scope and converting it to TypeScript.
* Update policy
2023-04-04 09:27:51 -02:30
PeterYinusa
6338931e62
Conflict cleanup 10.28.1 master-sync
2023-04-04 11:38:49 +01:00
PeterYinusa
fc620d4de6
Merge remote-tracking branch 'origin/develop' into master-sync
2023-04-04 11:35:15 +01:00
Nidhi Kumari
4b271868cf
Disabled button for Import Tokens Modal when no token is selected ( #18396 )
...
* disabled button for zero token
* addressed changes
2023-04-04 11:23:05 +05:30
Mark Stacey
a6b7a72179
Merge pull request #18432 from MetaMask/Version-v10.28.1
...
Version v10.28.1 RC
2023-04-03 18:37:11 -02:30
Dan J Miller
40ff144472
Update CHANGELOG.md
...
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-04-03 18:00:45 -02:30
Dan Miller
cf92aa3b70
Update changelog for v10.28.1
2023-04-03 17:56:46 -02:30
MetaMask Bot
6aa877361b
Version v10.28.1
2023-04-03 20:05:58 +00:00