Brad Decker
f586f142be
add an extra identifier on anonymized duplicate events ( #17080 )
2023-01-05 08:49:55 -06:00
Filip Sekulic
e6038d542a
Update UI for transaction security check in settings ( #16830 )
2023-01-04 15:59:48 -06:00
Mark Stacey
8d28fbccc5
Stop block tracker after each network controller unit test ( #17032 )
...
The network controller unit tests have been updated to stop the block
tracker after each test. This was accomplished with a new `destroy`
method.
2023-01-04 17:46:22 -03:30
MetaMask Bot
5456ec1bf1
New Crowdin translations by Github Action ( #15999 )
...
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
2023-01-04 14:22:06 -05:00
Brad Decker
35e3b7e82e
fix audit failure ( #17079 )
2023-01-04 11:29:37 -06:00
Vladimir Saric
4d12c36cf8
Align custom spending cap Max button in approve screen for multiple languages ( #16927 )
...
* Align custom spending cap Max button in approve screen for multiple languages
* Modify some css styles and adding Box props
* Using ButtonLink component instead of <button/>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-01-04 22:31:52 +05:30
Adnan Sahovic
54cbc66120
Improve transaction complete popup ( #16300 )
...
* modified transaction complete popup
deleted upperCase function
deleted replaceAll
fixed lint
* resolved conflicts
* modified view const
Co-authored-by: Vladimir Saric <92527393+VSaric@users.noreply.github.com>
2023-01-04 09:40:42 -06:00
Vladimir Saric
23653f4c08
Added unit tests and story for SignatureRequestData component ( #16759 )
2023-01-04 09:31:23 -06:00
Frederik Bolding
05d50eee73
Improve SignatureRequest performance ( #17052 )
...
* Improve SignatureRequestData performance
* Memoize more selectors
2022-12-22 16:37:51 -03:30
HowardBraham
b9d9112b97
Prevent account name collisions ( #16752 )
...
* dealt with most of the problems in the Create Account dialog
* Fixed "newAccountNumberName" localizations
* In another language, don't allow accounts named, for instance, Cuenta 3
* Editing an account name later now follows the same rules
* Fixing lint errors
* Responding to the review by @adonesky1
* Worked with @montelaidev to alter the RegExp, in order to catch spaces before and after the account name
* Fixed line breaks for eslint
2022-12-22 11:27:31 -06:00
weizman
3cf5ef642f
Revert "Integrate new LavaMoat scuttling protection feature ( #16994 )" ( #17043 )
2022-12-22 17:26:53 +02:00
Mark Stacey
b0959e221b
Add codefi.network host permission ( #17029 )
...
This host permission bypasses cross-origin restrictions for our
internal APIs (see here for details on host permissions and CORs [1]).
This acts as a safeguard, ensuring that if CORs is misconfigured on
these endpoints, everything will still work.
[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#host_permissions
2022-12-22 09:56:33 -03:30
chloeYue
d66db28ae6
Add e2e test for reset account ( #16996 )
...
* add test for reset account
2022-12-22 14:16:09 +01:00
Mark Stacey
d222f652c3
Upgrade prettier-plugin-sort-json to v1 ( #17026 )
...
This upgrade includes no changes relevant to our usage of this plugin.
2022-12-21 19:17:45 -03:30
Daniel
2832f8a97e
Update quote selection for Optimism ( #16998 )
2022-12-21 20:59:34 +01:00
Guillaume Roux
3cfef11f71
[FLASK] Resolve snap_dialog approval on close ( #16801 )
2022-12-21 20:15:52 +01:00
Nidhi Kumari
f8881a01db
AvatarWithBadge Housekeeping ( #16985 )
...
* updated classnames
* updated readme and tests for avatar with badge
* updated constants in root
* replacing BADGE_POSITIONS with AVATAR_WITH_BADGE_BADGE_POSITIONS
2022-12-22 00:36:40 +05:30
weizman
5d320ceec6
Integrate new LavaMoat scuttling protection feature ( #16994 )
...
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
Co-authored-by: kumavis <aaron@kumavis.me>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-12-21 12:54:30 -06:00
Ariella Vu
25e9184d9a
i18n: fix missing locale for "en" error ( #17014 )
...
on locale change
2022-12-22 00:31:06 +07:00
Brad Decker
ee321971e7
add new yarn3 paths to circleci cache ( #16873 )
2022-12-20 15:33:18 -06:00
Alex Donesky
1a842aabb6
Replace eth-optimism/contracts package with local snippet of gas price ABI and address ( #16891 )
2022-12-20 14:05:07 -06:00
Zachary Belford
6f6984fa58
Moved subscribe and filter into network controller ( #16693 )
...
Our middleware for handling subscription and filter-related methods (`eth-json-rpc-filters`) currently lives in our RPC pipeline ahead of the network stack. This commit moves this middleware to the network client middleware instead. There are two reasons for this change. First, this middleware wraps RPC methods that are supported by the network. Second, it is necessary for this middleware to live with the network client so that it will aid us in unifying the NetworkController in this repo and the NetworkController in the `controllers` repo.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
2022-12-20 10:28:09 -07:00
amerkadicE
362497ed64
Track when token balance is changed to update value on approval screen ( #16964 )
...
* Track when token balance is changed to update value on approval screen
* Code refactor
* Fix unit test
* Fix sign approval balance
* Refactor code
2022-12-20 09:24:28 -03:30
Jyoti Puri
c61d44a3be
Making add un-approved transaction idempotent ( #16995 )
2022-12-20 18:01:37 +05:30
Frederik Bolding
7e7a0f1f72
[FLASK] Use custom UI for transaction insights ( #16912 )
...
* Allow custom UI for transaction insights
* Fix margin
* Small fixes to CSS and selectors
* Rename property
* Fix E2E locally
* Bump test-snaps
* Bump test-snaps
2022-12-20 11:44:49 +01:00
Guillaume Roux
85f260c22d
[FLASK] Use custom UI for dialogs ( #16973 )
...
* update dialog templates to use custom UI
* add TODO comments
* Fix showDialog hook and destructuring
* Regen LavaMoat policies
* Re-add legacy snap confirmation for now
* Fix circular dependency issue
* Revert change to token-util
* Fix lint
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-12-20 11:44:22 +01:00
Frederik Bolding
abe0204171
[FLASK] snaps-monorepo@0.27.1 ( #16981 )
...
* snaps-monorepo@0.27.0
* Regen LavaMoat policies
* Remove unused constructor arg
* snaps-monorepo@0.27.1
2022-12-20 11:44:05 +01:00
Olusegun Akintayo
13de51e748
Security and Privacy Settings Re-org ( #16756 )
2022-12-19 18:46:36 +01:00
Dan J Miller
22fc60a341
Show user the general contract interaction screen for token approvals, when the asset standard is undefined ( #16765 )
...
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
2022-12-19 13:38:28 -03:30
mirjanaKukic
0992dd5437
added new test for adding custom network ( #15484 )
...
add custom network and switch to network
lint fix
add custom network and not switch the network
add wait for selector
lint fix
fix
add waitforselector
fix
yarn lock
added delay
added comments
lint fix
added rpc networks in mock-e2e.js
lint fix
fix
yarn lock
alphabetic order of the array in mock-e2e
fix
lint fix
fix
removed unnecessary networks
changed blacklistedHosts
added fixture builder
changed to Arbitrum One network
2022-12-19 16:46:07 +00:00
legobeat
7bdb91c089
test/e2e: increase timeout 60s -> 80s ( #16592 )
2022-12-19 09:27:47 -06:00
legobeat
204f39ef12
ui: make settings search regex range explicit ( #16903 )
...
* ui: make settings search regex range explicit
- Addresses CodeQL advisory #31
- Removes `][^ as valid characters
* ui: settings-search: ignore leading/trailing whitespace
2022-12-17 05:28:13 +09:00
Mark Stacey
3e98758719
Rename the network controller module ( #16974 )
...
The network controller module has been renamed from `network.js` to
`network-controller.js`. All of our newer controllers have "controller"
in the module names, so this aligns better with that convention. It
also brings the test module name into alignment (it's already called
"network-controller.test.js").
2022-12-16 16:37:06 -03:30
Dan J Miller
ebcccdfc5e
Merge pull request #16980 from MetaMask/master-sync
...
Master sync v10.23.1
2022-12-16 16:30:31 -03:30
Dan J Miller
074c2934fe
remove warning on revoke approval for all nfts ( #16953 )
...
Co-authored-by: EresDev <eresdev@hotmail.com>
2022-12-16 22:37:18 +05:30
Mark Stacey
dbe77289d3
Make initializeProvider and lookupNetwork async ( #16881 )
...
* Make `initializeProvider` and `lookupNetwork` async
These two methods were "synchronous" previously, but initiated an
asynchronous operation. They have both been made `async` to bring them
more in-line with the mobile controller API, and to make them easier
to test.
This should include zero functional changes. These methods are still
being invoked without an `await`, to preserve the same behaviour they
had previously.
This relates to https://github.com/MetaMask/controllers/issues/971
* Move 'net_version' query to private function
* Fix error made when resolving conflicts
* Refactor to improve readability
2022-12-16 13:03:22 -03:30
dragana8
d2f8083d64
Fix insufficient currency buy or receive error message ( #16979 )
2022-12-16 10:17:01 -06:00
Dan J Miller
ba3914e9fe
Sanitize privacy sensitive data before sending to sentry. ( #16780 )
...
* Sanitize privacy sensitive data before sending to sentry.
Temp
Near complete
Complete
* Temp
* Fix url error message rewrite
* Add unit tests and cleanup code
* Improvements
* Update app/scripts/lib/setupSentry.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Update app/scripts/lib/setupSentry.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Update app/scripts/lib/setupSentry.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Fix syntax of doc comments
* Catch errors caused by invalid urls in sanitizeUrlsFromErrorMessages
* Ensure our allowlist matches multiple subdomains
* Ensure sanitizeUrlsFromErrorMessages correctly matches hostnames
* Update app/scripts/lib/setupSentry.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Improve test descriptions
* fix
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2022-12-16 11:56:23 -03:30
Ariella Vu
462e5faab5
Fix token balance precision on confirm token approval page from soon-to-be-deprecated token allowance flow ( #16934 )
...
* ConfirmToken: fix token balance onboarding v1
this UI/UX should be deprecated following PR#16740, maybe v10.25
* TokenApproval: use precision for token balance
* EditApproval: calc utilizing existing util
2022-12-16 22:20:05 +07:00
Dan J Miller
3ab450131a
Fix the ganache:start command by making the 'yarn bin' usage compatible with yarn3 ( #16983 )
2022-12-16 11:43:06 -03:30
seaona
6cebc854fd
Merge branch 'develop' into master-sync
2022-12-16 13:05:36 +01:00
Dan J Miller
34f83a8435
Merge pull request #16975 from MetaMask/Version-v10.23.1
...
Version v10.23.1
2022-12-15 20:20:26 -03:30
George Marshall
09d29ef00d
Renaming broken stories to clean up console ( #16905 )
...
* Renaming broken stories. Fixing deprecated default arg syntax for stories using defaultValue
* Fixing imports
2022-12-15 14:46:30 -08:00
legobeat
1acb1b2e5d
Refactor password validation ( #16902 )
...
* ui: add common constant PASSWORD_MIN_LENGTH=8
* ui: simplify password validation logic
* ui: getPasswordStrengthLabel using t from context
Co-authored-by: Alex Donesky <adonesky@gmail.com>
2022-12-15 20:56:27 +00:00
seaona
9d6ab1bcb2
Fix lint by removing un-used variable getAccountsWithLabels
2022-12-15 20:20:58 +01:00
Garrett Bear
4ba081a096
add text directions ( #16901 )
...
* add text directions
* add text direction test
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2022-12-15 10:49:47 -08:00
seaona
56b89e7c9f
Changelog entry for hotfix
2022-12-15 19:07:27 +01:00
MetaMask Bot
bc073a771c
Version v10.23.1
2022-12-15 17:46:22 +00:00
Dan J Miller
bb562ea29c
Recipient name passed to confirm-page-container component should be u… ( #16961 )
...
* Recipient name passed to confirm-page-container component should be used if pet name exists for the to address
* Ensure recipient edit/add popup is shown for non-owned accounts
* Ensure contract name is rendered if it exists for recipient address
* Ensure that shortened address is last fallback after account, addressbook, token and ens names
2022-12-15 18:42:21 +01:00
Nidhi Kumari
88af4b3c36
Avatar Token HouseKeeping ( #16662 )
...
* Avatar Token HouseKeeping
* updated props
* fixed indentation and avatar size
* fixed lint issues
* updated sizes
* fixed alignment of avatar token halo stories
* updated story for src
* updated avatar token
* updated README
* updated Readme
2022-12-15 22:59:24 +05:30
