Bowen Sanders
c1e53b3330
Create new e2e test for bip-44 snap in test-snaps ( #14440 )
...
* created new test for bip-44 snap test
* added driver.Key.SPACE to allow sending spacebar
* made changes to final result check
* fixed expected pk result to proper value
* fixed to use npm package instead of local
* removed comment
* removed const delay - not needed (lint error)
2022-04-27 11:21:40 -07:00
Hennadii Ivtushok
72d2977e72
Warn about multiple MetaMask instances running ( #13836 )
...
* Add text warning on startup page
* Try to detect extensions with browser API
* Setup messaging between different versions of extension
* Cleanup
* Cleanup
* Simplify check for multiple instances running
* Fix a doc string + use webextension-polyfill
* Fix test
* Mock webextension-polyfill
* Mock correctly
* Catch error and show warning in both extensions
* Mock as promise
* Address comments
* Rename build ids
* Run detection code only if Chrome
* Add Firefox warnings
* Cleanup imports
* Update connection ids
* Run detection code for Firefox
* Add test
* Add missing await
* Update tests
* Cleanup
* Cleanup
* Improve testing
* Improve tests
* Log errors from sendMessage
* Cleanup
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-04-27 20:14:10 +02:00
Shane
74b5401302
Fixed API for watchAsset ( #14545 )
...
* Fixed API for watchAsset
* Fixed boolean return value for watchAsset
2022-04-27 07:47:10 -07:00
Frederik Bolding
27ad7279cd
Rename NotificationController to AnnouncementController ( #14389 )
...
* Rename NotificationController to AnnouncementController
* Fix test
* Add test for missing NotificationController state
* Bump controllers
* Move test to correct file
* Rename config key
* Add migration 71 to list of migrations
* Fix selector after migration
2022-04-27 10:36:32 +02:00
ryanml
5568558554
Adjust package version to 10.13.0 ( #14540 )
2022-04-26 21:29:26 -10:00
Guillaume Roux
7a9662b88e
Add token standard to custom token details ( #14506 )
...
* use getTokenStandardAndDetails to get token standard
* remove console.log and fix test
* remove console.log
2022-04-26 12:08:14 -07:00
kumavis
223124a561
lavamoat@6 - update to secure package naming ( #14488 )
2022-04-26 07:36:57 -10:00
ryanml
0c49bc14d4
Fixing 'Learn more' casing on import token screen ( #14529 )
2022-04-26 10:25:07 -07:00
Brad Decker
193c22588e
call controller methods directly in send duck ( #14465 )
2022-04-26 12:07:39 -05:00
Alex Donesky
cf2c6a3164
show token approval details on confirm approve screen by default ( #14523 )
2022-04-26 10:21:52 -05:00
kumavis
37272ad923
i18n - remove unused locale strings ( #14527 )
2022-04-25 14:09:05 -10:00
Brad Decker
f567a3fe86
Do not show failed off-chain transactions details when grouped with another valid transaction of same nonce ( #14497 )
...
* fix failed off chain tx mismatch with next confirmed transaction
* dont drop failed txs when tx in confirmed
* add comment for reassigning logic
* resolve change requests
2022-04-25 14:39:34 -05:00
amerkadicE
ef6fb86f50
Update for a new Add network page ( #13866 )
2022-04-25 13:30:46 -05:00
amerkadicE
8fef9fd8df
Update display of switching current network ( #13450 )
...
Co-authored-by: Amer Kadic <amerkadic@Amers-MacBook-Pro.local>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-04-25 13:28:52 -05:00
Dan J Miller
284bab1cbc
Ensure network name in confirm page container is defined ( #14520 )
2022-04-25 15:04:44 -02:30
MetaMask Bot
f8e850bbfa
New Crowdin translations by Github Action ( #13556 )
...
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: ricky <ricky.miller@gmail.com>
2022-04-22 12:58:09 -04:00
Ariella Vu
78f4684b2a
MetaMetrics: Add EVENT.CATEGORIES const ( #14474 )
...
* MetaMetrics: add EVENT.CATEGORIES const
* MetaMetrics: add EVENT.CATEGORIES.INPAGE_PROVIDER
* MetaMetrics: add EVENT.CATEGORIES.AUTH
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 1
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 2
confirm we want to use 'Accounts' instead of 'Account'
* MetaMetrics: add EVENT.CATEGORIES.MESSAGES
* MetaMetrics: add EVENT.CATEGORIES.RETENTION const
* MetaMetrics: add EVENT.CATEGORIES.SETTINGS
* MetaMask: add missing EVENT.CATEGORIES.SNAPS
* MetaMetrics: add EVENT.CATEGORIES.WALLET const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING
& EVENT.CATEGORIES.TRANSACTIONS consts
* MetaMetrics: use EVENT.CATEGORIES
* ducks/swaps: revert slice name
* MetaMetrics: add missing EVENT.CATEGORIES.NETWORK
2022-04-22 13:09:10 -03:00
Thomas Huang
34d43e66ca
Update tx data for simpleSends and add isBestQuote to swaps data ( #14496 )
2022-04-22 00:04:37 -07:00
ricky
0fd1cea1fe
Feature/remove bitmask ( #14489 )
...
* remove bitmask
* add --fail-on-missing-exclusions
* add .iyarc
2022-04-21 17:58:57 -04:00
Ariella Vu
d0ed2c1afc
MetaMetrics: add 'number_of_nfts' user trait ( #14495 )
...
* MetaMetrics: add number_of_nfts trait
* MetaMetrics: memoize _getAllNFTAddresses
* MetaMetrics: fix lint / update JSDoc comments
* MetaMetrics: update nft trait logic
- https://github.com/MetaMask/metamask-extension/pull/14495#discussion_r855450898
* MetaMetrics: rn _getAllNFTs > _getAllNFTsFlattened
2022-04-21 18:46:12 -03:00
Alex Donesky
fbeae57247
Add testnet name as prefix for native currency of preloaded testnets ( #14454 )
...
* add testnet name as prefix for native currency of preloaded testnets
2022-04-21 14:09:41 -05:00
Elliot Winkler
c25c0432ed
Fix ESLint config around files w/ CommonJS imports ( #14380 )
...
The `parserOptions.sourceType` config option in `.eslintrc.js` is used
to distinguish files that use ESM imports vs. files that do not.
The `import` plugin, specifically the `import/ambiguous` rule behaves
differently depending on this value. If a file is marked with
`sourceType` of `"module"`, then this rule will attempt to ensure that
the file does indeed have ESM imports and/or exports; otherwise it does
nothing.
In other words, files that use CJS imports are *not* "modules" according
to this setting, and therefore should not be marked with a `sourceType`
of `"module"`. This means we do not have to turn off the
`import/ambiguous` rule, as it will no longer trip up on these types of
files.
2022-04-21 12:41:00 -06:00
Olusegun Akintayo
095cc94ed0
Add new token added event (duplicating the existing event structure) when collectible is manually added ( #14279 )
...
* Add new token added event (duplicating the existing event structure) when auto detection occurs for NFTs
Set source property to detected on the new token added event,
2022-04-21 13:29:39 -05:00
Brad Decker
8f47c19b9d
increase test coverage of nonce sorted transaction selector ( #14486 )
2022-04-21 12:33:44 -05:00
Dan J Miller
3ecc04e42d
Fix the alerts toggles in settings ( #14498 )
2022-04-21 09:48:03 -07:00
Dan J Miller
b1df04c253
Disable swaps whenever the environment is not development or testing, so that behaviour follows production for QA purposes ( #14499 )
2022-04-21 09:19:34 -07:00
PeterYinusa
f947e5721a
E2e test timeout ( #14483 )
...
* e2e test timeout threshold
* enable logging for single test
* more logging
* remove redundant step in test
2022-04-21 16:51:03 +01:00
Erik Marks
cef95f8733
Stop storing request and response objects in the permission activity log ( #14485 )
...
We currently store the JSON-RPC request and response objects in the permission activity log. The utility of doing this was always rather dubious, but never problematic. Until now.
In Flask, as the restricted methods have expanded in number, user secrets may be included on JSON-RPC message objects. This PR removes these properties from the permission activity log, and adds a migration which does the same to existing log objects. We don't interact with the log objects anywhere in our codebase, but we don't want unexpected properties to cause errors in the future should any log objects be retained.
This PR also updates relevant tests and test data. It makes a minor functional change to how a request is designated as a success or failure, but this should not change any behavior in practice.
2022-04-21 08:44:15 -07:00
Brad Decker
488d64ae8b
increase test coverage of nonce sorted transaction selector ( #14479 )
2022-04-21 09:45:31 -05:00
ricky
eb241ae68f
bump crowdin/github-action ( #14475 )
2022-04-20 15:46:53 -04:00
seaona
f32a651ad4
E2e readme docs ( #14434 )
...
* Updated README with improvements
* Fix table spacing
* remove argument from flag
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Rephrased chrome version sentence
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-04-20 13:12:07 +02:00
PeterYinusa
dd0b34c050
E2e connected state ( #14444 )
...
* Update contract-interactions.spec.js
* Update failing-contract.spec.js
* Update send-eth.spec.js
* Update navigate-transactions.spec.js
2022-04-20 09:37:34 +01:00
ryanml
fb42b48d31
Merge pull request #14477 from MetaMask/master-sync
...
Sync `develop` with `master`
2022-04-19 13:50:15 -07:00
ryanml
741f623338
Merge remote-tracking branch 'origin/develop' into master-sync
2022-04-19 12:57:56 -07:00
ryanml
16bcd0c0eb
Merge pull request #14254 from MetaMask/Version-v10.13.0
...
Version v10.13.0 RC
2022-04-19 12:21:10 -07:00
ryanml
6420db3e7f
Lint fix
2022-04-19 09:51:33 -07:00
Dan J Miller
f4a00872d9
Run main, flask and beta in sequence in generate-lavamoat-policies.sh ( #14470 )
2022-04-19 13:38:51 -02:30
David Walsh
6a06374784
Dark Mode: Implement Metrics ( #14455 )
2022-04-19 13:38:44 -02:30
PeterYinusa
273c1dedb7
Docs - segment metrics ( #14435 )
...
* expand docs for metrics
* link to docs
* link to docs
* remove obsolete docs
* fix broken link
2022-04-19 16:15:41 +01:00
Hassan Malik
308c6e4fe3
Add snaps view search ( #14419 )
...
* add snaps view search
* add snaps view search
* fix to add in settings constants
* removed spread
* remove unused import
* add fencing
* more fencing
* ternary refactor, updated settings tests
* refactor
2022-04-19 11:08:09 -04:00
Dan J Miller
073a6e0613
Run main, flask and beta in sequence in generate-lavamoat-policies.sh ( #14470 )
2022-04-19 11:13:47 -02:30
David Walsh
458d4c55d4
Dark Mode: Fix colors in toggle button ( #14280 )
2022-04-19 08:46:01 -02:30
VSaric
e702da2194
Modify import SRP page ( #14425 )
...
* Modify Import SRP page
2022-04-18 15:12:16 -05:00
David Walsh
bcdd52f55a
Dark Mode: Implement Metrics ( #14455 )
2022-04-18 11:31:44 -05:00
filipsekulic
52b043c4f2
HoldToRevealButton component ( #13785 )
...
* Created 'HoldToRevealButton' component
* Added new line within the .svg files
* Lint fix
* CSS fix according to BEM
* Modified unit test
2022-04-18 09:32:16 -02:30
Alex Donesky
40095cce67
e2e test import json file as import account strategy ( #14449 )
2022-04-15 11:35:25 -05:00
Ariella Vu
21e54f4717
MetaMetrics: Identify 'number_of_tokens' user trait ( #14427 )
...
* MetaMetrics: identify number_of_tokens
* MetaMetrics: update number_of_tokens
do not filter by unique addresses.
Each token contract x chain id combo is a unique contract
* MetaMetrics: update MetaMetricsTraits @typedef
- add number_of_tokens
* MetaMetrics: clean up number_of_tokens
* MetaMetrics: alphabetize in test
2022-04-15 13:35:07 -03:00
Ariella Vu
e7bb8e2663
MetaMetrics: Identify 'nft_autodetection_enabled' & 'opensea_api_enabled' ( #14367 )
...
* MetaMetrics: alphabetize traits
* MetaMetrics: identify nft_autodetection_enabled
* MetaMetrics: identify opensea_api_enabled
* metametrics.test: alphabetize traits
* metametrics.test: add new traits
- nft_autodetection_enabled
- opensea_api_enabled
* MetaMetrics: @property use string literals
* MetaMetrics.test: update with openSeaEnabled & useCollectibleDetection
* MetaMetrics: alphabetize
* MetaMetrics: update MetaMetricsTraits @typedef
- add nft_autodetection_enabled
- add opensea_api_enabled
2022-04-15 10:39:55 -03:00
Daniel
eed6ae2b8c
Swaps: Sort "token_from" dropdown tokens by their fiat value first and "token_to" by top tokens ( #14436 )
2022-04-15 14:57:58 +02:00
Guillaume Roux
9950d3ffe3
Dark Mode : Fix connected account permission icon color ( #14406 )
2022-04-14 15:38:38 -07:00
