1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 02:10:12 +01:00
Commit Graph

16221 Commits

Author SHA1 Message Date
Pedro Figueiredo
26f6ae4c7c
Add testing documentation (#17411)
* Add testing documentation

* Implement diff filtering by regex

* change to relative import
2023-02-09 17:08:48 +00:00
ryanml
61ff47d71e
Merge branch 'develop' into master-sync 2023-02-09 10:07:39 -07:00
Olusegun Akintayo
6b64572f8d
Fix for error during sending to multisig address (#17651) 2023-02-09 10:49:39 -06:00
David Walsh
10be6fcfeb
UX: Update block explorer icon (#17562)
* UX: Update block explorer icon

* Removing unneeded CSS and some HTML bloat

* Removing unneeded className

* Removing unneeded CSS and reducing HTML bloat for ContractTokenValues

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-02-09 10:21:51 -06:00
ryanml
607b3d67e9
Merge branch 'develop' into master-sync 2023-02-09 04:45:39 -07:00
EresDev
58cd3deed5
fix test of useTransactionDisplayData for different timezone (#17063)
Co-authored-by: ryanml <ryanlanese@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Fixes https://github.com/MetaMask/metamask-extension/issues/17062
2023-02-08 17:13:39 -06:00
Jyoti Puri
61a7850afc
Sanitising string on signature request pages (#17571) 2023-02-09 04:35:52 +05:30
ryanml
c62e825f00 Conflict cleanup 10.25.0 master-sync 2023-02-08 13:54:51 -07:00
ryanml
e159c7987b Merge remote-tracking branch 'origin/develop' into master-sync 2023-02-08 13:51:09 -07:00
Dan J Miller
d52ef73514
Merge pull request #17323 from MetaMask/Version-v10.25.0
Version v10.25.0
2023-02-08 12:31:44 -08:00
Elliot Winkler
7e97ff2be4
Expand network controller unit test coverage (#17498)
The network controller has some tests, but they are incomplete and don't
follow our latest best practices for writing unit tests.

This commit greatly increases the amount of test coverage for the API
that we want to retain in NetworkController, in particular the seemingly
myriad paths that the code takes starting from `initializeProvider`,
`resetConnection`, `setRpcTarget`, `setProviderType`,
`rollbackToPreviousProvider`, and `lookupNetwork`.

There were a couple of pieces of logic I noted which don't seem to have
any effect due to being redundant or unreachable, but they also don't
make our lives more difficult, either, so I opted to leave them in.

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Zachary Belford <belfordz66@gmail.com>
2023-02-08 13:10:04 -07:00
Sam Gbafa
53205b6bff
Detect and track UI customizations on Personal Sign Requests (#16222)
* detect and track ui customizations on personal sign requests

* add feature flag check to metrics

* clean up comments

* get data only if it exists

* updated with PR feedback

* moved constants

* lint

* Apply suggestions from code review

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

---------

Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-08 22:16:17 +07:00
Sam Gbafa
3233f76041
Sign-in with Ethereum Domain Binding (#16616)
* message error exploration

* validate siwe domain

* remove log

* added addUnapprovedMessage siwe tests

* updated error message + test

* improve detection test with counter-example

* fix test with mock

* added rejects
2023-02-08 22:06:01 +07:00
Mark Stacey
1d0522fd88
Update json-rpc-middleware-stream from v2 to v4 (#17588)
This package has been updated to reduce the bundle size (we already use
the v4 version indirectly). The only breaking change applicable to the
usage of this package in the extension is to the package's exports. The
one import line has been updated accordingly.

This update comes with types (v3 was the TypeScript migration).
2023-02-08 11:15:00 -03:30
Nidhi Kumari
3be1fc6d0c
converted collectibles files to nfts (#17658)
* converted collectibles files to nfts

* updated relative import for scss

* updated scss for pages
2023-02-08 20:04:56 +05:30
Peter
523c90ade9
E2e test insights (#17535) 2023-02-08 08:34:44 -06:00
Elliot Winkler
75f2951f89
[TS dashboard] Reorganize files slightly (#17335) 2023-02-08 08:33:03 -06:00
Brad Decker
4cb2e573e5
add brad-decker as codeowner of .circle/ folder (#17648) 2023-02-08 08:29:15 -06:00
Maarten Zuidhoorn
ff85b040cb
Sort permissions based on weight (#17660) 2023-02-08 15:28:48 +01:00
Ariella Vu
b5c1de900d
Refactor ConfirmTransaction to Functional Component (#17473)
* ConfirmTransaction: rm unused metricEvent context

* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id

* ConfirmTransaction: convert to FC

* ConfirmTransaction: use const ORIGIN_METAMASK

* ConfirmTransaction: rm mapStateToProps

* ConfirmTransaction: mv confirm-transaction ducks

* ConfirmTransaction: mv getContractMethodData duck

* ConfirmTransaction: rm container file

* ConfirmTransaction: use ORIGIN_METAMASK const

* ConfirmationTransaction: add tests

* ConfirmTransaction: update jest mock after merge

* tests: update snapshot after mock-state updates
2023-02-08 18:00:25 +07:00
Matthew Walsh
92367dff79
Add desktop build type (#17592)
Implement build type inheritance.
Add CircleCI jobs for desktop build type.
2023-02-08 09:24:01 +00:00
Garrett Bear
661b5926ed
add double arrow icons (#17654) 2023-02-08 13:10:07 +05:30
chloeYue
82983694fe
Add e2e test: send nft (#17638)
* add e2e test send nft
2023-02-07 23:34:04 +01:00
George Marshall
b55f955243
Adding docs for layout and spacing for Icon component (#17612)
* Adding docs for layout and spacing for Icon component

* Adding close bracket
2023-02-07 10:07:50 -08:00
Thomas Huang
14efbf1eea
Collectible Unit Tests (#17632)
* Add ipfs gateway and collectible state to mock-state.json

* Add collectible-default-image test with snapshot and testids

* Add Collectible Details test, snapshot, and test-ids

* Add Collectible Options tests and test-ids

* Add Collectible Items test and test-ids.

* Add more tests to Add Collectible component

* Update Security Tab snapshot with ipfs gateway state value

* Add data-testid to Menu component for menu background

* Lint

* Bump coverage targets

* Remove commented import

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-02-07 12:06:37 -06:00
PeterYinusa
4a2d7a7a2b Reduce coverage targets
Updated in https://github.com/MetaMask/metamask-extension/pull/17325

Co-Authored-By: Brad Decker <bhdecker84@gmail.com>
2023-02-07 17:39:19 +00:00
Garrett Bear
fd53de6af5
Update BannerAlert component (#17586)
* update button alert component

* update test

* rename Banner to BannerAlert

* remove old banner snapshot

* fix banner alert border left
2023-02-07 09:32:35 -08:00
ryanml
0989678f03 Fixing yarn version command, adding yarn version plugin (#17325)
* Removing invalid flags for yarn version command

* Adding yarn version plugin

* remove .yarn from coverage

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-02-07 17:28:09 +00:00
PeterYinusa
26aa9f3ecb Fixing yarn version command, adding yarn version plugin (#17325)
* Removing invalid flags for yarn version command

* Adding yarn version plugin

* remove .yarn from coverage

---------

Co-Authored-By: Brad Decker <bhdecker84@gmail.com>
2023-02-07 17:16:14 +00:00
ryanml
8a090c3618
Updating changelog for v10.25.0 (#17573)
* Updating changelog for v10.25.0

* Update changelog

---------

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
2023-02-07 15:11:57 +00:00
PeterYinusa
e3777319ed Reduce coverage targets
Updated in https://github.com/MetaMask/metamask-extension/pull/17326
2023-02-07 14:07:25 +00:00
PeterYinusa
b94c024a61 Resolve merge conflicts 2023-02-07 13:47:21 +00:00
seaona
8123bde5af lavamoat:auto 2023-02-07 14:40:28 +01:00
PeterYinusa
0930f8093f Resolve merge conflicts
Remove changes from https://github.com/MetaMask/metamask-extension/pull/16740 in https://github.com/MetaMask/metamask-extension/pull/17437
2023-02-07 13:36:44 +00:00
PeterYinusa
9696fbba18 Add missing dependancy
Required for https://github.com/MetaMask/metamask-extension/pull/17326/
2023-02-07 12:31:38 +00:00
seaona
19585eb558 lavamoat:auto 2023-02-07 13:30:35 +01:00
Monte Lai
31afc76f9b
fix: update ledger logo (#17616) 2023-02-07 05:10:21 +08:00
Maarten Zuidhoorn
1d5030af97
Add hardcoded list of human-readable snap derivation paths (#17627)
* Add hardcoded list of human-readable snap derivation paths

* Fix formatting

* Update policies
2023-02-06 21:49:56 +01:00
Harry
21086d953c Disable eth_sign by default, allow users to toggle it back on (#17308)
* Added translation for eth sign toggle

* Disabled the ability to call eth_sign by default. Added ability within advanced settings to renable support for eth_sign

* Add test case for eth_sign being enabled and disabled

* Modified copy

* Moved rpc method preference to its own object within store

* Complete work on moving rpc method preference into its own object within store

* Fix with prettier

* Fix lint

* Fix a unit test

* Fix test

* Renamed function and object keys to be more intuitive

* Fix e2e test

* Enabled eth_sign through preferences fixture

* Fix lint

* Fix e2e test

Wait for the notification popup to close, leaving 2 window handles the extension and the test dapp

* Fix e2e test

* Fix unit test

Enable eth_sign method

* Lint fix

---------

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-02-06 19:43:36 +00:00
Dan J Miller
9ecf5d2d4e Fix speed up of 0 max priority fee transactions (#17547)
* Fix speed up of 0 max priority fee transactions

* Update ui/hooks/gasFeeInput/useTransactionFunction.test.js

Co-authored-by: Brad Decker <bhdecker84@gmail.com>

* Use bignumber for comparison to zero

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-06 19:37:30 +00:00
Vladimir Saric
222a7dd881 Display a warning and gas fee component for token allowance and NFT flow when transaction is expected to fail (#17437)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-02-06 19:30:26 +00:00
Bowen Sanders
0ffd548ff9
[FLASK] Create E2E test for RPC endowment (#17525)
* create e2e test
2023-02-06 09:54:07 -08:00
aleksandar-mihajlovic
d63014a360
Added metric Phishing Page Displayed for phishing warning page (#17462) 2023-02-06 11:06:38 -06:00
Dan J Miller
4b18d48366 Ensure the advanced gas modal displays a zero priority fee if that is how it is set in the transaction (#17559)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-06 17:04:49 +00:00
Dan J Miller
fe0875cc17 Fix http-cache-semantics dependency vulnerability GHSA-rc47-6667-2j5j (#17563)
* Fix http-cache-semantics dependency vulnerability GHSA-rc47-6667-2j5j

* Update package.json

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* update yarn.lock

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-02-06 17:01:04 +00:00
Harry
b4ecc4c3f5
Disable eth_sign by default, allow users to toggle it back on (#17308)
* Added translation for eth sign toggle

* Disabled the ability to call eth_sign by default. Added ability within advanced settings to renable support for eth_sign

* Add test case for eth_sign being enabled and disabled

* Modified copy

* Moved rpc method preference to its own object within store

* Complete work on moving rpc method preference into its own object within store

* Fix with prettier

* Fix lint

* Fix a unit test

* Fix test

* Renamed function and object keys to be more intuitive

* Fix e2e test

* Enabled eth_sign through preferences fixture

* Fix lint

* Fix e2e test

Wait for the notification popup to close, leaving 2 window handles the extension and the test dapp

* Fix e2e test

* Fix unit test

Enable eth_sign method

* Lint fix

---------

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-02-06 13:17:50 -03:30
Harry
a2a195f2c4 🐛 Calldata validation (#17326)
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: brad-decker <bhdecker84@gmail.com>
2023-02-06 16:46:59 +00:00
Nidhi Kumari
080d72abed
updated assets and phishing controller packages (#17569)
* updated controller versions

* updated policy and lock files
2023-02-06 20:41:13 +05:30
David Walsh
02d608d20c
UX: Fix token image not displaying in asset listing (#17575) 2023-02-06 08:31:19 -06:00
David Walsh
4b8aebbd5d
Prevent lint warning in ActionableMessage (#17598) 2023-02-06 08:30:02 -06:00