1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
Commit Graph

16937 Commits

Author SHA1 Message Date
Ariella Vu
ab4ef4f744
[Bug]: Updating and Adding ConfirmPageContainer Tests (#19149)
* updating the tokenBalance fetch and Token standard type to enable the Total in setSetApproveForAllWarning

* updating the base-10 for the BN.toString() conversion

* updating review comments

* adding string conversion to tokenBalance

* ConfirmPageContainer: mv props to the top

* ConfirmPageContainer: deprecate sinon

* updating coverage-targets

* updating the conversion base

* ConfirmPageContainer: add test for warning modal

---------

Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
2023-05-19 01:22:43 +03:00
Dan J Miller
6a79847d81
Merge pull request #19199 from MetaMask/master-sync
Master sync (following v10.30.2, v10.30.3 and v10.30.4)
2023-05-18 15:38:24 -02:30
Ariella Vu
813ad984ce
Fix contract interaction recipient and contract address (#18855) 2023-05-18 18:19:40 +01:00
Bowen Sanders
52109a1829
[FLASK] Create E2E test for ethereum_provider endowment (#19191) 2023-05-18 08:34:24 -07:00
Niranjana Binoy
56440a84db
Cleanup PR: Renaming getNetworkName and moving that to utils file (#19160) 2023-05-18 09:53:11 -04:00
Niranjana Binoy
3fe5d3fc4c
[Bug]: Enabling the display of token total in SetApprovalForAll (#18863) 2023-05-18 09:51:38 -04:00
Andrew Peters
67614593a8
Disable Previous Button on First Page (#17610)
* disable prev page button

* test added

* test fixes

* tests fixed

* test fix

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Mike B <32695229+plasmacorral@users.noreply.github.com>
2023-05-18 09:24:04 -04:00
Dan J Miller
5ca0cd446a Merge remote-tracking branch 'origin/develop' into master-sync 2023-05-18 10:49:28 -02:30
Pedro Figueiredo
45c833d890
disable pr labeler (#19185) 2023-05-18 14:03:39 +01:00
legobeat
8675c7863e
devDeps: storybook@7 (#19092)
* devDeps: pin @babel/core and @babel/runtime in resulotions
    Without this: misses patch, lavamoat error


* storybook 6 to 7 migration
* devDeps: add @storybook/addon-mdx-gfm
* fix lint deps
* devDeps: remove unused require-from-string
* devDeps/resolutions: @types/react@^16.9.53
* devDeps: add @storybook/cli
* storybook: new-frameworks migration
* iyarc: remove resolved dependency advisory
* deps: set globalthis@1.0.1 in resolutions
   This is required since a file is copied over from a set path in the dist
   package subdirectory as of d13aabde23 (#10014).
   A future update should either vendor the shim, or update to
   compatibility with a maintained upstream version.

* mdx2 migration fixes
* chore: bump ljharb packages
* devDeps: @storybook/*@^7.0.10->^7.0.11
* storybook: update preview.js to use v7 addon api
* ci/test/storybook: echo between storybook build&test
* ci/circleci: resources tweak
* info-tab: handle undefined global.platform
* update lavamoat build policy
* update lavamoat browserify policies
2023-05-18 11:07:42 +09:00
Nazrul Hassan
9ef9327507
Adding design-system enums and deprecating consts (#19133)
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-05-17 17:44:51 -05:00
David Walsh
577e4cba0b
UX: Multichain: Don't filter out custom mainnet RPCs (#19150) 2023-05-17 12:26:15 -05:00
David Walsh
556d3d82cc
UX: Multichain: Fix prop error from invalid Box prop (#19188) 2023-05-17 12:25:41 -05:00
David Walsh
724c69ea7c
UX: Multichain: Ensure percentage of account name always shown (#18976)
* UX: Multichain: Ensure percentage of account name always shown

* Remove extra spacing between value and menu, use proposed widths

* Setup widths via storybook and props

* Remove spacing between avatar and asset value

* WIP: Setup customization for Sara, update hard-coded font sizes

* Implement final widths

* Cleanup CSS
2023-05-17 11:53:54 -05:00
legobeat
0e2d641813
test: sanitize url hostname check (#19053) 2023-05-18 00:09:20 +09:00
Albert Olivé
ebc887021e
[MMI] Added code fences for account menu (#17965)
* Added code fences for account menu

* updates test and messages json

* clean up

* icons

* icons color correct

* icon size fix

* icon size fix

* adds mmi entries and updates to the new IconName

* clean up

* lint

* clean up

* prettier

* prettier

* camel case

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-17 16:58:00 +02:00
Albert Olivé
804d352d58
[MMI] Add MMI modals with their styles to the app/modals (#18621)
* Added code fences

* Fixing code fences

* Fixed paths

* Fixing issues

* Fixed imports

* removes fences in scss file and un-needed prop

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-17 16:57:46 +02:00
António Regadas
a265d25368
replaces mmi for institutional (#19182) 2023-05-17 10:45:34 +01:00
Nidhi Kumari
ac6fb3bb09
UX Multichain: updated assets to tokens in home page (#19144)
* updated assets to tokens in home page

* lint fix

* lint fix

* updated tests and spec files

* lint fix
2023-05-17 08:30:47 +05:30
George Marshall
e3eec3a43d
Fixes clear button size TextFieldSearch (#19153)
* Fixing broken prop

* Adding translations and hopefully fixing the display of the native search icon on mobile
2023-05-16 13:15:13 -07:00
Daniel
471889e5bb
Enable token detection for the Aurora network, fix primary token for Aurora, update a URL (#19009) 2023-05-16 17:57:04 +02:00
Albert Olivé
a017a1bae0
[MMI] Added note to trader code fencing (#18051)
* Added note to trader code fencing

* Started adding code fences in signature-request

* Finished code fencing

* Improving code

* adds check and runs prettier

* Fixed storybook and code fences bundle

* Added missing dependency

* updates fences

* fewer lines

* undo previously merged PR

* ran lavamoat auto

* adds test

* prettier

---------

Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-16 16:44:08 +01:00
António Regadas
b982bea130
[MMI] adds wrong network notification (#19168)
* adds component and test

* adds correct icon and story file

* lint

* typo fix
2023-05-16 16:59:42 +02:00
Dan J Miller
aa555b2943
Merge pull request #19164 from MetaMask/Version-v10.30.4
Version v10.30.4 RC
2023-05-16 09:22:36 -02:30
Mark Stacey
7ed2e5be69 Update changelog 2023-05-15 23:18:45 -02:30
Vinicius Stevam
ebc6f4d0aa Fix fail to reject multiple approval requests (#19050) 2023-05-15 23:15:58 -02:30
MetaMask Bot
1f5ab1e714 Version v10.30.4 2023-05-16 01:45:21 +00:00
Dhruv
488f212d28
Part of #18714 and #17670:set-approval-for-all-warnings (#19115)
* Changes to set-approval-for-all-warnings

* Suggested changes

* Updating deprecated components, improving semantic html and fixing text css strong tag styles

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-05-15 15:40:00 -07:00
Dan J Miller
42197a35d9
Merge pull request #19159 from MetaMask/Version-v10.30.3
Version v10.30.3 RC
2023-05-15 19:58:28 -02:30
Mark Stacey
f74befc8ba Add unit test coverage for lookupNetwork
The changes to network ID validation are now covered by unit tests.
Test cases for the invalid network ID case have been added as well,
since that is covered on `develop` but not here.
2023-05-15 19:27:00 -02:30
Mark Stacey
05715dd981
Support hex and number net_version responses (#19156)
Hex and number responses from the `net_version` request are now
accepted. While most chains return decimal strings for this request,
some chains were returning hex responses instead and failing our
validation for this request (which was added in v10.30.0). This
resolves that problem.

Support for number responses was added because it likely worked in
older versions as well, so support is maintained to avoid similar
problems.

Fixes #19151
2023-05-15 18:56:22 -02:30
Mark Stacey
a98b40089b Update the changelog 2023-05-15 18:44:27 -02:30
Mark Stacey
77ef06ac57 Support hex and number net_version responses
Hex and number responses from the `net_version` request are now
accepted. While most chains return decimal strings for this request,
some chains were returning hex responses instead and failing our
validation for this request (which was added in v10.30.0). This
resolves that problem.

Support for number responses was added because it likely worked in
older versions as well, so support is maintained to avoid similar
problems.

Fixes #19151
2023-05-15 18:42:38 -02:30
Mark Stacey
4bd74c5059
Fix lint error (#19157)
Fix a lint error recently introduced by a merge conflict.
2023-05-15 18:37:20 -02:30
MetaMask Bot
2897607288 Version v10.30.3 2023-05-15 21:04:04 +00:00
Dhruv
5135b80de7
Part of #18714 and #17670: Changes to nfts-detection-notice.js (#19051)
* Changes to nfts-detection-notice.js

* Adding story

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-05-15 11:08:48 -07:00
Dhruv
c9f420234f
Changes to gas-items-details (#19075) 2023-05-15 10:56:20 -07:00
Harsh Shukla
8a8c8fad10
Part of ##18714 Replace deprecated design system typography consts with enums in: confirm-page-container.component.js (#19065) 2023-05-15 10:50:49 -07:00
Frederik Bolding
125021e425
[FLASK] snaps-monorepo@0.33.1-flask.1 (#18913)
* snaps-monorepo@0.33.0-flask.1

* Add browser-passworder

* Patch babel/core

* Fix PermissionController messenger allowlist

* Update test-snaps

* Use latest patch

* Update LavaMoat policies

* Re-enable RPC E2E

* Make snaps iframe URL be a env variable and bump it

* Add new env variable to test env

* Add iframe URL to desktop build
2023-05-15 19:36:24 +02:00
Harsh Shukla
1c346674df
Part of #18714 Replace deprecated design system typography consts with enums in: 'srp-input' (#19040)
* Part of #18714 Replace deprecated design system typography consts with enums in:  'srp-input'

* Update ui/components/app/srp-input/srp-input.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update srp-input.js

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-05-15 09:52:02 -07:00
Mark Stacey
e29faca3a6
Refactor lookupNetwork unit tests (#19070)
The `lookupNetwork` unit tests have been updated to expand test
coverage and match the unit tests for the core network controller. A
helper function `lookupNetworkTests` has been copied from core. It
covers most of the behavior of the function. Vidation tests and
functional tests not covered in core have been retained, but any tests
that are now redundant have been deleted.

Relates to #1197
2023-05-15 13:34:34 -02:30
David Walsh
e5fdb72acc
UX: Multichain: Improve networks selector (#19083)
* UX: Multichain: Improve networks selector

* Update ui/selectors/selectors.js

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

* Update ui/selectors/selectors.js

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

* Update ui/selectors/selectors.js

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

* Improvements

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-15 10:15:39 -05:00
Albert Olivé
f95320d03e
[MMI] Started adding styles imports with code fences (#17943)
* Started adding styles imports with code fences

* FIxed prettier issues

* removed fences since they dont do anything

* Update ui/components/ui/ui-components.scss

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-05-15 12:38:54 +01:00
Dan Finlay
5b5e5d222f
Skip injection on snaps iframe (#19096)
* skip injection on snaps iframe

* escape periods from regex block list

These values are used as regex inputs, so plain periods are wild characters, and mean these can be interpreted as more domains than intended.

* remove period escaping

It's already escaped below. Whoops! Bad AI advice!
2023-05-15 11:39:48 +02:00
MetaMask Bot
33fd7876ff
Version v10.30.2 RC (#19109)
* Version v10.30.2

* Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0 (#19102)

* Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0

* Clean up code

* Update ui/components/app/gas-details-item/gas-details-item.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Backport the `@metamask/message-manager` update to v5 (#19110)

The `@metamask/message-manager` update to v5 has been backported to the
v10.30.x release branch. This update includes three breaking changes,
but two (bump in minimum supported Node.js version, and change in type
from `Map` to `Record`) don't affect this project. The only breaking
change requiring changes was the addition of the `getCurrentChainId`
constructor parameter for the TypedMessageManger.

* Update changelog

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-05-12 16:49:37 -02:30
Ariella Vu
aa9ee8af6c
Update useDraftTransactionGasValues (#19105)
* useDraftTransactionGasValues: update return value

* rn useDraftTransactionGasValues
-> useDraftTransactionWithTxParams
2023-05-12 13:27:25 -05:00
Dan J Miller
578f73b2ea
Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0 (#19102)
* Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0

* Clean up code

* Update ui/components/app/gas-details-item/gas-details-item.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-05-12 12:31:15 -02:30
Bowen Sanders
be8d832426
[FLASK] Create E2E test for snap_GetEntropy (#18998) 2023-05-11 12:43:08 -07:00
OGPoyraz
d859181029
fix: use approvals selector fn in permission selectors (#19095) 2023-05-11 16:40:51 +02:00
OGPoyraz
37a2be0fbb
Add getCurrentChainId argument to SignatureController (#19078) 2023-05-11 10:22:42 +02:00