Thomas Huang
928bd1c5bb
Import srp onboarding unit tests ( #18255 )
2023-04-20 09:06:36 -07:00
Thomas Huang
735076b584
Add Network Modal onboarding tests ( #18258 )
2023-04-20 07:00:27 -07:00
Thomas Huang
9b724d1032
Create New Vault test improvements ( #18259 )
...
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-04-20 06:36:03 -07:00
George Marshall
e96c0b6963
Update to component-library readme ( #18501 )
...
* Update to component-library readme
* Update ui/components/component-library/README.md
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 19:30:29 -07:00
Mark Stacey
8e52ed3fac
Make upsertNetworkConfiguration async ( #18606 )
...
The network controller method `upsertNetworkConfiguration` has been
made async. It makes one async call internally, which is the optional
step of setting the given network as the active network.
If the `setActive` option is set to `true`, this function will not
resolve until after the network switch has completed. If the
`setActive` option is `false`, this change will not have any functional
impact.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-19 20:24:50 -02:30
Monte Lai
fa6e26744d
18566 firefox ledger u2f message ( #18570 )
...
* check for user agent
* fix regex
* fix lint
* update link
* add test
* update message
* update coverage
* fix test names
* update text
* add whats new notification for firefox and ledger users
* update action button link
* update notification text
* update viewed notification
* update coverage
* update coverage
2023-04-19 19:23:07 -02:30
Garrett Bear
34c1e5a2a1
Fix/18492/update icon ts app folder ( #18645 )
2023-04-19 14:16:49 -07:00
Dan J Miller
7ca9383785
Fix swaps controller: update provider after networkIdStore state update ( #18670 )
...
* Fix swaps controller: update provider after networkIdStore state update
* Listen for changes on networkController.store, instead of networkController.networkIdStore, in the swaps controller
* Fix unit tests
2023-04-19 18:15:26 -02:30
Dan J Miller
5bb87978ac
Merge pull request #18656 from MetaMask/master-sync
...
Master sync following v10.28.2 and v10.28.3
2023-04-19 16:49:37 -02:30
Guillaume Roux
21e07ae6ba
use history.replace() instead of history.push() ( #18663 )
2023-04-19 20:38:27 +02:00
Garrett Bear
4e1a96b4ef
Feat/18308/ds popover header component ( #18489 )
...
* add popover component
popperjs init
popperjs hook init
popper arrow styles
fix popover story
add popover positions constant
story testing
popover structure
popper placement
make forwardref
fix popover with TS updates
modifiers
createPortal
add useClickAway hook
newer popover component build
simplifed popperjs with toggle to show/hide
toggle popover
modal version
popover progress 65%
add hover functionality
hide folder
storybook demo
add close button props
working popover with arrow
title prop breaking
popover TS conversion
TS updates
update test
add test
add arrow test
add stories
remove unused hook
fix docs
add popoverheader
types fix
Fix typo: detetcted-tokens-link -> detected-tokens-link (#18408 )
Typography to text (#18382 )
* Typography to text
* Update README.md
* Update README.md
* minor changes in custom file
* minor change
* Resolved Conflict issues
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
fix: Pass correct optimism chain id to gas estimation (#18478 )
removes unnecessary images (#18484 )
Fix firsttimeloaded logic (#18344 )
* use session storage, instead of chrome.runtime.onStartup and globalThis, for firstTimeLoaded architecture
* Ensure account tracker accounts remain defined upon service worker restart
* lint fix
* Simplify code
* Only call browser.storage.session in mv3
* Only call browser.storage.session.set after resetStates in mv3
* fix metamask controller reset states unit tests
* fix test
* fix test
* Actually fix tests
* lint fix
[FLASK] More Snaps E2E Optimization and Delay Reductions (#18245 )
* bip32 delay reduction
* asserts changed to waitFors in 32/44
* scrollTo change
* replaced delay for firefox flake
* more reduced delays
* more delay reductions and changes
* raise paralellism to 4 for snaps tests
* additional delay changes
* fixed update code
* removed comment
* removed another comment
Fix switch-ethereum-chain handler by passing configuration id to setA… (#18483 )
* Fix switch-ethereum-chain handler by passing configuration id to setActiveNetwork
* fix e2e test
* Fix e2e tests
* Update test/e2e/tests/switch-custom-network.spec.js
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
* Revert "Update test/e2e/tests/switch-custom-network.spec.js"
This reverts commit be533ff7f25e1fd42e951d9b817b8438035ae256.
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Bumping notification id's to 18 & 19 (#18460 )
* Popover header update with TS ButtonIcon
* update PopoverHeader types
* update using new Text enums
* readme fix
* direct file import
* remove forwardRef and add action argtypes
* remove console.logs
* add arg types and fix TS on HeaderBase
* george nits
* popover header snapshot update
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 10:36:01 -07:00
Danica Shen
1e5f481a51
fix(18574): fix new BigNumber() not a number: undefined for setApprovalForAll method ( #18660 )
2023-04-19 19:20:18 +02:00
Mark Stacey
ac64cc9e38
Fix Sentry console logs ( #18539 )
...
Sentry console logs were failing with the error "Error: TypeError:
Cannot read properties of undefined (reading 'log')". This error has
been fixed; now Sentry can log errors to the console.
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 14:27:02 -02:30
Nidhi Kumari
cb6223b75f
removed portfolio icon from eth overview ( #18662 )
2023-04-19 22:22:53 +05:30
Dan J Miller
53faf7966c
Merge remote-tracking branch 'origin/develop' into master-sync
2023-04-19 13:44:02 -02:30
Elliot Winkler
a876eaba23
removeNetworkConfiguration validates given ID ( #18650 )
...
In the `core` version of NetworkController, `removeNetworkConfiguration`
throws an error if the given network configuration ID doesn't match an
existing network configuration. This commits adds the same check for
consistency. It also makes some minor changes to the implementation and
tests for `removeNetworkConfiguration` for consistency as well.
2023-04-19 09:47:33 -06:00
Nidhi Kumari
d362dbfacb
UX Multichain: updated ethereum logo icon ( #18528 )
...
* updated ethereum logo icon
* Updating eth logo (#18631 )
* Updating eth logo
* Removing border from eth logo identicon
* Removing old eth logo
* updated snapshot and lint errors
* updated eth logo from svg to png
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-04-19 20:55:19 +05:30
Peter
02e8e9c679
Avoid resetting the mock server ( #18661 )
2023-04-19 15:36:23 +01:00
Dan J Miller
7bc13e90f8
Rename migration 83 to 84 and rename migration 84 to 83 ( #18655 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 11:38:16 -02:30
Peter
1cc709af41
wait for gas estimate to update ( #18658 )
2023-04-19 13:36:24 +01:00
sumit shinde ( Roni )
52e91058a0
knob to control ( #18635 )
...
* knob to control
* Update confirm-add-suggested-token.stories.js
* fix eslint
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update confirm-add-suggested-token.stories.js
* updaes
* Updating to use redux provider
* lint fix
---------
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-04-19 14:33:29 +05:30
Jyoti Puri
5892acab81
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-18 20:53:45 -02:30
Dan J Miller
39f6042e65
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-18 17:19:49 -02:30
Jyoti Puri
599bef9dc5
Adding documentation for confirmation code cleanup ( #17975 )
2023-04-18 22:31:45 +05:30
Garrett Bear
13f4295287
update Icon to TS version in UI Folder ( #18551 )
...
* update Icon to TS version and using proper Enums
* Update ui/components/ui/menu/menu.stories.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Update ui/components/ui/nickname-popover/nickname-popover.component.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-18 09:48:34 -07:00
Brad Decker
7fa7c05586
use network did change instead of state update for assetsContractController ( #18629 )
2023-04-18 14:03:12 -02:30
Mark Stacey
1fe28ee15a
Make setActiveNetwork async ( #18605 )
...
The network controller method `setActiveNetwork` is now async, and the
asynchronous `_setProviderConfig` step is now awaited. The function
will not resolve until the network has finished switching.
This change affects the `eth_switchEthereumChain` and
`eth_addEthereumChain` middleware, and it affects any network switching
performed in our UI.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-18 13:25:05 -02:30
Jyoti Puri
c6aa4f38c5
Fix approve all warning modal ( #18613 )
...
* Fix approve all warning modal
* fix
* fix
* fix
2023-04-18 13:22:16 -02:30
Niranjana Binoy
9d3cdd1b79
Overriding gas estimate in the send page even if enough ETH is not available ( #18554 )
2023-04-18 11:10:32 -04:00
Dan J Miller
e6f73f5fe9
Pass correct params to fetchEstimatedL1Fee in the swaps controller ( #18634 )
2023-04-18 12:15:18 -02:30
Danica Shen
66767d981c
fix/18577: Add title back for approving ERC20 token ( #18617 )
...
* fix/18577: Add title back for approving ERC20 token
* Apply suggestions from code review
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-18 15:49:31 +02:00
Guillaume Roux
76d79d9cce
[FLASK] Redesign dropdown-tab ( #18546 )
2023-04-18 12:46:38 +02:00
Vinicius Stevam
ae0af1b283
Adopt security provider request from core ( #18520 )
2023-04-18 08:33:32 +01:00
Jyoti Puri
09d00e1e45
Refactor confirm-send-ether into functional component ( #18527 )
2023-04-18 05:59:06 +05:30
Jyoti Puri
00d2d43d45
Fix error in console on rejecting signature request ( #18614 )
2023-04-18 05:58:28 +05:30
Mark Stacey
e5835ac459
Make resetConnection async ( #18601 )
...
The network controller method `resetConnection` is now async. This has
no functional impact.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-17 15:45:22 -02:30
Mark Stacey
b87c1b8526
Make setProviderType async ( #18604 )
...
The network controller method `setProviderType` is now async, and the
async operation `_setProviderConfig` called at the end of the method is
now awaited.
Because the only async operation was the last step, this should have no
impact upon the flow of execution. The only functional change is that
now any callers have the option of waiting until the network switch
operation has completed.
One such change was made, in the `switch-ethereum-chain` middleware. As
a result, an error thrown while the network is switching will now
be thrown in this middleware and returned to the dapp as an internal
error.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-17 15:45:01 -02:30
Garrett Bear
81393e1b5d
update to enum DS Text component ( #18584 )
...
* update to enum DS Text component
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
* Update ui/components/component-library/text/README.mdx
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-17 10:17:28 -07:00
Mark Stacey
39dff02a04
Consolidate network stores ( #18595 )
...
* Consolidate network stores
The network controller used to have multiple different state stores,
which were composed together to form the main controller state store.
They have been consolidated into a single store. This required few
changes because most state access was already being done through the
composed store.
Fixes https://github.com/MetaMask/metamask-extension/issues/18303
* Add JSDoc comment
2023-04-17 13:24:13 -02:30
Mark Stacey
3588e6d28e
Make network controller internal fields private ( #18607 )
...
Internal network controller methods and fields are now private fields,
using the JavaScript `#` syntax rather than the `private` TypeScript
keyword or a leading underscore.
The one reference to a private field was in the preferences controller
unit tests. Fortunately it was being used to create a test fixture that
was unused. The unnecessary test fixtures have been removed from that
test suite.
Fixes https://github.com/MetaMask/metamask-extension/issues/18588
2023-04-17 12:45:33 -02:30
Albert Olivé
c3cb464229
[MMI] Added custody-labels and account-list components ( #18197 )
...
* Added custody-labels and account-list components
* Modified link
* Renamed custody labels and improved code
* Added snapshot
* Fixed snapshot
* Finished connect-custody account-list
* Fixing css prettier
* Fixed comments of the PR
* Fixed code
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-04-17 17:06:41 +02:00
Niranjana Binoy
fedd6d4970
New reusable gas-display component ( #17976 )
2023-04-17 10:34:26 -04:00
dswilson4
ca10a1cdb6
updated onClick of close button to call the same autohide fxn as the NFT import removal ( #18504 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-17 16:13:00 +02:00
Frederik Bolding
47f4f4008b
[FLASK] Remove unused snaps code ( #18565 )
...
* Remove unused code after snap_confirm was removed
* Remove more unused code
* Fix lint
2023-04-17 12:55:08 +02:00
OGPoyraz
867d637f06
fix: add metrics event to sign controller ( #18318 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-17 11:21:33 +02:00
António Regadas
b50b9be502
[MMI] moves mmi selectors to institutional folder ( #18542 )
...
* adds the initial selectors
* adds more selectors
* adds tests
* fix lint and prettier
2023-04-17 09:22:53 +01:00
Jyoti Puri
cc71fda686
Fix issue with requests with empty data being forwarded to opensea ( #18598 )
2023-04-17 09:54:25 +05:30
Mark Stacey
73efd2edeb
Make rollbackToPreviousProvider async ( #18599 )
...
The network controller method `rollbackToPreviousProvider` is now
async. It will resolve when the network switch has completed.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-15 10:31:59 -02:30
Ariella Vu
1406885115
siwe: add ledger instructions ( #18589 )
2023-04-14 21:10:27 -03:00
Mark Stacey
e6d1b052f0
Make _setProviderConfig async ( #18600 )
...
The network controller internal method `_setProviderConfig` has been
made async, the async `_switchNetwork` operation is now `await`-ed.
Since the `_switchNetwork` call was the last operation, this has zero
functional impact.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-14 19:10:32 -02:30
