1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-12 12:47:14 +01:00
Commit Graph

16313 Commits

Author SHA1 Message Date
Mark Stacey
917290e764 Revert "Moved subscribe and filter into network controller (#16693)" (#18129)
* Revert "Moved subscribe and filter into network controller (#16693)"

This reverts commit 6f6984fa58. That
commit was an RPC middleware refactor intended to move the subscribe
and filter middleware into the network controller, to simplify the
process of sharing this middleware between clients.

This refactor resulted in `eth_subscribe` notifications being sent on
the wrong connections, causing the UI to break in some cases (the UI
`provider` connection does not support notifications). This happened
because the `setupProviderEngine` function runs per-connection,
whereas the engine setup inside the network controller is global. The
global network client cannot support notifications because it has no
way to route them; they'll need to stay in the per-connection provider
engine.

Closes #17467

* Add e2e test

An e2e test has been added that confirms subscriptions are only
broadcast to the site that registered them. This test fails on
`develop`.
2023-03-30 15:18:50 +01:00
MetaMask Bot
972e738710 Version v10.28.0 2023-03-14 15:40:26 +00:00
Peter
7215fc25a4
Move nft e2e tests to main e2e test job (#18055)
* NFTs: Remove feature flag for release

* Update security tab jest test

* Fix broken test

* Update snapshot

* Update test

* Fix test

* remove nft build

* move tests to main e2e job

* remove nft scripts

* remove test for nft build

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-03-14 15:21:24 +00:00
vthomas13
bfefa35811
Adding NFT autodetection to "What's New" Announcements (#17653)
* adding base what's new for NFT autodetection

* lintfix

* Adding nfts svg image

* adding new notification to fixture builder for e2e

* lint:fix

* Adding new messaging, styling what's new

* styling descriptions, increasing fullscreen height

* applying firstNotification styling to NFT whats new announcement

* adding scrollDown button to whats new popup

* adding Opensea announcement, removing old announcement, moving scrollDown button up to popover component

* verify-locales:fix

* updating icon
2023-03-14 11:07:58 -04:00
Peter
2e291ff9c7
Merge pull request #18141 from MetaMask/master-sync-v2
Master sync for v10.26.1
2023-03-14 14:52:17 +00:00
PeterYinusa
a796dbd705 Conflict cleanup 10.26.1 master-sync 2023-03-14 12:25:55 +00:00
PeterYinusa
7d1ce40a19 Merge remote-tracking branch 'origin/develop' into master-sync-v2 2023-03-14 12:12:06 +00:00
PeterYinusa
094c5582e6 Revert "patch lavamoat files to make v10.26.0 compatible with v78 of chrome (#18053)"
This reverts commit 8c550e78e9.
2023-03-14 12:06:48 +00:00
seaona
93be4810b9
Fix typo on test file (#18124) 2023-03-14 12:48:14 +01:00
seaona
b8ec3623ff
[e2e] ENS test improvement - with network controller fixture (#18119)
* With network controller fixture

* fix lint
2023-03-14 12:47:54 +01:00
Thomas Huang
eafffb1af5
Remove console.log of expected action from actions test (#18130) 2023-03-14 06:09:16 -05:00
António Regadas
c022d2eb9a
[MMI] Move mmi actions to extension (#18057)
* MMI adds actions and background files to the institution/ folder

* MMI lint fix

* MMI lint fix

* MMI import path fixed to be relative

* MMI import path fixed

* MMI adds the relative path to isErrorWithMessage

* MMI adds the tests for mmi actions

* MMI lint fix

* adds tests to mmi actions

* prettier fix

* MMI prettier and adds test

* MMI prettier

* MMI lint fix

* MMI prettier fix

* MMI rename folder
2023-03-14 10:57:05 +00:00
David Walsh
ada47802b3
UX: Loaclize the avatar-favicon description text (#18132) 2023-03-14 12:18:27 +05:30
Ariella Vu
f499b56d16
Convert LoadingScreen into Functional Component and use React.memo (#17935)
* LoadingScreen: transform into functional component

* LoadingScreen: remove unnecessary styles

* LoadingScreen: mv renderMessage
2023-03-13 14:48:30 -07:00
David Walsh
5b1b5dc03b
NFTs: Remove feature flag for release (#17401)
* NFTs: Remove feature flag for release

* Update security tab jest test

* Fix broken test

* Update snapshot

* Update test

* Fix test

* Remove last usages of flag

* Update CI jobs

* Fix jest tests
2023-03-13 14:29:37 -05:00
flexa-rob
e7527b65ee
17921 Update TransactionAlerts with BannerAlert (#17940)
* use banner alerts

* update selector for banner alert content

* lintage

* update button click for banner alert structure

* bump global branches coverage target

* removed unnecessary Typography usage

* remove Typography usage

* transaction alerts story

* pending transaction alerts

* created separate stories for each alert scenario
2023-03-13 12:29:10 -07:00
Suryansh Anand
a2838b0dd1
Part of 17670: Replace Typography with Text confirm-approve-content.component.js and home.component.js (#18049)
* Changed Typography to Text component in comfirm-apporve-content-component.js

* Changed Typography to Text component in home.component.js

* Changed Typography to Text component in comfirm-apporve-content-component.js

* Changed Typography to Text component in home.component.js

* Changed all h7 heading to h6 as h7 does not exist

* Fixed prettier errors on home.component.js

* Alignment fix

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-03-13 12:27:24 -07:00
David Walsh
be15200168
UX: Icon: Update buy icon (#18123) 2023-03-13 14:14:43 -05:00
Vladimir Saric
14b1555ee3
Display internet protocol on the domain in SIWE screen (#18052) 2023-03-13 21:40:43 +04:00
Peter
29674537e8
Update chromedriver v111 (#18120)
* update chromedriver to v111

* update chrome binary used in CI
2023-03-13 16:50:38 +00:00
micaelae
a69cb0284d
Wrap balance and portfolio button (#18109) 2023-03-13 10:50:12 -05:00
David Walsh
000dbb976c
Fix ThemeType casing issue (#18039) 2023-03-13 10:00:55 -05:00
Peter
0fca0e3542
Use deployed contracts in fixtures (#18107)
* substitute smart contact address in fixtures

* add smart contract fixtures

* rename fixture

* leverage fixture to import erc1155

* leverage fixture to import erc721

* fix flaky test
2023-03-13 14:31:14 +00:00
Dan J Miller
6cc7ab212e
Merge pull request #18122 from MetaMask/Version-v10.26.1
Version v10.26.1 RC
2023-03-13 06:00:02 -07:00
Dan Miller
6bc5179290 Update changelog 2023-03-13 09:33:27 -02:30
MetaMask Bot
fd480ad773 Version v10.26.1 2023-03-13 11:49:38 +00:00
João Tavares
cfced8f124 fix: do not run desktop prep build step on master (#18112) 2023-03-13 09:13:11 -02:30
João Tavares
ba93b81182
fix: do not run desktop prep build step on master (#18112) 2023-03-13 09:12:01 -02:30
George Marshall
5d5fa242c3
Updating AvatarAccount objects to enums (#17727)
* Updating object to enums

* lint fix

* Improving test coverage

* Updating filename to .types.ts
2023-03-10 12:12:55 -08:00
witmicko
fde18dec0c
link component (#17897)
Added externlalLink to ButtonLink

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-03-10 17:47:01 +00:00
Dan J Miller
140e64f108
Merge pull request #17698 from MetaMask/Version-v10.26.0
Version v10.26.0 RC
2023-03-10 07:27:12 -08:00
chloeYue
11c79dd629
Add e2e tests approval for all for erc1155 token (#18047)
add tests approval for all
2023-03-10 15:04:45 +01:00
Dan J Miller
150f0ee766 Use replace instead of replace all so that we are compatible with v78 (#18080)
* Use replace instead of replace all so that we are compatible with v78

* Add unit tests
2023-03-10 13:48:55 +00:00
Dan J Miller
3ad6cf15ae
Use replace instead of replace all so that we are compatible with v78 (#18080)
* Use replace instead of replace all so that we are compatible with v78

* Add unit tests
2023-03-10 10:06:07 -03:30
David Drazic
642ce91b70
[FLASK] Add WebAssembly endowment (#17694)
* Add WebAssembly endowment

Update message and fix lint

Update fa icon

* Remove duplicated webassembly permission from a list
2023-03-10 12:38:58 +01:00
David Walsh
d6e61e9d07
Fix #17948 - Allow editing of NFT sends (#17970) 2023-03-09 15:02:08 -06:00
Alex Donesky
23ca4460cf
Migrate network configurations (previously frequentRpcListDetail) from PreferencesController to NetworkController (#17421) 2023-03-09 15:00:28 -06:00
David Walsh
423e0854d3
Fix #17848 - Ensure NFT collections toggle appropriately (#17972) 2023-03-09 12:10:37 -06:00
Thomas Huang
766c8a3e53
Force update mock state and render nfts item test fix (#18044) 2023-03-09 22:06:12 +05:30
Alex Donesky
1121e3a848
fix network dropdown bug (#18079) 2023-03-09 10:11:38 -06:00
João Tavares
cd1a8270ab
Add github action to trigger metamask-desktop CI (#17977)
* chore: add action to trigger metamask-desktop ci

We want to be able to trigger
MetaMask Desktop CI whenever we
are releasing the Extension (in this
case, merging to master branch).
This will allow the desktop team
to easily identify whenever a breaking
change (to the extension-desktop app
pairing) is being released and address
the issue within the desktop app
in a timely manner

* use double quotes

ensure these get interpreted as single strings.

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-03-09 15:37:01 +00:00
seaona
8e9fe07648
[e2e] Check ENS resolves correctly (#18056)
* ENS resolves correctly

* Fix flaky test on firefox
2023-03-09 14:37:29 +01:00
PeterYinusa
535d55ea8b bump test coverage 2023-03-09 10:37:54 +00:00
Dan J Miller
7bc2370be5 Use tokenList to get token details, when available, in getTokenStanda… (#17891)
* Use tokenList to get token details, when available, in getTokenStandardAndDetails

Previously, every call to getTokenStandardAndDetails would fetch data via the provider.
This would result in at least 3 network requests whenever that method is called for an
ERC20 token, contributing to unneccesary loading and lagging in multiple places.
This commit takes advantage of stored data we already have available to avoid the unnecessary
loading.

* Lint fix

* Fix build-quote test

* bump coverage targets

* Pass provider to token-util, for use in ethers Contract module

* Check all possible sources of ERC20 token data before async call to assetsContractController

* Add and update tests

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Remove unnecessary this.ethQuery changes

* Use metamask-eth-abis instead of human-standard-token-abi in token-util.ts

* Add explanatory comments to getTokenStandardAndDetails

* lint fix

* Cleanup

* fix test

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* update error message

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2023-03-09 09:59:14 +00:00
Danica Shen
d4bc0a453b fix(17542): fix fiat currency display in few txn actions (#18011)
* fix(17542): fix fiat currency display in few txn actions

* fix(17542): refactor e2e tests to change to fia via fixture builder
2023-03-09 09:56:14 +00:00
Nidhi Kumari
bf06598d6e
UX Icon: Updated Icon for Disclosure (#17877)
* updated fa-add

* updated summary icon

* updated styles for disclosure

* updated margin value
2023-03-09 10:48:44 +05:30
Jyoti Puri
0ac54e40ee
Extract out confirm-data and confirm-hex-data components from confirm-transaction-base.component.js (#17822) 2023-03-09 10:38:37 +05:30
Garrett Bear
2c2505be06
add banner-tip component (#17814)
* add banner-tip component

* set fixed width

* add banner tip props to logo

* fix logo type naming

* update test

* reduce png sizes

* upate type name and add image element test

* updates

* Update ui/components/component-library/banner-tip/banner-tip.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* update BannerTip

* fix text case banner tip

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-03-08 13:27:24 -08:00
George Marshall
ed519d8b60
Updating AvatarWithBage to BadgeWrapper (#17851) 2023-03-08 13:18:55 -08:00
David Walsh
de83546d6d
Fix #17932 - Ensure NFT last sold price is formatted correctly (#17983)
* Fix #17932 - Ensure NFT last sold price is formatted correctly

* Fix storybook

* Update snapshot to include pricing
2023-03-08 14:39:12 -06:00