amerkadicE
8fef9fd8df
Update display of switching current network ( #13450 )
...
Co-authored-by: Amer Kadic <amerkadic@Amers-MacBook-Pro.local>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-04-25 13:28:52 -05:00
Dan J Miller
284bab1cbc
Ensure network name in confirm page container is defined ( #14520 )
2022-04-25 15:04:44 -02:30
MetaMask Bot
f8e850bbfa
New Crowdin translations by Github Action ( #13556 )
...
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: ricky <ricky.miller@gmail.com>
2022-04-22 12:58:09 -04:00
Ariella Vu
78f4684b2a
MetaMetrics: Add EVENT.CATEGORIES const ( #14474 )
...
* MetaMetrics: add EVENT.CATEGORIES const
* MetaMetrics: add EVENT.CATEGORIES.INPAGE_PROVIDER
* MetaMetrics: add EVENT.CATEGORIES.AUTH
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 1
* MetaMetrics: add EVENT.CATEGORIES.ACCOUNTS pt. 2
confirm we want to use 'Accounts' instead of 'Account'
* MetaMetrics: add EVENT.CATEGORIES.MESSAGES
* MetaMetrics: add EVENT.CATEGORIES.RETENTION const
* MetaMetrics: add EVENT.CATEGORIES.SETTINGS
* MetaMask: add missing EVENT.CATEGORIES.SNAPS
* MetaMetrics: add EVENT.CATEGORIES.WALLET const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING const
* MetaMetrics: add EVENT.CATEGORIES.ONBOARDING
& EVENT.CATEGORIES.TRANSACTIONS consts
* MetaMetrics: use EVENT.CATEGORIES
* ducks/swaps: revert slice name
* MetaMetrics: add missing EVENT.CATEGORIES.NETWORK
2022-04-22 13:09:10 -03:00
Thomas Huang
34d43e66ca
Update tx data for simpleSends and add isBestQuote to swaps data ( #14496 )
2022-04-22 00:04:37 -07:00
ricky
0fd1cea1fe
Feature/remove bitmask ( #14489 )
...
* remove bitmask
* add --fail-on-missing-exclusions
* add .iyarc
2022-04-21 17:58:57 -04:00
Ariella Vu
d0ed2c1afc
MetaMetrics: add 'number_of_nfts' user trait ( #14495 )
...
* MetaMetrics: add number_of_nfts trait
* MetaMetrics: memoize _getAllNFTAddresses
* MetaMetrics: fix lint / update JSDoc comments
* MetaMetrics: update nft trait logic
- https://github.com/MetaMask/metamask-extension/pull/14495#discussion_r855450898
* MetaMetrics: rn _getAllNFTs > _getAllNFTsFlattened
2022-04-21 18:46:12 -03:00
Alex Donesky
fbeae57247
Add testnet name as prefix for native currency of preloaded testnets ( #14454 )
...
* add testnet name as prefix for native currency of preloaded testnets
2022-04-21 14:09:41 -05:00
Elliot Winkler
c25c0432ed
Fix ESLint config around files w/ CommonJS imports ( #14380 )
...
The `parserOptions.sourceType` config option in `.eslintrc.js` is used
to distinguish files that use ESM imports vs. files that do not.
The `import` plugin, specifically the `import/ambiguous` rule behaves
differently depending on this value. If a file is marked with
`sourceType` of `"module"`, then this rule will attempt to ensure that
the file does indeed have ESM imports and/or exports; otherwise it does
nothing.
In other words, files that use CJS imports are *not* "modules" according
to this setting, and therefore should not be marked with a `sourceType`
of `"module"`. This means we do not have to turn off the
`import/ambiguous` rule, as it will no longer trip up on these types of
files.
2022-04-21 12:41:00 -06:00
Olusegun Akintayo
095cc94ed0
Add new token added event (duplicating the existing event structure) when collectible is manually added ( #14279 )
...
* Add new token added event (duplicating the existing event structure) when auto detection occurs for NFTs
Set source property to detected on the new token added event,
2022-04-21 13:29:39 -05:00
Brad Decker
8f47c19b9d
increase test coverage of nonce sorted transaction selector ( #14486 )
2022-04-21 12:33:44 -05:00
Dan J Miller
3ecc04e42d
Fix the alerts toggles in settings ( #14498 )
2022-04-21 09:48:03 -07:00
Dan J Miller
b1df04c253
Disable swaps whenever the environment is not development or testing, so that behaviour follows production for QA purposes ( #14499 )
2022-04-21 09:19:34 -07:00
PeterYinusa
f947e5721a
E2e test timeout ( #14483 )
...
* e2e test timeout threshold
* enable logging for single test
* more logging
* remove redundant step in test
2022-04-21 16:51:03 +01:00
Erik Marks
cef95f8733
Stop storing request and response objects in the permission activity log ( #14485 )
...
We currently store the JSON-RPC request and response objects in the permission activity log. The utility of doing this was always rather dubious, but never problematic. Until now.
In Flask, as the restricted methods have expanded in number, user secrets may be included on JSON-RPC message objects. This PR removes these properties from the permission activity log, and adds a migration which does the same to existing log objects. We don't interact with the log objects anywhere in our codebase, but we don't want unexpected properties to cause errors in the future should any log objects be retained.
This PR also updates relevant tests and test data. It makes a minor functional change to how a request is designated as a success or failure, but this should not change any behavior in practice.
2022-04-21 08:44:15 -07:00
Brad Decker
488d64ae8b
increase test coverage of nonce sorted transaction selector ( #14479 )
2022-04-21 09:45:31 -05:00
ricky
eb241ae68f
bump crowdin/github-action ( #14475 )
2022-04-20 15:46:53 -04:00
seaona
f32a651ad4
E2e readme docs ( #14434 )
...
* Updated README with improvements
* Fix table spacing
* remove argument from flag
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Rephrased chrome version sentence
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-04-20 13:12:07 +02:00
PeterYinusa
dd0b34c050
E2e connected state ( #14444 )
...
* Update contract-interactions.spec.js
* Update failing-contract.spec.js
* Update send-eth.spec.js
* Update navigate-transactions.spec.js
2022-04-20 09:37:34 +01:00
ryanml
fb42b48d31
Merge pull request #14477 from MetaMask/master-sync
...
Sync `develop` with `master`
2022-04-19 13:50:15 -07:00
ryanml
741f623338
Merge remote-tracking branch 'origin/develop' into master-sync
2022-04-19 12:57:56 -07:00
ryanml
16bcd0c0eb
Merge pull request #14254 from MetaMask/Version-v10.13.0
...
Version v10.13.0 RC
2022-04-19 12:21:10 -07:00
ryanml
6420db3e7f
Lint fix
2022-04-19 09:51:33 -07:00
Dan J Miller
f4a00872d9
Run main, flask and beta in sequence in generate-lavamoat-policies.sh ( #14470 )
2022-04-19 13:38:51 -02:30
David Walsh
6a06374784
Dark Mode: Implement Metrics ( #14455 )
2022-04-19 13:38:44 -02:30
PeterYinusa
273c1dedb7
Docs - segment metrics ( #14435 )
...
* expand docs for metrics
* link to docs
* link to docs
* remove obsolete docs
* fix broken link
2022-04-19 16:15:41 +01:00
Hassan Malik
308c6e4fe3
Add snaps view search ( #14419 )
...
* add snaps view search
* add snaps view search
* fix to add in settings constants
* removed spread
* remove unused import
* add fencing
* more fencing
* ternary refactor, updated settings tests
* refactor
2022-04-19 11:08:09 -04:00
Dan J Miller
073a6e0613
Run main, flask and beta in sequence in generate-lavamoat-policies.sh ( #14470 )
2022-04-19 11:13:47 -02:30
David Walsh
458d4c55d4
Dark Mode: Fix colors in toggle button ( #14280 )
2022-04-19 08:46:01 -02:30
VSaric
e702da2194
Modify import SRP page ( #14425 )
...
* Modify Import SRP page
2022-04-18 15:12:16 -05:00
David Walsh
bcdd52f55a
Dark Mode: Implement Metrics ( #14455 )
2022-04-18 11:31:44 -05:00
filipsekulic
52b043c4f2
HoldToRevealButton component ( #13785 )
...
* Created 'HoldToRevealButton' component
* Added new line within the .svg files
* Lint fix
* CSS fix according to BEM
* Modified unit test
2022-04-18 09:32:16 -02:30
Alex Donesky
40095cce67
e2e test import json file as import account strategy ( #14449 )
2022-04-15 11:35:25 -05:00
Ariella Vu
21e54f4717
MetaMetrics: Identify 'number_of_tokens' user trait ( #14427 )
...
* MetaMetrics: identify number_of_tokens
* MetaMetrics: update number_of_tokens
do not filter by unique addresses.
Each token contract x chain id combo is a unique contract
* MetaMetrics: update MetaMetricsTraits @typedef
- add number_of_tokens
* MetaMetrics: clean up number_of_tokens
* MetaMetrics: alphabetize in test
2022-04-15 13:35:07 -03:00
Ariella Vu
e7bb8e2663
MetaMetrics: Identify 'nft_autodetection_enabled' & 'opensea_api_enabled' ( #14367 )
...
* MetaMetrics: alphabetize traits
* MetaMetrics: identify nft_autodetection_enabled
* MetaMetrics: identify opensea_api_enabled
* metametrics.test: alphabetize traits
* metametrics.test: add new traits
- nft_autodetection_enabled
- opensea_api_enabled
* MetaMetrics: @property use string literals
* MetaMetrics.test: update with openSeaEnabled & useCollectibleDetection
* MetaMetrics: alphabetize
* MetaMetrics: update MetaMetricsTraits @typedef
- add nft_autodetection_enabled
- add opensea_api_enabled
2022-04-15 10:39:55 -03:00
Daniel
eed6ae2b8c
Swaps: Sort "token_from" dropdown tokens by their fiat value first and "token_to" by top tokens ( #14436 )
2022-04-15 14:57:58 +02:00
Guillaume Roux
9950d3ffe3
Dark Mode : Fix connected account permission icon color ( #14406 )
2022-04-14 15:38:38 -07:00
David Walsh
e4197abfae
Dark Mode: Fix QR display ( #14312 )
2022-04-14 15:38:27 -07:00
Ariella Vu
0c52723885
Update segment instantiation check. Only check if SEGMENT_WRITE_KEY exists ( #14407 )
...
* segment: instantiate w/out SEGMENT_HOST check
If SEGMENT_HOST is null, then the analytics-node library will usea defaulted host
* Segment: rm IN_TEST check for instantiation
2022-04-14 18:31:54 -03:00
Guillaume Roux
76615b7bec
Enhanced Gas Fee UI : Fix gas values overlaping with labels ( #14392 )
2022-04-14 19:30:19 +02:00
Dan J Miller
78f68b3dab
Fix speed-up/cancel: don't update existing transaction data ( #14355 )
...
* Fix speed-up/cancel: don't update existing transaction data
* Move retryTxMeta state management to useGasFeeInputs.js
* Handle initial retryTxMeta set if no transaction is passed to useGasFeeInputs
* Ensure previousGas is use on retry transaction if it is available in useGasFeeInputs
* Remove update transaction mock and correctly test gas fee increase scenarios now that updateTransaction used in cancel-speedup is defined on the front end
2022-04-14 08:53:33 -07:00
Dan J Miller
b7b041c43b
Fix speed-up/cancel: don't update existing transaction data ( #14355 )
...
* Fix speed-up/cancel: don't update existing transaction data
* Move retryTxMeta state management to useGasFeeInputs.js
* Handle initial retryTxMeta set if no transaction is passed to useGasFeeInputs
* Ensure previousGas is use on retry transaction if it is available in useGasFeeInputs
* Remove update transaction mock and correctly test gas fee increase scenarios now that updateTransaction used in cancel-speedup is defined on the front end
2022-04-14 13:20:48 -02:30
kumavis
54ac00027b
unblock ci: update vuln deps + fix npm registry for snaps firefox ( #14437 )
...
* dep-audit-fix for async@2.6.3
* deps - update async for vuln fix and remove patch
* deps/ci-yarn-audit - remove outdated ignored vulns
* deps/lock - deduplicate async@2
* deps/lock - deduplicate async@2 + remove indirectly used dep
* Use regular NPM registry for snaps on Firefox (#14439 )
* Use regular NPM registry for snaps on FF
* Fix linting
* Update app/scripts/metamask-controller.js
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
2022-04-14 08:03:13 -07:00
Daniel
9403ee9c7a
Disable Swaps on Rinkeby for production ( #14372 )
...
* Disable Swaps in Rinkeby for production
* Use arrays instead of objects for allowed chain ids
* Trigger Build
2022-04-14 17:02:38 +02:00
PeterYinusa
99461941f8
enable skipped test ( #14378 )
2022-04-14 13:33:33 +01:00
kumavis
0f4417684b
unblock ci: update vuln deps + fix npm registry for snaps firefox ( #14437 )
...
* dep-audit-fix for async@2.6.3
* deps - update async for vuln fix and remove patch
* deps/ci-yarn-audit - remove outdated ignored vulns
* deps/lock - deduplicate async@2
* deps/lock - deduplicate async@2 + remove indirectly used dep
* Use regular NPM registry for snaps on Firefox (#14439 )
* Use regular NPM registry for snaps on FF
* Fix linting
* Update app/scripts/metamask-controller.js
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: kumavis <kumavis@users.noreply.github.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Shane <jonas.shane@gmail.com>
2022-04-13 17:28:03 -10:00
Brad Decker
922ebd57cb
track address book usage ( #14382 )
...
* track address book usage
* Update app/scripts/controllers/metametrics.js
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
* Update shared/constants/metametrics.js
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2022-04-13 11:46:49 -05:00
Niranjana Binoy
455d4a9825
Update DetectTokenController for token detection V2 ( #14216 )
2022-04-13 12:23:41 -04:00
seaona
dc3f14ffbb
E2e settings search msgs ( #14386 )
...
* Improve error messages with template literals
* Lint fix
* Changed variable let for const and scope
2022-04-13 17:26:26 +02:00
Dan J Miller
432c88e185
Remove duplicate gas simulation error messages ( #14409 )
...
* Remove duplicate gas simulation error messages
* Fixing locales
* Fixing unit tests
* Fixing e2e
Co-authored-by: ryanml <ryanlanese@gmail.com>
2022-04-13 08:01:21 -07:00