1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-05 23:44:56 +01:00
Commit Graph

13858 Commits

Author SHA1 Message Date
Jyoti Puri
0c531f8b01
EIP-1559 V2 UI fixes (#13222) 2022-01-07 04:10:31 +05:30
David Walsh
10dc686505
Dark Mode Part 1: Switch to Using CSS Variables (#13147) 2022-01-06 11:35:49 -06:00
Jyoti Puri
f5dcd12293
using 1559 V2 for cancel speed up flows (#13019) 2022-01-06 08:17:26 +05:30
Erik Marks
dbfdf3b0eb
Update Flask support links and home footer (#13226)
* Update support links for Flask

* Disable 'prefer-const' in code fence linting

* Add bespoke home footer for Flask and update logic

* fixup! Add bespoke home footer for Flask and update logic

* Fix code fence lint failure

* Fix support request link in account menu

* Fix unit test failure
2022-01-05 21:25:20 -03:30
Alex Donesky
df48c424a4
fix issue where transaction items without a TRANSACTION_CONFIRMED_EVENT have unhandled error when clicking into activity log (#13221) 2022-01-05 17:49:20 -06:00
Mark Stacey
94dc287bb1
Fix missing targetSubjectMetadata.name propType error (#13218)
There was a propType error shown on the snap install screen about the
`name` property of `targetSubjectMetadata` being missing despite it
being marked as required. This property should not have been required,
it does not always exist.
2022-01-05 19:02:44 -03:30
朱里
b9093e2a4d
Remove bottom space when hiding testnet (#12821) 2022-01-05 13:04:34 -06:00
dragana8
fc185e3139
mainnet tokens autopopulate add token form fields when on custom networks #12087 (#12800)
Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
2022-01-05 12:19:28 -06:00
zorrosword
e694059b28
Adjust the padding of lock button (#13017) 2022-01-05 12:16:24 -06:00
Mark Stacey
22f931e6b2
Prevent automatic rejection of confirmations (#13194)
* Prevent automatic rejection of confirmations

Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.

This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.

It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.

* Fix bug that prevented automatic closure detection

All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.

* Re-open popup when necessary

After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
Mark Stacey
139a67fca4
Include style lints in lint:fix script (#13217)
The `lint:fix` script now also calls `yarn stylelint --fix`. This step
was omitted previously, despite `stylelint` being part of the `lint`
npm script.
2022-01-05 13:38:51 -03:30
Mark Stacey
966bdffb12
Fix account-menu styles lint failure (#13215)
This error was introduced with #13100, which was merged without CI
checks because CircleCI was not running on that branch for some reason.
This error was fixed with `yarn lint:styles --fix`.
2022-01-05 12:23:19 -03:30
Michael Klem
b6b575620f
Lock button active state fix (#13100)
* Fix for Lock button active state. Github issue #13089

* Reverted unnecessary change

* Updated CHANGELOG.md

* Updated CHANGELOG.md

* Reverted my edits to this file
2022-01-05 10:07:41 -03:30
George Marshall
c95da7dbb6
Updating storybook webpack config and changing font paths (#13028) 2022-01-04 16:41:10 -08:00
Mark Stacey
75b9f71d45
Remove unnecessary mounted state from Home component (#13202)
The `mounted` state was used to derive state from props before the
first render of the Home component. Instead this state is now derived
in the constructor, which is also run before the first render. This
should behave exactly the same, except now we don't need the `mounted`
state or the `deriveStateFromProps` function anymore.

The call to `closeCurrentWindow` that was made in `componentDidUpdate`
has been moved to the constructor as well. There is no need to delay
that call, and this saves us from having to compare current with
previous state in that lifecycle function.
2022-01-04 19:19:06 -03:30
Alejandro Garcia Anglada
761f3ac33f
Adding margin auto support to Box (#12801) 2022-01-04 15:07:01 -06:00
Erik Marks
75e8b4f8b9
Add missing permissions middleware hook (#13205)
Adds a missing middleware hook for `wallet_requestPermissions` that we failed to add in #12243. Also adds a runtime check that throws an error if any expected hooks are not provided to `createMethodMiddleware`.

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2022-01-04 12:57:18 -08:00
dragana8
e213ea77bd
EditGasPopover story: convert knobs and actions to controls / args #13056 (#13125) 2022-01-04 13:23:57 -06:00
Ikko Ashimine
066b78c722
Fix typo in ComposableObservableStore.js (#13151) 2022-01-04 12:59:08 -06:00
Mark Stacey
8e835b1d78
Ignore 4Byte 502 errors during e2e tests (#13204)
The 4Byte API can sometimes fail during e2e tests with a 502 error.
Ideally we would avoid calling it at all during e2e tests, but in the
meantime we shouldn't treat this as a reason to fail the e2e test.
We have multiple fallbacks for 4Byte, it isn't relied upon by any
tests.
2022-01-04 14:40:59 -03:30
Alex Donesky
c266d4e6af
Feat/check update collectible ownership (#13110)
* Use method to check and update collectible ownership
2022-01-03 14:39:41 -06:00
Alex Donesky
211c5afb7b
add crowdin-bot to the CLA allowlist (#13193) 2022-01-03 13:48:56 -06:00
Mark Stacey
8866c39623
Update the Firefox prerelease version format (#13158)
The Firefox extension version format does not support the version
format we use (SemVer), so we have to specially format the extension
version to be compatible. The format we chose was
`[major].[minor].[patch].[buildType][buildVersion]`. But when we tried
to submit a build with a version in that format, it was rejected as
invalid for unknown reasons.

The Firefox extension format has been updated to
`[major].[minor].[patch][buildType][buildVersion]`. This seems to pass
validation.
2022-01-03 12:48:10 -03:30
Mark Stacey
3563a246fe
Allow templates without alerts (#13150)
The confirmation page template system allows templates to have alerts,
but it throws an uncaught Promise rejection if a template has no
alerts. This is the unintended side-effect of input validation.

The `getTemplateAlerts` function was updated to always return an array.
The one callsite was updated to expect an empty array if there were no
alerts to render, rather than expecting `undefined`.
2022-01-03 11:32:15 -03:30
Mark Stacey
ae97e91443
Fix how version_name manifest field is used (#13155)
The `version_name` manifest field was being used on Chrome to store the
build type. However, Chrome intended this field to be a full
representation of the version, for display purposes. This was evident
when uploading this version to the Chrome Web Store, because it used
`flask` as the entire version.

Instead the `version_name` field now includes the full SemVer version
string. The version parsing code within the build script and in the
wallet itself have been updated accordingly.
2022-01-03 10:30:13 -03:30
Mark Stacey
0cd4fb1da0
Allow Flask prerelease versions (#13156)
The build script only allowed prerelease versions for the "beta" build
type (e.g. `X.Y.Z-beta.0`). Now it allows Flask prerelease versions as
well.

This is required for the Flask release, where the prerelease version
helps distinguish the Flask error reports and metrics.
2022-01-03 10:29:57 -03:30
Mark Stacey
fe77367837
Update the Sentry setup log with the build type (#13157)
The `environment` field we use for Sentry includes the build type for
all build types except `main`, but the log message indicating that
Sentry did not include this. This log message is useful for ensuring
that Sentry is setup correctly, so it should display the same
environment that Sentry is using. It has been updated to do just that.
2022-01-03 10:29:44 -03:30
Alex Donesky
56a0385e94
maintain nft image aspect ratios and center images in collection view (#13136)
* maintain nft image aspect ratios and center images in collection view
2021-12-22 15:19:48 -06:00
Mark Stacey
c932696e5a
Remove duplicate selector getPermissionSubjectsMetadata (#13144)
This selector is a duplicate of the `getSubjectMetadata` selector,
which does the same thing except that there is no fallback for the case
where the `subjectMetadata` is falsy. This is OK because that state can
never be falsy.

This change was extracted from the `snaps` branch.
2021-12-22 16:31:48 -03:30
Mark Stacey
809aae0ac3
Add Chrome store policy compliant names/descriptions (#13142)
The Chrome Web Store has spam policies that prevent uploading
extensions that are too similar to each other. There are exceptions for
test and development versions of extensions, but these exceptions are
required to be clearly identified in the name and description of the
extension.

The name and description of both the Flask and beta distributions have
been updated to include explicit all-caps declarations that identify
them as development and beta distributions respectively, in-line with
the examples shown in the Chrome Web Store spam FAQ.

For more information, see: https://developer.chrome.com/docs/webstore/spam-faq/#test-version
2021-12-22 16:25:27 -03:30
Mark Stacey
51d54a76ba
Merge pull request #13141 from MetaMask/sync-master
Sync `master` with `develop`
2021-12-22 11:00:36 -03:30
Mark Stacey
ae57d69c42 Merge remote-tracking branch 'origin/develop' into sync-master
* origin/develop: (106 commits)
  Add more missing `appName` messages (#13140)
  Add missing `appName` localized messages for Flask and Beta (#13138)
  EIP-1559 V2: Adding default settings to advanced gas modal (#12911)
  EIP-1559 V2: Advanced gas fee modal - base fee and priority fee trends (#13025)
  Wire up priority fee range in new gas modal (#13044)
  EIP-1559 V2: Advanced gas fee modal - getting 12 hour ranges of base fee and priority fee (#12996)
  Switch Flask horizontal logos (#13113)
  Update `@babel/runtime` patch to fix lockdown error (#13109)
  Use promisified background in setUseNonceField (#13107)
  Fix account name duplicates (#12867)
  Choose accounts refactor (#13039)
  Fix permissions-connect-footer "learn more" link (#13092)
  Feat/collectibles the return (#12970)
  Subject metadata cleanup (#13090)
  Fix merge conflict typo
  Bump just-safe-set from 2.1.0 to 2.2.3 (#13049)
  Fix typo in German translation (#13040)
  Using EIP-1559 V2 for swaps (#12966)
  Make restore vault a form so an user can submit via keyboard (#12989)
  Remove legacy node parent detection (#12814)
  ...
2021-12-22 09:22:32 -03:30
Mark Stacey
178c181f73
Merge pull request #13139 from MetaMask/Version-v10.8.2
Version v10.8.2 RC
2021-12-22 09:21:53 -03:30
Mark Stacey
609f85dbc3
Add more missing appName messages (#13140)
Three locales were missing the `appNameBeta` and `appNameFlask`
localized messages. These were missed in the previous PR (#13138).
2021-12-21 21:36:20 -03:30
Mark Stacey
002a97a30f Update changelog for v10.8.2
The changelog now includes the sole change in this release, which is to
add app names for all locales for the Beta and Flask builds.
2021-12-21 19:52:19 -03:30
Mark Stacey
36dea1730e Add more missing appName messages
Three locales were missing the `appNameBeta` and `appNameFlask`
localized messages. These were missed in the previous PR (#13138).
2021-12-21 19:52:19 -03:30
Mark Stacey
a1f89e218a Add missing appName localized messages for Flask and Beta (#13138)
The `appNameFlask` and `appNameBeta` are mandatory because they are
used by the Chrome Web Store, but they are missing from some locales.
This will prevent submitting either of these build types.

These two messages have been added to all locales. The English name has
been used everywhere, since this is a brand name and brands are often
not translated. We can update this to something more appropriate for
other locales in the future if necessary.
2021-12-21 17:31:27 -03:30
MetaMask Bot
719cee5499 Version v10.8.2 2021-12-21 20:52:06 +00:00
Mark Stacey
279c7b61b0
Add missing appName localized messages for Flask and Beta (#13138)
The `appNameFlask` and `appNameBeta` are mandatory because they are
used by the Chrome Web Store, but they are missing from some locales.
This will prevent submitting either of these build types.

These two messages have been added to all locales. The English name has
been used everywhere, since this is a brand name and brands are often
not translated. We can update this to something more appropriate for
other locales in the future if necessary.
2021-12-21 16:32:57 -03:30
Niranjana Binoy
8c77e37d2a
EIP-1559 V2: Adding default settings to advanced gas modal (#12911) 2021-12-21 14:45:28 -05:00
Niranjana Binoy
3a11800cb1
EIP-1559 V2: Advanced gas fee modal - base fee and priority fee trends (#13025) 2021-12-21 14:01:43 -05:00
Elliot Winkler
d990cb5eeb
Wire up priority fee range in new gas modal (#13044)
Use the `priorityFeeRange` property which is now available in the gas
fee estimate data.
2021-12-17 16:00:25 -07:00
Niranjana Binoy
7cd11a975c
EIP-1559 V2: Advanced gas fee modal - getting 12 hour ranges of base fee and priority fee (#12996) 2021-12-17 13:26:20 -05:00
Mark Stacey
73379c528b
Merge pull request #13115 from MetaMask/master-sync
Sync `develop` with `master`
2021-12-17 11:05:15 -03:30
Mark Stacey
0c18366a87 Merge remote-tracking branch 'origin/develop' into master-sync
* origin/develop: (100 commits)
  Switch Flask horizontal logos (#13113)
  Update `@babel/runtime` patch to fix lockdown error (#13109)
  Use promisified background in setUseNonceField (#13107)
  Fix account name duplicates (#12867)
  Choose accounts refactor (#13039)
  Fix permissions-connect-footer "learn more" link (#13092)
  Feat/collectibles the return (#12970)
  Subject metadata cleanup (#13090)
  Fix merge conflict typo
  Bump just-safe-set from 2.1.0 to 2.2.3 (#13049)
  Fix typo in German translation (#13040)
  Using EIP-1559 V2 for swaps (#12966)
  Make restore vault a form so an user can submit via keyboard (#12989)
  Remove legacy node parent detection (#12814)
  Add stories for Home notification component (#13035)
  Update Redux DevTools README instructions (#13038)
  Jestify app/scripts/controller/network/**/*.test.js (#12985)
  Fix order of account list (#12999)
  Changes in gas loading animation in EIP-1559 V2 (#13016)
  Add crowdin configuration and github action (#12552)
  ...
2021-12-17 09:49:45 -03:30
Dan J Miller
6f9927e15e
Merge pull request #13111 from MetaMask/Version-v10.8.1
Version v10.8.1 RC
2021-12-16 21:11:03 -03:30
Mark Stacey
9f85210f7c Fix changelog lint error
The category was missing for the single change listed for this release.
2021-12-16 18:30:03 -03:30
dependabot[bot]
bb390f06ae Bump just-safe-set from 2.1.0 to 2.2.3 (#13049)
Bumps [just-safe-set](https://github.com/angus-c/just) from 2.1.0 to 2.2.3.
- [Release notes](https://github.com/angus-c/just/releases)
- [Commits](https://github.com/angus-c/just/commits)

---
updated-dependencies:
- dependency-name: just-safe-set
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-16 17:31:31 -03:30
Dan Miller
7eee2cf7fe Update changelog 2021-12-16 17:25:28 -03:30
Mark Stacey
b02a6df597 Update @babel/runtime patch to fix lockdown error (#13109)
We are currently patching `@babel/runtime` to fix various lockdown
errors caused by `@babel/runtime` modifying globals as part of various
polyfills. There was one lockdown error that was showing up in Sentry
error reports, which is the polyfill used for `Reflect.construct`.

All of our supported browsers include this API, so the polyfill has
been replaced with a Proxy that returns the `Reflect.construct`
function directly, except with the addition of the `default` and
`__esModule` properties. I don't know what these properties are for
(maybe ES5/ES6 interoperability?) but I left them just in case they
were being relied upon.
2021-12-16 17:13:49 -03:30