m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Remove duplicate selector getPermissionSubjectsMetadata (#13144)

Browse Source 
This selector is a duplicate of the `getSubjectMetadata` selector,
which does the same thing except that there is no fallback for the case
where the `subjectMetadata` is falsy. This is OK because that state can
never be falsy.

This change was extracted from the `snaps` branch.
This commit is contained in:
Mark Stacey 2021-12-22 16:31:48 -03:30 committed by GitHub
parent 809aae0ac3
commit c932696e5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ui/selectors/permissions.js
View File

@ -3,6 +3,7 @@ import {
getMetaMaskAccountsOrdered,
getOriginOfCurrentTab,
getSelectedAddress,
getSubjectMetadata,
} from '.';
// selectors
@ -17,16 +18,6 @@ export function getPermissionSubjects(state) {
return state.metamask.subjects || {};
}
/**
* Get the permission subjects metadata object.
*
* @param {Object} state - The current state.
* @returns {Object} The permission subjects metadata object.
*/
export function getPermissionSubjectsMetadata(state) {
return state.metamask.subjectMetadata || {};
}
/**
* Selects the permitted accounts from the eth_accounts permission given state
* and an origin.
@ -82,7 +73,7 @@ export function getPermittedAccountsByOrigin(state) {
export function getConnectedSubjectsForSelectedAddress(state) {
const { selectedAddress } = state.metamask;
const subjects = getPermissionSubjects(state);
const subjectMetadata = getPermissionSubjectsMetadata(state);
const subjectMetadata = getSubjectMetadata(state);
const connectedSubjects = [];
@ -116,7 +107,7 @@ export function getConnectedSubjectsForSelectedAddress(state) {
* connected subject info.
*/
export function getAddressConnectedSubjectMap(state) {
const subjectMetadata = getPermissionSubjectsMetadata(state);
const subjectMetadata = getSubjectMetadata(state);
const accountsMap = getPermittedAccountsByOrigin(state);
const addressConnectedIconMap = {};