1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 03:12:42 +02:00
Commit Graph

17346 Commits

Author SHA1 Message Date
Mark Stacey
805ce29e11 Add types of hidden properties to Sentry data (#20457)
* Add types of hidden properties to Sentry data

The masked wallet state object sent to Sentry has been updated to
include the type of each property omitted from the mask. This lets us
at least see the full state shape, making it easier to see when errors
are caused by invalid state.

Relates to #20449

* Remove inconsistent state snapshot properties

The state snapshot tests have been updated to exclude properties that
were shown to differ between runs.
2023-08-17 09:01:25 -02:30
Mark Stacey
dc7ebe979e Add additional validation for persisted state metadata (#20462)
Additional validation has been added for persisted state metadata.
Beforehand we just checked that the state itself wasn't falsy. Now we
ensure that the metadata is an object with a valid version as well.
2023-08-17 09:01:25 -02:30
Dan J Miller
915bf2ae88 Capture exception with sentry when invariant conditions are met in migrations (#20427)
* capture exception for sentry when invariant conditions are met in migration 82

* Code cleanup

* Capture exceptions in invariant conditions for migrations 83,84,85,86,89,91,93,94

* Update app/scripts/migrations/082.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Code cleanup

* Fix SentryObject type declaration

* Stop throwing error if preferences controller is undefined

* Refactor 084 and 086 to remove double negative

* Capture exceptions for invariant states in in migrations 87,88,90 and 92

* lint fix

* log warning in migration 82 when preferences controller is undefined

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-17 09:01:05 -02:30
Mark Stacey
1ad47c660b Use unflattened state for Sentry (#20428)
The unflattened background state is now attached to any Sentry errors
from the background process. This provides a clearer picture of the
state of the wallet, and unblocks further improvements to Sentry state
which will come in later PRs.
2023-08-16 22:55:07 -02:30
Mark Stacey
d610aad2fd Split Sentry mask into UI and background masks (#20426)
The state mask used to anonymize the Sentry state snapshots has been
split into UI and background masks. This was done to simplify later
refactors. There should be no functional changes.
2023-08-16 22:54:59 -02:30
Mark Stacey
83c8a6be99 Update protobufjs (#20469)
Update `protobufjs` to the latest version. This resolves a security
advisory for this package. The advisory is concerning prototype
pollution, so it likely never affected us due to LavaMoat protections.
2023-08-16 22:54:15 -02:30
Frederik Bolding
e7b113caa2 Bump SES to fix audit failure (#20434)
* Bump SES to fix audit failure

* Freeze Symbol
2023-08-16 22:51:49 -02:30
Mark Stacey
1ab0c9e160 Fix Sentry error e2e tests (#20479)
The state fixtures in the Sentry e2e tests became invalid in #20458
due to a conflict with that change (the new state properties were
missing). The state fixtures have been updated.
2023-08-16 16:34:42 -02:30
Dan J Miller
789122d587 Capture app and migration version (#20458)
* Add AppMetadataController so current and previous application and migration version can be captured in sentry

* Add currentAppVersion, previousAppVersion, previousMigrationVersion, currentMigrationVersion to SENTRY_OBJECT

* Update app/scripts/controllers/app-metadata.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/controllers/app-metadata.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/controllers/app-metadata.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Fix types

* Add tests for app-metadata.test.ts

* Lint fixes

* Modify loadStateFromPersistence to return the whole versionData object, so that the migration version can be passed to the metamask-controller on instantiation

* Remove reference to implementation details in test descriptions in app/scripts/controllers/app-metadata.test.ts

* Reset all mocks afterEach in AppMetadataController

* Refactor AppMetadataController to be passed version instead of calling platform.version directly (for ease of unit testing the MetaMask Controller)

* Make maybeUpdateAppVersion and maybeUpdateMigrationVersion private, and remove unit tests of those specific functions

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-16 14:47:01 -02:30
Mark Stacey
594dde58b1 Add additional Sentry E2E tests (#20425)
* Reorganize Sentry error e2e tests

The tests have been reorganized into different describe blocks. Each
describe block is for either before or after initialization, and either
with or without opting into metrics.

This was done to simplify later test additions. The conditions for each
test are now in the describe block, letting us test additional things
in each of these conditions. The conditions were flattened to a single
level to avoid excessive indentation.

* Add error e2e test for background and UI errors

The Sentry e2e tests before initialization only tested background
errors, and the after initialization tests only tested UI errors. Now
both types of errors are tested in both scenarios.

* Add error e2e tests for Sentry error state

E2E tests have been added to test the state object sent along with each
Sentry error.

At the moment this object is empty in some circumstances, but this will
change in later PRs.

* Rename throw test error function

* Only setup debug/test state hooks in dev/test builds

The state hooks used for debugging and testing are now only included in
dev or test builds. The function name was updated and given a JSDoc
description to explain this more clearly as well.

* Add state snapshot assertions

State snapshot assertions have been added to the e2e error tests. These
snapshots will be very useful in reviewing a few PRs that will follow
this one.

We might decide to remove these snapshots after this set of Sentry
refactors, as they might be more work to maintain than they're worth.
But they will be useful at least in the short-term.

The login step has been removed from a few tests because it introduced
indeterminacy (the login process continued asynchronously after the
login, and sometimes was not finished when the error was triggered).

* Ensure login page has rendered during setup

This fixes an intermittent failure on Firefox

* Format snapshots with prettier before writing them

* Use defined set of date fields rather than infering from name

* Remove waits for error screen

The error screen only appears after a long timeout, and it doesn't
affect the next test steps at all.
2023-08-16 14:46:53 -02:30
Dan J Miller
442181de94 Log before and after each migration run (#20424)
* Log before and after each migration run

* Use loglevel
2023-08-16 14:38:30 -02:30
Dan Miller
72d20c92d6 Version v10.34.5 2023-08-16 14:29:17 -02:30
Dan J Miller
14486a8a80
Merge pull request #20418 from MetaMask/Version-v10.34.4
v10.34.4
2023-08-07 10:18:12 -02:30
Dan J Miller
0c8bd0ce4a
Update CHANGELOG.md
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-08-07 09:38:47 -02:30
Dan J Miller
ce0fd8069e Update changelog for v10.34.4 2023-08-07 09:34:56 -02:30
Frederik Bolding
9fdf2f0076 [FLASK] snaps@0.38.1-flask.1 (#20420) 2023-08-07 09:22:56 -02:30
Dan Miller
15bf697538 Version v10.34.4 2023-08-06 20:42:30 -02:30
Dan J Miller
a042f90db1
Merge pull request #20389 from MetaMask/Version-v10.34.3
Version v10.34.3
2023-08-03 19:17:13 -02:30
Daniel
87b3ac62f1 Improvements to Swaps quote auto-selection logic, fix and edge case with zero-balance tokens (#20388)
* Add Token To into assets again (reverting commit 51f46eb65f48bdf4980f400a589bf1ac63a65222 )

* Update cleanup for an unswapped Token To from the Tokens list

* Call "setLatestAddedTokenTo" conditionally

* Update an E2E test for insufficient balance notification
2023-08-03 18:22:17 -02:30
David Walsh
eda24aab4f Fix 'Global Menu Explorer / Account Details' What's New (#20371) 2023-08-03 13:49:32 -02:30
Mark Stacey
75dcb03069 Force an update of the phishing warning configuration (#20381)
The "last fetched" state for the `PhishingController` has been deleted
to force an immediate full update of the phishing configuration state.
We're doing this because the state was cleared in v10.34.2 because the
format of that state had changed.

This has been implemented in migration 92. The previous migration 92
has been renamed to 93 because it won't be included until a future
release. We need the migrations to remain sequential, and this will
save us from having to resolve a complex conflict when releasing this.
2023-08-03 13:47:29 -02:30
Dan J Miller
f526c170e2 v10.34.2 2023-08-03 13:41:16 -02:30
Dan J Miller
35c6305181
Merge pull request #20217 from MetaMask/Version-v10.34.2
Version v10.34.2
2023-08-01 21:02:31 -02:30
Dan J Miller
fdc22247be
Update CHANGELOG.md
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 20:37:16 -02:30
Dan J Miller
5ed415d807 Fix migration 88 to handle the case where chainId keys can be undefined (#20345)
* Fix migration 88 to handle the case where chainId keys can be undefined

* Add migration 91 to delete network configurations that have no chainId

* Lint fix

* Update migration number

* Update migration 91 description

* Update version numbers in 091.test.js

* Fix 088.test.ts typescript problem

* Fix 088.test.ts typescript problem

* Update app/scripts/migrations/091.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Change app/scripts/migrations/091.test.js to typescript

* clone oldstorage for test result comparisons in 091.test.js

* Lint fix

* Add missing test case

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 20:24:20 -02:30
Dan J Miller
ab967487da Update changelog 2023-08-01 19:55:43 -02:30
Dan J Miller
75377cf890
Update CHANGELOG.md
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 19:52:18 -02:30
Thomas Huang
b9f647f478 [skip-e2e] Update changelog for v10.34.2 (#20238) 2023-08-01 00:17:20 -02:30
Mark Stacey
1ed8f99fdf Remove fallback phishing warning configuration (#20327)
* Remove fallback phishing warning configuration

The package `@metamask/phishing-controller` has been updated from v4
v6. The only breaking changes are a minimum Node.js version bump, and
the removal of the fallback phishing configuration.

The fallback phishing configuration was resulting in MetaMask being
incorrectly flagged as malware, and the stale config was causing
problems for sites that had been blocked in the past but have since
been unblocked. This should substantially reduce the bundle size as
well.

* Update LavaMoat policies

* Update test state to include example blocked site

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-08-01 00:17:07 -02:30
Dan J Miller
6f0caf4d3f
Capture Sentry errors prior to initialization (#20265) (#20330)
* Capture Sentry errors prior to initialization

Sentry errors captured before/during the wallet initialization are
currently not captured because we don't have the controller state yet
to determine whether the user has consented.

The Sentry setup has been updated to check the persisted state for
whether the user has consented, as a fallback in case the controller
state hasn't been initialized yet. This ensures that we capture errors
during initialization if the user has opted in.

* Always await async check for whether the user has opted in

* Remove unused import

* Update JSDoc return type

* Remove unused driver method

* Fix metametrics controller unit tests

* Fix e2e tests

* Fix e2e test on Firefox

* Start session upon install rather than toggle

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 20:35:50 -02:30
Dan J Miller
d09f375b2c Fix migration 77 (#20276)
* Handle the case where tokensChainsCache data is undefined in migration 77

* Delete parts of state that should have been removed in migrations 82,84,86 and 88

* Create 077-supplements.md

* Update 077-supplements.md

* Update 077-supplements/*.js code comments

* Fix types and jsdoc

* Type/lint fix

* Cleanup

* Add 'should set data to an empty object if it is null' test case to 077.test.js

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Modify deletion criteria so that all decimal chain id proprties are deleted in migration 88 supplement

* Readme.md

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Lint fix

* Only delete decimal chain id keyed-entries in migration 88 supplement if there are hexadecimal keyed entries as well

* Remove redundant test

* Add 'does not delete' cases for nftcontroller related tests in 077.test.js

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 20:01:15 -02:30
Nicholas Ellul
db92bef002 Update @metamask/phishing-controller to v4.0.0 (#18840)
* Update phishing controller to v4.0.0

* Move phishing e2e test utilities into its own helper.js

* Update phishing detection e2e test

* Update MetaMask Controller test mocks

* Update mv3 phishing tests

* Fix test for 500 error on warning page

* Allow for directories in test folder

* Update migration number

* Linting fixes

* Remove fail on console error

* Separate mocks from helpers

* Have migration delete PhishingController state entirely

* Remove phishing detection directory

* Only delete the listState in migration

* Bump migration version
2023-07-31 17:55:48 -02:30
David Walsh
f1af52cbdf Fix #20162 - Add Whats New for Global Menu (#20244) 2023-07-28 20:48:40 -02:30
Howard Braham
3c65b3fa7f fix(clipboard): Increase DEFAULT copy to clipboard time (#20008) 2023-07-27 15:59:16 -02:30
Nicholas Ellul
51cad751de Add improved downloading logic when exporting state logs (#19872)
* Add improved downloading logic when exporting state logs

* Make test for state logs download only apply to firefox

* Remove eslint override

* Add file extension to test

* Move make jest global.Blob accessible to window
2023-07-27 15:45:51 -02:30
David Walsh
5db22ceb84 UX: Ensure currently selected account displays when Account Menu opens (#20166)
* UX: Ensure currently selected account displays when Account Menu opens

* Jest tests
2023-07-26 21:06:46 -02:30
David Walsh
41bab4a6e1 UX: Show Checksum Addresses in Account Menu 2023-07-26 17:42:54 -02:30
David Walsh
f14a0ddb94 UX: Ensure block explorer link is for desired account (#20144) 2023-07-26 17:42:47 -02:30
David Walsh
78a0587c97 Fix #20006 - Add Address Details and View on Explorer to Global Menu (#20013)
* Fix #20006 - Add Address Details and View on Explorer to Global Menu

* Fix tests
2023-07-26 17:42:34 -02:30
Dan J Miller
d8c49d9a99 v10.34.2 2023-07-26 17:32:27 -02:30
Dan J Miller
ddac73b5ce
Merge pull request #20175 from MetaMask/Version-v10.34.1
Version v10.34.1 RC
2023-07-26 01:29:33 -02:30
Dan J Miller
9ee7459d0f Update yarn.lock for v10.34.1, which updated sentry/cli -> node-fetch dep version, but doesn't include b7da0a9 2023-07-25 23:55:20 -02:30
Dan J Miller
40314a84c9 Update changelog for v10.34.1 2023-07-25 23:55:12 -02:30
Dan J Miller
b1fb8204f3 Migration 89: ensure providerConfig in state has an id property (#20181)
* Migration 89: ensure providerConfig in state has an id property

* Exit transformState function early if providerConfig already has an id

* Update migrations/index.js

* Code cleanup
2023-07-25 21:18:40 -02:30
Dan J Miller
374656a3d1 Fix sentry sourcemaps (#20122)
* Update sentry/cli to 2.19.4

* Ensure sentry files are loaded and referenced with a valid url

* Temp to eliminate errors in sentry (should be split into other PRs)
2023-07-25 18:03:42 -02:30
Mark Stacey
fbae250b0a Fix invalid state persistence error (#20080)
* Fix invalid state persistence error

We have been seeing Sentry errors showing that state persistence has
been failing for some users that have invalid `NetworkController`
state. This has been fixed by updating to
`@metamask/base-controller@v3.2.0`, which is more tolerant of
unexpected state properties.

* Update LavaMoat policies

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-25 18:02:54 -02:30
Mark Stacey
f01e8379fa v10.34.1 2023-07-18 16:50:03 -02:30
Dan J Miller
839543c5db
Merge pull request #19848 from MetaMask/Version-v10.34.0
Version v10.34.0 RC
2023-07-14 15:06:12 -02:30
Dan J Miller
c25d47952e Remove failing audit exclusion for GHSA-h755-8qp9-cq85 2023-07-14 09:35:58 -02:30
Elliot Winkler
65946c47c4 Restore support for Linea networks (#20011)
When the NetworkController in this repo was replaced with
`@metamask/network-controller`, support for Linea networks was lost
as it did not support it at that time. `@metamask/network-controller`
has since been updated, so this commit bumps that package to restore
support.
2023-07-14 09:35:58 -02:30