1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-02 06:07:06 +01:00
Commit Graph

4658 Commits

Author SHA1 Message Date
Dan J Miller
738d2722c5 Fixes updates on the confirm screen. (#11788)
* Fixes updates on the confirm screen.

* Better handling of internal send transactions

* maxFee -> maxFeePerGas property name fix

* Remove redundant setEstimateToUse call in onManualChange

* Fix unit tests

* rebase error fix

* Fixes to speedup loading and transaction breakdown priority fee

* Fix lint and unit tests

* Ensure gas price based transaction that have been customized (e.g. speed up and retry) are properly initialized in useGasFeeInputs

* Clean up

* Link fix
2021-08-06 19:30:10 -02:30
David Walsh
39e5750981 EIP-1559 - Ensure form always displays when there are errors (#11787) 2021-08-06 01:45:53 -02:30
Alex Donesky
2089767d96 fix confirm transaction details to match spec (#11779) 2021-08-06 01:45:53 -02:30
David Walsh
0377e2c64e Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly (#11781) 2021-08-06 01:45:53 -02:30
Alex Donesky
99fecbf6d2 Separate out non blocking gas errors (#11783) 2021-08-06 01:45:53 -02:30
Alex Donesky
f3995b72b0 Add fee level education button to swaps edit gas popover (#11785) 2021-08-06 01:45:53 -02:30
David Walsh
df6c05eb17 Fix NumericInput proptype error (#11773) 2021-08-06 01:45:53 -02:30
Dan J Miller
c2bfa57981 Allow max fee to be equal to max priority fee (#11778) 2021-08-05 14:23:50 -02:30
Dan J Miller
48bfd6c7f6 Use bignumber for number comparisons in useGasFeeInput (#11776)
* Use bignumber for number comparisons in useGasFeeInput

* fix
2021-08-05 14:23:49 -02:30
Dan J Miller
825e8b7bbf Ensure that gas fee inputs fallback to tx params values if api is down (#11775)
* Ensure that gas fee inputs fallback to tx params values if down

* ensure getGasFeeEstimate fallback is a string
2021-08-05 10:49:24 -02:30
Dan J Miller
aa0f35a8ba Ensure that gas fee minimum errors show when api is down (#11767)
* Fix legacy unapproved tx handling

* clean up
2021-08-04 20:24:40 -02:30
Dan J Miller
7384aea541 Fix legacy unapproved tx handling (#11766) 2021-08-04 20:24:40 -02:30
Alex Donesky
ab1cd1152e tiny lost code change from 9.8.4 RC (#11764) 2021-08-04 20:24:40 -02:30
David Walsh
efed7c2980 EIP-1559 - Fix mislabeled MaxPriority fee key (#11758) 2021-08-04 20:24:40 -02:30
Alex Donesky
02c0cbede9 Stop GasFeeController polling when pop closes (#11746)
* Stop GasFeeController polling when pop closes

* Stop estimate gas polling on window unload

* lint + comments

* Improve client closed logic

* lint

* Add back _beforeUnload on unmount in gas-modal-page-container

* Add full check and call onClientClosed method for notifcation environment

* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type

* remove unused method

* move controller manipulation logic from background.js to metamask-controller, disaggregate methods

* add beforeunload handling to reset gas polling tokens from root of send page

* cleanup, lint and address feedback

* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller

* mock new methods to fix tests

* final bit of cleanup + comments

Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 20:24:40 -02:30
David Walsh
1f578fcb1b Provide pointer cursor for radio group buttons (#11763) 2021-08-04 20:24:40 -02:30
Dan J Miller
e1efc7170c Show advanced options, and hide radio buttons, for advanced gas settings users (#11751)
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on

* Improve naming and copy

* lint fix

* Lint fix
2021-08-04 20:24:40 -02:30
David Walsh
5d7eba2684 EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate (#11759) 2021-08-04 20:24:40 -02:30
David Walsh
179f368ae5 EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail (#11762) 2021-08-04 20:24:40 -02:30
David Walsh
f17514489f EIP-1559 - Remove unncessary props from AdvancedFormControls (#11757) 2021-08-04 20:24:40 -02:30
Dan J Miller
b9d5c431c1 Ensure gas fees update in popover on poll for new values (#11760) 2021-08-04 20:24:40 -02:30
Alex Donesky
0dcdbdd99e remove unnecessary conversion call (#11742)
* remove unnecessary conversion call

* Pass args to GasTiming as decGwei

* lint
2021-08-04 13:54:15 -02:30
ryanml
0eef0d424d Fixing errors in EditGasDisplay (#11748) 2021-08-04 13:54:15 -02:30
Dan J Miller
8f50afb0dc Allow max priority fee to be below 1, and only require it to be greater than 0 (#11749) 2021-08-04 13:54:15 -02:30
Dan J Miller
8a31aaadcb Allows users to set a max priority fee below suggested, just showing a warning in that case (#11750) 2021-08-04 13:54:15 -02:30
Dan J Miller
17a4b5224a Rename effective gas price field to total gas fee (#11754) 2021-08-04 13:54:15 -02:30
Alex Donesky
ce88b87860 Remove estimate detail above advanced gas controls in non-1559 network (#11744)
* Remove estimate detail above advanced gas controls in non-1559 network

* lint

* remove gasEstimate localization text
2021-08-03 22:13:09 -02:30
ryanml
3c0846df84 Fall back to aggregator name when icon is unavailable (Swaps Load View) (#11718) 2021-08-03 22:13:09 -02:30
David Walsh
c4c1504e09 EIP-1559 - Show minium native currency in banner when on testnets (#11743) 2021-08-03 22:13:09 -02:30
Daniel
474d7571b6 Fix a position of a tooltip icon (#11739) 2021-08-03 14:01:25 -02:30
Alex Donesky
340c3d2876 Add gasPrice to be used on non-1559 networks for transaction details on confirm screen (#11741) 2021-08-03 14:01:25 -02:30
David Walsh
29072a0cf0 EIP-1559 - Provide better validation for gas price and gas limit (#11736) 2021-08-03 14:01:25 -02:30
Dan J Miller
ac32efd814 Ensure that gas price in popover updates when api provided estimate updates (#11727) 2021-08-03 14:01:25 -02:30
David Walsh
ce61eaacdf EIP-1559 - Ensure transaction detail font-size and icon colors are consistent with Figma design (#11735) 2021-08-03 14:01:25 -02:30
David Walsh
3b2b5c018f EIP-1559 - Return null from GasTiming if on non-1559 network (#11733) 2021-08-03 14:01:25 -02:30
David Walsh
e2fbc7ce8e
Remove button group for non-EIP-1559 networks (#11712)
* Remove button group for non-EIP-1559 networks

* Fix tests...maybe

* Remove unnecessary props, as well as gas display

* Remove unused string

* test progress

* fix test

* fix test

* add customizes gas block to improve e2e pass rate

Co-authored-by: Alex <adonesky@gmail.com>
2021-08-02 18:53:13 -05:00
David Walsh
c8b3dfe4e9
EIP-1559 - Fall back to gasLimit and gasPrice for hardware wallets (#11716) 2021-08-02 17:52:18 -05:00
Dan J Miller
8481c4b6be
Show warning when network request for fee market estimates fails (#11724) 2021-08-02 19:19:07 -02:30
David Walsh
d34bf92fd0
Fix 11705 - Reset gas limit when radio button clicked (#11710)
* Fix 11705 - Reset gas limit when radio button clicked

* Trigger manual change when gasLimit is changed

* Coordinate gas limit with radio buttons

* Revert "Coordinate gas limit with radio buttons"

This reverts commit 910327a408e32ae989c5565a107db24ac24f2a98.

* Cleanup default gas limit

* setEstimateToUse only update gasLimit on error, add default minimum gasLimit

* add minimum gasLimit fallback

Co-authored-by: Alex <adonesky@gmail.com>
2021-08-02 17:58:30 -02:30
Alex Donesky
c43f6cab63
remove estimate detail in advanced gas controls (#11728) 2021-08-02 14:32:43 -05:00
kumavis
7018b43898
improve password-manager metadata attributes (#11690) 2021-08-02 10:40:44 -07:00
Dan J Miller
668fd2db66
Ensure that gas fee/prices params are not updated while in send edit stage/mode (#11620)
* Ensure that gas fee/prices params are not updated while in send edit stage/mode

* Allow editing of txparams gas price when not on eip1559 network, in send flow
2021-08-02 12:17:42 -02:30
David Walsh
4ce6994a6c
Fix #11695 - Prevent maxFee and maxPriorityFee imbalance (#11700) 2021-08-02 09:07:29 -05:00
David Walsh
38ff2c937f
Fix #11703 - Provide wiring for approval modal (#11711) 2021-08-02 09:07:15 -05:00
David Walsh
81f274303e
EIP-1559 - Only show advanced form toggle when radio buttons are present (#11713) 2021-08-01 08:09:53 -05:00
David Walsh
219b0f9bd6
Fix 11709 - Always show fiat on mainnet (#11714) 2021-08-01 08:09:24 -05:00
Dan J Miller
9c0e34b264
EIP-1559 - Ensure gas limit is of minimum value (#11702) 2021-07-31 08:02:14 -05:00
David Walsh
39823b3800
EIP-1559 - Implement speedup and cancel buttons (#11701) 2021-07-31 08:01:29 -05:00
Alex Donesky
8a42258e10
Remove the SHOW_EIP_1559_UI environment variable, replace with network detection where appropriate (#11694)
Fixing up tests and add back old custom gas modal for non-eip1559 compliant networks

Remove unnecessary props from send-gas-row.component

fix breaking test

Fix primary and secondary title overrides

fix rebase issue

Fix rebase conflict

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2021-07-30 22:59:21 -02:30
Brad Decker
e0953d9f68
Update send and confirm state management, and tx controller gas defaults, for EIP1559 (#11549)
wip

Documentation improvements for send slice support of EIP1559

Remove console.log in send duck

Property lookup safety improvement in selectors/confirm-transaction

Add code accidentally removed in rebase

Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks (#11615)

* Fix typo

Remove console.log in send duck

* Update addTxGasDefaults and _getDefaultGasFees to work correctly with all new gas fee estimate types

* Don't show gas timing support when not on eip1559 compatible network

* Hide gas timing component on transaction screen when on a non-1559 network

* Improve comments, tests and edge case handling

* Ensure eip1559 fees are applied and updated correctly when eip1559 estimate api fails

* Lint fix

Co-authored-by: Brad Decker <git@braddecker.dev>

Remove console.log

Handle possible gasEstimateType undefined

Remove unnecessary nonce field position change in confirm-page-container-content__details
2021-07-30 22:15:18 -02:30