m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

EIP-1559 - Provide better validation for gas price and gas limit (#11736)

Browse Source
This commit is contained in:
David Walsh 2021-08-03 10:54:49 -05:00 committed by Dan Miller
parent f9a4f177b8
commit 29072a0cf0
5 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/_locales/en/messages.json
View File

@ -683,6 +683,9 @@
"editGasMedium": {
"message": "Medium"
},
"editGasPriceTooLow": {
"message": "Gas price must be greater than 0"
},
"editGasPriceTooltip": {
"message": "This network requires a “Gas price” field when submitting a transaction. Gas price is the amount you will pay pay per unit of gas."
},

5
ui/components/app/advanced-gas-controls/advanced-gas-controls.component.js
View File

@ -156,6 +156,11 @@ export default function AdvancedGasControls({
</>
)
}
error={
gasErrors?.gasPrice
? getGasFormErrorText(gasErrors.gasPrice, t)
: null
}
/>
</>
)}

2
ui/components/ui/numeric-input/numeric-input.component.js
View File

@ -25,7 +25,7 @@ export default function NumericInput({
}
}}
onChange={(e) => {
onChange?.(parseFloat(e.target.value, 10));
onChange?.(parseFloat(e.target.value || 0, 10));
}}
min="0"
autoFocus={autoFocus}

3
ui/helpers/constants/gas.js
View File

@ -6,6 +6,7 @@ export const GAS_FORM_ERRORS = {
MAX_PRIORITY_FEE_HIGH_WARNING: 'editGasMaxPriorityFeeHigh',
MAX_FEE_HIGH_WARNING: 'editGasMaxFeeHigh',
MAX_FEE_IMBALANCE: 'editGasMaxFeeImbalance',
GAS_PRICE_TOO_LOW: 'editGasPriceTooLow',
};
export function getGasFormErrorText(type, t, { minimumGasLimit } = {}) {
@ -24,6 +25,8 @@ export function getGasFormErrorText(type, t, { minimumGasLimit } = {}) {
return t('editGasMaxFeeHigh');
case GAS_FORM_ERRORS.MAX_FEE_IMBALANCE:
return t('editGasMaxFeePriorityImbalance');
case GAS_FORM_ERRORS.GAS_PRICE_TOO_LOW:
return t('editGasPriceTooLow');
default:
return '';
}

3
ui/hooks/useGasFeeInputs.js
View File

@ -425,6 +425,9 @@ export function useGasFeeInputs(
if (networkAndAccountSupports1559) {
estimatesUnavailableWarning = true;
}
if (gasPriceToUse <= 0) {
gasErrors.gasPrice = GAS_FORM_ERRORS.GAS_PRICE_TOO_LOW;
}
break;
default:
break;