Ariella Vu
3f5bc978dd
Fix Blockaid and OpenSea BannerAlert placement for Token Allowance, Confirm Pages, SIWE, and Signature V3/V4 pages ( #20530 )
...
* refactor: add SecurityProviderBannerAlert ...props
* fix: mv security banner alerts on TokenAllowance
* fix: mv security BannerAlert in confirm page
https://github.com/MetaMask/MetaMask-planning/issues/1195
* fix: allow BlockaidBannerAlert null details
* refactor: rm SecurityProviderBannerAlert margin
* fix: SIWE security banner alert placement
* fix: rm extra banner alert padding for sig v3 & v4
* fix: update SecurityProviderBannerAlert snapshot
* fix: update BlockaidBannerAlert snapshot
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-08-30 07:05:53 -07:00
Albert Olivé
60f149178c
[MMI] Set approved status in tx controller in MMI logic ( #20507 )
...
* fix(custodial-signing): set approved status in tx controller in MMI logic
* Fixed the issue that was not showing custody-confirm-link
---------
Co-authored-by: Shane Terence Odlum <shane.odlum@consensys.net>
2023-08-18 14:38:51 +02:00
Albert Olivé
b5ece42ca1
[MMI] Fix Connect MMI and Deep link Flows ( #19881 )
...
* Sending showCustodyConfirmLink as a prop and fixing other issues
* Upgraded MMI extension monrepo and trying to fix the issue
* prevents deeplink from closing
* Fixed styles of Custody view and changed the place of it
* Fixed CI issues
* fixing eslint issues
* Update LavaMoat policies
* fixing tests
* Fixed test
* updated snapshots
* reorder, otherwise it won't make sense
* adds necessary methods
* removes duplicated key value
* updated snapshot
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-07-13 10:42:08 +02:00
Albert Olivé
08b881880f
[MMI] Improved code, fixed bugs and added more tests ( #19488 )
...
* Improved code, fixed bugs and added more tests
* removing tabKey prop as is causing to fail other test
2023-06-08 11:01:06 +02:00
Albert Olivé
2070e5e42a
Feature/mmi 3009 confirm transaction base code fences ( #19335 )
...
* Added code fences
* Continue working on this ticket
* Fixed policies
* Added compliance-row component
* Fixed tests and css
* Fixed invalid locale
* Fixing linting
* Add optional check
* Fixing issues
* Fixed storybook
* Added missing dependency
* ran lavamoat auto
* ran dedupe and lavamoat
* lint
* Removed compliance row
* Removed unneeded package
* Removed unneeded proptyes
* updates mmi packages
* updating lavamoat
* formatting main
* Fixed conflicts
* updates lock file
* Moved code fences to have them all in the same place
* Updated yarn.lock and lavamoat
* remove linebreak
* Improved logic in order to not have many code fences and improve readability
* Fixing proptypes issues with eslint
* runs lavamoat auto
* Testing fixes issue e2e tests
* Testing issues
* Reverting code fences container
* Fixing issue with binding
* Added code fences in proptypes
* Reverting code fences
* Removed institutional from main lavamoat
* Added code fences in confirm transaction base component
* Adding tests for handleMainSubmit
* Improving code
* Added test for handleMainSubmit
* Removed waitFor
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-06-07 08:43:28 +02:00
Jyoti Puri
f1de905be7
Fix details when transferring NFT not added to wallet ( #19045 )
2023-06-02 18:33:10 +05:30
legobeat
dfafdbb6bd
Revert "[MMI] Add confirm-transaction-base code fences ( #18795 )" ( #19328 )
...
This reverts commit 97a9834182
2023-05-30 21:39:38 +09:00
Albert Olivé
97a9834182
[MMI] Add confirm-transaction-base code fences ( #18795 )
...
* Added code fences
* Continue working on this ticket
* Fixed policies
* Added compliance-row component
* Fixed tests and css
* Fixed invalid locale
* Fixing linting
* Add optional check
* Fixing issues
* Fixed storybook
* Added missing dependency
* ran lavamoat auto
* ran dedupe and lavamoat
* lint
* Removed compliance row
* Removed unneeded package
* Removed unneeded proptyes
* updates mmi packages
* updating lavamoat
* formatting main
* Fixed conflicts
* updates lock file
* Moved code fences to have them all in the same place
* Updated yarn.lock and lavamoat
* remove linebreak
* Improved logic in order to not have many code fences and improve readability
* Fixing proptypes issues with eslint
* runs lavamoat auto
* Testing fixes issue e2e tests
* Testing issues
* Reverting code fences container
* Fixing issue with binding
* Added code fences in proptypes
* Reverting code fences
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-29 16:50:56 +01:00
Ariella Vu
813ad984ce
Fix contract interaction recipient and contract address ( #18855 )
2023-05-18 18:19:40 +01:00
Albert Olivé
a017a1bae0
[MMI] Added note to trader code fencing ( #18051 )
...
* Added note to trader code fencing
* Started adding code fences in signature-request
* Finished code fencing
* Improving code
* adds check and runs prettier
* Fixed storybook and code fences bundle
* Added missing dependency
* updates fences
* fewer lines
* undo previously merged PR
* ran lavamoat auto
* adds test
* prettier
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-16 16:44:08 +01:00
Ariella Vu
a5d7cf3319
Transaction cleanup and fix TransactionDetailItem key not unique bug ( #18899 )
...
* TransactionDetailItem: allow empty detailText
* TxDetailItem: fix keys; ensure unique keys
2023-05-02 00:42:59 -03:00
Jyoti Puri
82a64195a2
Enable editing L2 gas on optimism ( #18217 )
2023-04-26 05:43:38 +05:30
Jyoti Puri
c6aa4f38c5
Fix approve all warning modal ( #18613 )
...
* Fix approve all warning modal
* fix
* fix
* fix
2023-04-18 13:22:16 -02:30
Niranjana Binoy
fedd6d4970
New reusable gas-display component ( #17976 )
2023-04-17 10:34:26 -04:00
Elliot Winkler
1304ec7af5
Convert shared/constants/metametrics to TS ( #18353 )
...
We want to convert NetworkController to TypeScript in order to be able
to compare differences in the controller between in this repo and the
core repo. To do this, however, we need to convert the dependencies of
the controller to TypeScript.
As a part of this effort, this commit converts
`shared/constants/metametrics` to TypeScript. Note that simple objects
have been largely replaced with enums. There are some cases where I even
split up some of these objects into multiple enums.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-04-03 09:31:04 -06:00
Jyoti Puri
5dee7904d6
Extracting out title component from confirm-transaction-base ( #17991 )
2023-03-23 22:21:33 +04:00
Jyoti Puri
0ac54e40ee
Extract out confirm-data and confirm-hex-data components from confirm-transaction-base.component.js ( #17822 )
2023-03-09 10:38:37 +05:30
Jyoti Puri
1c0ff8a6e8
Fix state in confirm transaction ( #17838 )
2023-02-24 22:37:26 +05:30
Ariella Vu
7d1dc7f177
Cleanup: clearTimeout on useEffect for gas estimation and prevent state update on unmounted ConfirmTransactionBase ( #17804 )
2023-02-17 22:11:50 +07:00
Jyoti Puri
9979020252
Confirm transaction test ( #17780 )
2023-02-16 20:23:15 +05:30
Dan J Miller
c3100d8fe4
Ensure simulation failure warning is shown on all networks and accounts ( #17458 )
...
* Ensure simulation failure warning is shown on all networks and accounts
* Add e2e test to cover failure warning behaviour on non-eip-1559 network
* Fix new e2e test
2023-02-10 11:45:54 -03:30
amerkadicE
0c2af508ef
Fix recent recipient order ( #16346 )
2023-02-09 23:15:52 +05:30
Danica Shen
794f3039f1
feature: migrate design-system.ts ( #17518 )
2023-02-02 20:15:26 +00:00
Vladimir Saric
308151cd49
Display a warning and gas fee component for token allowance and NFT flow when transaction is expected to fail ( #17437 )
...
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-02-01 17:14:09 -06:00
Jyoti Puri
26222a9b27
Refactoring confirm-transaction-base component ( #17484 )
2023-02-01 11:24:41 +05:30
Brad Decker
3ff12d70e9
Replace usages of conversion util in rest of UI folder in favor of Numeric ( #17334 )
2023-01-24 08:44:49 -06:00
Brad Decker
92f6ea6f6b
Relocate conversion utils to shared/modules/conversion.utils.js ( #17319 )
2023-01-20 11:04:37 -06:00
Danica Shen
8f915807e4
fix(mme-14830): fix consistent tab when switching languages ( #17155 )
2023-01-19 15:05:42 +00:00
Brad Decker
5f6d2ba6b0
Convert Transaction constants to typescript ( #17149 )
2023-01-18 08:47:29 -06:00
Niranjana Binoy
20cbe44d63
Moving transaction-alerts component from /ui/pages/confirm-transaction folder to ui/component/app folder ( #17272 )
2023-01-18 09:30:26 -05:00
Niranjana Binoy
a0bb4a6c5a
Toggle option to enable/disable balance and Token rate checking for using third-party API ( #16772 )
2023-01-17 10:23:04 -05:00
Filip Sekulic
fc83a1b631
Fixed navigation through multiple unapproved transactions for ERC20 tokens ( #16822 )
2023-01-11 09:01:50 -06:00
Dan J Miller
22fc60a341
Show user the general contract interaction screen for token approvals, when the asset standard is undefined ( #16765 )
...
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
2022-12-19 13:38:28 -03:30
Jyoti Puri
8125473dc5
Removing flag for EIP1559 V2 support ( #16446 )
2022-12-09 00:07:06 +05:30
amerkadicE
8885c54f13
NFT setApprovalForAll warning popover ( #16195 )
...
* NFT setApprovalForAll warning popover
2022-12-06 14:24:07 -06:00
Frederik Bolding
025ee2cb48
[FLASK] Expose transaction origin to transaction insight snaps ( #16671 )
...
* Expose transaction origin to transaction insight snaps
* Support multiple icons for each label for a permission
* Add transaction insight origin permission
* Fix fencing
* Fix import and permission crash
* Use function properly for connected accounts
2022-12-01 14:38:56 +01:00
Dan J Miller
0a5c46b156
Prevent user from editing a contract interaction created by a dapp ( #16498 )
...
* Prevent user from editing a contract interaction created by a dapp
* Code cleanup
* Fix e2e test selector
* Fix e2e test
* Fix e2e test
* Update snapshot
2022-11-15 12:28:39 -03:30
Adnan Sahovic
328626debe
Warning on a Send transaction request ( #16220 )
2022-11-09 09:36:21 -06:00
Guillaume Roux
cf265ed7ef
[FLASK] Allow snaps insights to show on regular EOA transactions ( #16093 )
2022-10-26 11:09:32 +02:00
Filip Sekulic
76af0f4d4f
Renamed setApproveForAllArg variable to be isApprovalOrRejection ( #16012 )
2022-10-04 13:37:11 -05:00
Filip Sekulic
2ba6e68c8b
NFT Approval and SetApprovalForAll confirmation screens header updated ( #15727 )
...
* Updated header for NFT approval and Set approval for all screens
2022-09-21 09:15:34 -05:00
Guillaume Roux
c9dc59ea2a
[FLASK] Snaps Insight ( #15814 )
...
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
2022-09-20 19:00:07 +02:00
Filip Sekulic
6e13524bcd
Remove related UI code from the app dir ( #15384 )
...
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2022-09-16 14:05:21 -05:00
Dan J Miller
fc65ca63af
Ensure approval warning for setApprovalForAll is not shown when revoking ( #15806 )
...
Co-authored-by: ryanml <ryanlanese@gmail.com>
2022-09-14 10:32:04 -05:00
VSaric
6e0f130168
New metrics data for token approval transactions ( #15289 )
2022-08-18 08:49:50 -05:00
Dan J Miller
4fdbc816c0
Prevent confirm screen from showing method name from contract registry for txes created within MetaMask ( #15472 )
...
* Prevent confirm screen from showing method name from contract registry for txes created within MetaMask
* Ensure method name does not get sent in state when sending to a contract, with tx data, from metamask send screen
2022-08-04 17:20:32 -02:30
Dan J Miller
6602e4a013
Ensure smart contract interactions are properly represented on the confirm screen ( #15446 )
...
* Ensure smart contract interactions are properly represented on the confirm screen
* Fix unit tests
* Code cleanup
* Cleanup
* Code cleanup
* Fix test
2022-08-03 17:05:34 -02:30
VSaric
f1ca3e56e7
Modify transaction type and add contract method data to metrics ( #15175 )
2022-07-22 12:45:04 -05:00
Alex Donesky
4f0115fcdc
Add setApprovalForAll confirmation view ( #15010 )
...
* enhance setApprovalForAll confirmation flow
* cleanup
* address feedback
2022-07-11 18:32:55 -05:00
Zachary Belford
c2d5bd01c4
Changed networks tab to explicitly pass in false and fix implicit type casting
2022-06-08 14:24:36 -07:00
