m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

[FLASK] Allow snaps insights to show on regular EOA transactions (#16093)

Browse Source
This commit is contained in:
Guillaume Roux 2022-10-26 11:09:32 +02:00 committed by GitHub
parent 29a33b4692
commit cf265ed7ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/components/app/confirm-page-container/confirm-page-container-content/confirm-page-container-content.component.js
View File

@ -102,9 +102,11 @@ export default class ConfirmPageContainerContent extends Component {
>
{detailsComponent}
</Tab>
<Tab className="confirm-page-container-content__tab" name={t('data')}>
{dataComponent}
</Tab>
{dataComponent && (
<Tab className="confirm-page-container-content__tab" name={t('data')}>
{dataComponent}
</Tab>
)}
{dataHexComponent && (
<Tab
className="confirm-page-container-content__tab"

12
ui/pages/confirm-transaction-base/confirm-transaction-base.component.js
View File

@ -764,13 +764,17 @@ export default class ConfirmTransactionBase extends Component {
({ id }) => id === selectedInsightSnapId,
);
const allowedTransactionTypes =
txData.type === TRANSACTION_TYPES.CONTRACT_INTERACTION ||
txData.type === TRANSACTION_TYPES.SIMPLE_SEND ||
txData.type === TRANSACTION_TYPES.TOKEN_METHOD_SAFE_TRANSFER_FROM ||
txData.type === TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER_FROM ||
txData.type === TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER;
const networkId = CHAIN_ID_TO_NETWORK_ID_MAP[chainId];
const caip2ChainId = `eip155:${networkId ?? stripHexPrefix(chainId)}`;
if (
txData.type !== TRANSACTION_TYPES.CONTRACT_INTERACTION ||
!insightSnaps.length
) {
if (!allowedTransactionTypes || !insightSnaps.length) {
return null;
}