* BannerTip to TS
* removing actionButtonProps control from storybook file
* fixing console errors in storybook
* BannerTip docs fixes, prop fixes and test updates
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
* Add the deprecation JSDoc format below to the deprecated code and added deprecation notice to the icon-with-fallback.stories.js
* Declared <IconWithFallback/> as deprecated
* feat: update sentry mask adding controller props to improve error monitoring
* fix:remove changes in chrome-driver dependency
* Remove properties from mask
* Add more values to mask
* Sort the mask alphabetically
* Add termsOfUseLastAgreed to mask
* Fix test imports
* Update policy gap test to compare UI mask
* Reorganize tests under one describe block
* Update snapshots
* Mask another timestamp in state snapshots
* Mask browser environment properties
* Add missing UI field mask, and refactor field masking/removal
* Eliminate remaining policy gaps
* Simplify ganache options
* Eliminate extra mask properties
* Update mask to capture dynamic keys
The mask now supports dynamic keys. This lets set more fine-grained rules
for which data to include within dynamic data structures.
The mask has been updated to include just top-level keys for various
token-related data collections in state. This lets us see the chain IDs
that users have tokens on. This will be useful in debugging Sentry
reports of invalid keys in these data structures.
* Add additional 'expected missing state' entries
* Remove unnecessary properties from state snapshot
* Add providerConfig.chainId to state snapshot
* Update error state snapshots
---------
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* fix: overflow of link and warnings
* fix: update snapshot
* --wrapped in React.memo HOC
--changed Website to a clickable link
--slightly better overflow wrapping, but the best would be to wrap on dots and slashes
* updated snapshot
---------
Co-authored-by: Howard Braham <howrad@gmail.com>
* Add whats new popup for changes to advanced gas fee
* Update shared/notifications/index.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* updated text
* verified working, changed order of init
* use first renderer for formatting issue
---------
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
* created new route for connections
* remove unnecessary code
* added connections component
* fixed connections route
* moved connections to pages in multichain
* moved connections route to multichain feature flag
* origin/develop: (302 commits)
Added deprecatation comment to menu.js file and Add deprecation notice to storybook (#20622)
deprecating NetworkDisplay in favour of PickerNetwork (#20619)
deprecating ConfirmPageContainerWarning in favour of BannerAlert (#20621)
deprecating Dialog in favour of BannerAlert (#20623)
Fixing linting issue caused by bad merge of HoldToRevealModal and the Button component library component TS migration (#20634)
Feat/18890/button ts update (#20492)
20488: Declare <Chip/> as deprecated (#20579)
fix: Remove obsolete network controller state properties (#20586)
Fix Sentry source maps (#20616)
Track snap uninstalls (#20624)
split advancedGasFee by network and erase previous options (#20576)
Part of #20163 for file ui\components\app\detected-token\detected-token-values\detected-token-values.js (#20537)
Fix account selectors when balances are missing (#20385)
fix:fix error of balance fetching when add/import an account (#20612)
fix:remove extra $ after variale in french locale (#20606)
Multichain v1 App Footer component (#20550)
Updating watch NFT page header (#20569)
Always show connected accounts permissions if they exist (#20600)
Update snaps-related copy (#20601)
Added missing bindings (#20602)
...
* button to TS migration
working demo
style props
broken mapping - need switch
working types file
working types
fix dependent imports of Button
variant mapping
working types
fix lint
fix test
fix ButtonSize issue on QuizContent
box fix
test if this works
fix button being used on QuizContent
fix button_variant import
readme fix
* fix button import
* fix primary button as anchor hover
* deprecated
* button to TS migration
fix lint
fix test
* fix rebase issue
* fix rebase issue
* lint fix
Sentry source maps were broken a few weeks back, and then fixed in the
PR #20122. The fix was to add a leading slash to our file paths in the
source maps.
This fix was accidentally undone recently in #19552, which is an
otherwise unrelated change. I suspect this was committed accidentally
due to local testing of #20122 around the same time.
This PR restores the file path change made in #20122
* Split out advanced gas fees by network and delete old values
* use arrow functions in preferences test
* changes
* added back priorityFeeProperCase to en messages
* update types
* remove case change
* Part of #20163 for file ui\components\app\detected-token\detected-token-values\detected-token-values.js
* Update ui/components/app/detected-token/detected-token-values/detected-token-values.js
---------
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Fix account selectors when balances are missing
Some of the account selectors we use would return an empty set of
accounts if the `AccountTracker` state was missing. This resulted in UI
crashes when trying to access the current selected account.
The selectors have been updated to use the `identities` as the source-
of-truth for the full set of accounts. This ensures that even if the
balances are missing, each account will at least be represented by an
empty object.
* Fix unit test
* Fix another unit test
* Fix another unit test
* Fix another unit test
* Fix more unit tests
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
* fix(privateKey): Restore hold-to-reveal button for private key export
* lint and unit test fixes
* adding e2e tests to reveal private key
* fixing lint issues
* fixed: Private key is able to be presented without tapping and holding the "Hold to reveal" CTA
* Incorrect password test and support hold to reveal
* improving unit tests
---------
Co-authored-by: Plasma Corral <32695229+plasmacorral@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
This changelog entry in v10.34.1 was malformed. This has alreayd been
fixed in #20445, but we accidentally undid that fix as part of the sync
PR for v10.34.5 (#20482)
* feat(878): implement new incoming transaction toggle networks for setting and onboarding
* Update state snapshots
* feat(878): change gaps, migration types based on comment
---------
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Removes the `Website Accessed window.web3 Shim` event from the `metamask_logWeb3ShimUsage` RPC method implementation. The method itself displays an alert to the user if a website attempts to access the `window.web3` shim, which we replaced the original, functional `window.web3` object with after said object was removed. This seems potentially useful, because we still get 5-star reviews on [the legacy web3 extension](https://addons.mozilla.org/en-US/firefox/addon/metamask-legacy-web3/).
The associated metrics event, on the other hand, is useless. It is rife with false positives, and doesn't tell us anything that we can't learn from download data for the legacy web3 extension. It's time to get rid of it.
