1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Commit Graph

4629 Commits

Author SHA1 Message Date
Daniel
474d7571b6 Fix a position of a tooltip icon () 2021-08-03 14:01:25 -02:30
Alex Donesky
340c3d2876 Add gasPrice to be used on non-1559 networks for transaction details on confirm screen () 2021-08-03 14:01:25 -02:30
David Walsh
29072a0cf0 EIP-1559 - Provide better validation for gas price and gas limit () 2021-08-03 14:01:25 -02:30
Dan J Miller
ac32efd814 Ensure that gas price in popover updates when api provided estimate updates () 2021-08-03 14:01:25 -02:30
David Walsh
ce61eaacdf EIP-1559 - Ensure transaction detail font-size and icon colors are consistent with Figma design () 2021-08-03 14:01:25 -02:30
David Walsh
3b2b5c018f EIP-1559 - Return null from GasTiming if on non-1559 network () 2021-08-03 14:01:25 -02:30
David Walsh
e2fbc7ce8e
Remove button group for non-EIP-1559 networks ()
* Remove button group for non-EIP-1559 networks

* Fix tests...maybe

* Remove unnecessary props, as well as gas display

* Remove unused string

* test progress

* fix test

* fix test

* add customizes gas block to improve e2e pass rate

Co-authored-by: Alex <adonesky@gmail.com>
2021-08-02 18:53:13 -05:00
David Walsh
c8b3dfe4e9
EIP-1559 - Fall back to gasLimit and gasPrice for hardware wallets () 2021-08-02 17:52:18 -05:00
Dan J Miller
8481c4b6be
Show warning when network request for fee market estimates fails () 2021-08-02 19:19:07 -02:30
David Walsh
d34bf92fd0
Fix 11705 - Reset gas limit when radio button clicked ()
* Fix 11705 - Reset gas limit when radio button clicked

* Trigger manual change when gasLimit is changed

* Coordinate gas limit with radio buttons

* Revert "Coordinate gas limit with radio buttons"

This reverts commit 910327a408e32ae989c5565a107db24ac24f2a98.

* Cleanup default gas limit

* setEstimateToUse only update gasLimit on error, add default minimum gasLimit

* add minimum gasLimit fallback

Co-authored-by: Alex <adonesky@gmail.com>
2021-08-02 17:58:30 -02:30
Alex Donesky
c43f6cab63
remove estimate detail in advanced gas controls () 2021-08-02 14:32:43 -05:00
kumavis
7018b43898
improve password-manager metadata attributes () 2021-08-02 10:40:44 -07:00
Dan J Miller
668fd2db66
Ensure that gas fee/prices params are not updated while in send edit stage/mode ()
* Ensure that gas fee/prices params are not updated while in send edit stage/mode

* Allow editing of txparams gas price when not on eip1559 network, in send flow
2021-08-02 12:17:42 -02:30
David Walsh
4ce6994a6c
Fix - Prevent maxFee and maxPriorityFee imbalance () 2021-08-02 09:07:29 -05:00
David Walsh
38ff2c937f
Fix - Provide wiring for approval modal () 2021-08-02 09:07:15 -05:00
David Walsh
81f274303e
EIP-1559 - Only show advanced form toggle when radio buttons are present () 2021-08-01 08:09:53 -05:00
David Walsh
219b0f9bd6
Fix 11709 - Always show fiat on mainnet () 2021-08-01 08:09:24 -05:00
Dan J Miller
9c0e34b264
EIP-1559 - Ensure gas limit is of minimum value () 2021-07-31 08:02:14 -05:00
David Walsh
39823b3800
EIP-1559 - Implement speedup and cancel buttons () 2021-07-31 08:01:29 -05:00
Alex Donesky
8a42258e10
Remove the SHOW_EIP_1559_UI environment variable, replace with network detection where appropriate ()
Fixing up tests and add back old custom gas modal for non-eip1559 compliant networks

Remove unnecessary props from send-gas-row.component

fix breaking test

Fix primary and secondary title overrides

fix rebase issue

Fix rebase conflict

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2021-07-30 22:59:21 -02:30
Brad Decker
e0953d9f68
Update send and confirm state management, and tx controller gas defaults, for EIP1559 ()
wip

Documentation improvements for send slice support of EIP1559

Remove console.log in send duck

Property lookup safety improvement in selectors/confirm-transaction

Add code accidentally removed in rebase

Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks ()

* Fix typo

Remove console.log in send duck

* Update addTxGasDefaults and _getDefaultGasFees to work correctly with all new gas fee estimate types

* Don't show gas timing support when not on eip1559 compatible network

* Hide gas timing component on transaction screen when on a non-1559 network

* Improve comments, tests and edge case handling

* Ensure eip1559 fees are applied and updated correctly when eip1559 estimate api fails

* Lint fix

Co-authored-by: Brad Decker <git@braddecker.dev>

Remove console.log

Handle possible gasEstimateType undefined

Remove unnecessary nonce field position change in confirm-page-container-content__details
2021-07-30 22:15:18 -02:30
Dan J Miller
f1140087b7
Adds insufficient gas error to edit-gas-display () 2021-07-30 20:16:31 -02:30
Dan J Miller
a1f8a65519
Ensure correct conversion of data before calling getGasFeeTimeEstimate () 2021-07-30 19:41:55 -02:30
Daniel
fa703173a0
Fix Jest unit tests ()
* Fix Jest unit tests

* Provider correct getGasFeeTimeEstimate call to Gas Timing

* Fix tests for correct getGasFeeTimeEstimate method name

* Rename instances to getGasFeeTimeEstimate

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-07-30 15:10:41 -02:30
Daniel
24f5cc009b
Pass "maxFeePerGas" to the <GasTiming> component from Swaps () 2021-07-30 15:19:30 +02:00
David Walsh
e283c03c4e
EIP-1559 - Improve gas timing logic to show more accurate verbiage () 2021-07-30 08:00:02 -05:00
Daniel
714170c7b8
EIP-1559 and Rinkeby Testnet support in Swaps () 2021-07-30 13:35:30 +02:00
David Walsh
cbfde8a080
EIP-1559 - Fix duplicated networkSupports1559 variables () 2021-07-30 05:11:27 -05:00
Alex Donesky
583c115663
remove estimation appearance from edit-gas-popover on non-1559 networks () 2021-07-29 18:29:36 -05:00
Dan J Miller
b4722ff81d
Fix to having radio buttons in advanced gas inputs pre-selected ()
* Ensure fees match in use gas inputs

* Lint fix
2021-07-29 16:00:21 -02:30
David Walsh
990a278177
EIP-1559 - Only show radio group and gas timing when network supports 1559 () 2021-07-29 13:13:14 -05:00
David Walsh
15cbe4e9a0
EIP-1559 - Allow decimals for maxFeePerGas and maxPriorityFeePerGas () 2021-07-29 10:59:14 -05:00
David Walsh
0849738003
EIP-1559 - Don't hide advanced form when radio button is chosen () 2021-07-29 10:14:48 -05:00
David Walsh
6d1fb911dc
EIP-1559 - Fix education links () 2021-07-29 09:18:13 -05:00
Dan J Miller
aaa15cbe03
Add support for EIP1559 transactions to transaction breakdown ()
* Add support for EIP1559 transactions to transaction breakdown

* Use userPreferencedCurrencyDisplay for effective gas price in transaction breakdown

* Hide eip1559 gas properties in transaction breakdown on non-1559 networks

* Add comment explaining gasPrice and effectiveGasPrice usage in transaction breakdown container.
2021-07-28 15:00:34 -02:30
ryanml
52bac60a22
Fixing confirmation layout when dapp has suggested a price (EIP-1559) () 2021-07-28 11:29:55 -05:00
Dan J Miller
9a81b826c5
Only show dapp suggested gas fee warning if user has not edited the fee () 2021-07-27 20:01:53 -02:30
David Walsh
604524f94d
EIP-1559 - Restore custom values in Edit Gas Popover ()
* EIP-1559 - Restore custom values in Edit Gas Popover

* Provide method to tell which radio button the user may have selected

* Use lodash's findKey

* Add case for legacy gas

* Use gas instead of gasLimit

* Remove unnecessary deletion and todo
2021-07-27 17:12:56 +02:00
ryanml
813eef6080
Trimming whitespace in ENSInput () 2021-07-27 07:53:13 -07:00
Daniel
709369dc14
Fix default tooltip color () 2021-07-27 15:20:01 +02:00
Dan J Miller
f4d294714a
Ensure origin shows in gas popover dapp suggested gas fee warning () 2021-07-26 21:13:05 -02:30
David Walsh
fab9cfde03
EIP-1559 - Provide data wiring for Gas Timing component () 2021-07-26 10:35:51 -05:00
David Walsh
a2be02dfeb
EIP-1559 - Show gas estimate updating animation in transaction detail () 2021-07-26 10:24:44 -05:00
David Walsh
6986e76adc
EIP-1559 - Show advanced form controls by default when user has selected custom values or there are gas warnings/errors () 2021-07-26 09:17:23 -05:00
ryanml
d092e4bdbe
Fixing type issue with auto-filled custom token decimals value () 2021-07-26 07:08:10 -07:00
ryanml
d03dc311ee
Adding hex address guard to input validation for token sends () 2021-07-26 07:07:57 -07:00
Dan J Miller
02318df48c
Ensure that the send flow state recipient nickname gets set if recipient address is in addressBook () 2021-07-26 07:03:05 -07:00
Daniel
868d932165
Check for the "fromToken" existance before checking decimals () 2021-07-26 10:15:13 +02:00
David Walsh
5d92836c8c
EIP-1559 - Provide the nonce field in the new transaction display () 2021-07-25 09:56:24 -05:00
David Walsh
cd4521fb12
EIP-1559 - Allow wrapping for dapp suggested origin () 2021-07-24 15:40:51 -05:00