Mark Stacey
52fd72feac
Merge remote-tracking branch 'origin/develop' into sync-master
...
* origin/develop: (107 commits)
Clear Account Details in AppState (#9238 )
Permit all-caps addresses (#9227 )
Send web3 usage metrics once per origin/property (#9237 )
Fix import/no-extraneous-dependencies issues (#9232 )
Remove unused buyEth fn from bg (#9236 )
Fix max-statements-per-line issues (#9218 )
Consolidate ESLint config files (#9231 )
Delete page-container.component.test.js (#9229 )
Tidy up getAccountLink (#9223 )
Tidy ConnectHardwareForm#checkIfUnlocked (#9224 )
Fix require-unicode-regexp issues (#9212 )
Fix no-negated-condition issues (#9222 )
Fix no-empty-function issues (#9216 )
Fix import/extensions issues (#9217 )
Dedupe glob-parent versions (#9220 )
Fix no-template-curly-in-string issues (#9221 )
Fix no-process-exit issues (#9219 )
Fix prefer-rest-params issues (#9215 )
Fix no-prototype-builtins issues (#9213 )
Fix no-nested-ternary issues (#9214 )
...
2020-08-14 20:32:32 -03:00
Mark Stacey
eab1add857
Merge pull request #9240 from MetaMask/Version-v8.0.8
...
Version v8.0.8 RC
2020-08-14 20:30:22 -03:00
Thomas Huang
87e5281a82
Clear Account Details in AppState ( #9238 )
...
* Clear Account Details in AppState
We store sensitive information in the AppState under accountDetail for when the modal is active and present. This adds a new action/reducer and componentWillUnmount to clean up the persisted data left after leaving the modal.
* Remove reduntant clearAccountDetails call when clicking done button
2020-08-14 16:08:26 -07:00
Mark Stacey
e8a468a5ec
Update v8.0.8 changelog ( #9241 )
2020-08-14 20:05:14 -03:00
MetaMask Bot
5db866bc88
Version v8.0.8
2020-08-14 19:39:41 -03:00
Patryk Łucka
e47774d3e4
Permit all-caps addresses ( #9227 )
...
* permit all-caps addresses
* handle empty address
2020-08-14 19:39:41 -03:00
Patryk Łucka
aad840777d
Permit all-caps addresses ( #9227 )
...
* permit all-caps addresses
* handle empty address
2020-08-14 19:18:46 -03:00
Mark Stacey
d49c44426f
Send web3 usage metrics once per origin/property ( #9237 )
...
The usage metrics for the injected web3 instance were being sent upon
each use, which exceeded the limits of our Matomo plan. These metrics
are now only being sent upon the first usage, for each origin and
property.
2020-08-14 19:15:40 -03:00
Mark Stacey
f77151003e
Send web3 usage metrics once per origin/property ( #9237 )
...
The usage metrics for the injected web3 instance were being sent upon
each use, which exceeded the limits of our Matomo plan. These metrics
are now only being sent upon the first usage, for each origin and
property.
2020-08-14 19:15:21 -03:00
Patryk Łucka
74decc3407
Fix Etherscan redirect on notification click ( #9211 )
2020-08-14 19:15:03 -03:00
Mark Stacey
4d499cc39e
Add version
dimension to background metrics ( #9167 )
...
The background metrics were missing the `version` custom dimension. It
has now been added to all background metric events.
2020-08-14 19:05:27 -03:00
Whymarrh Whitby
aaacf66c6e
Fix import/no-extraneous-dependencies issues ( #9232 )
...
See [`import/no-extraneous-dependencies`](https://eslint.org/docs/rules/import/no-extraneous-dependencies ) for more information.
This change enables `import/no-extraneous-dependencies` and fixes the issues raised by the rule.
2020-08-14 17:34:56 -02:30
Whymarrh Whitby
c2edc342fb
Remove unused buyEth fn from bg ( #9236 )
2020-08-14 15:51:48 -02:30
Whymarrh Whitby
e021acdc0a
Fix max-statements-per-line issues ( #9218 )
...
See [`max-statements-per-line`](https://eslint.org/docs/rules/max-statements-per-line ) for more information.
This change enables `max-statements-per-line` and fixes the issues raised by the rule.
2020-08-14 15:13:56 -02:30
Whymarrh Whitby
9e7841fa91
Consolidate ESLint config files ( #9231 )
2020-08-14 13:41:25 -02:30
Whymarrh Whitby
04bfe3772c
Delete page-container.component.test.js ( #9229 )
2020-08-14 12:52:38 -02:30
Whymarrh Whitby
2aa4b6bbee
Tidy up getAccountLink ( #9223 )
2020-08-14 12:31:59 -02:30
Whymarrh Whitby
937616565d
Tidy ConnectHardwareForm#checkIfUnlocked ( #9224 )
...
This change tidies up the implementation of `ConnectHardwareForm#checkIfUnlocked`—passing
an `async` function to `forEach` doesn't ensure that the one is run before the other.
2020-08-14 11:57:42 -02:30
Whymarrh Whitby
5d42a9b773
Fix require-unicode-regexp issues ( #9212 )
...
* Fix require-unicode-regexp issues
See [`require-unicode-regexp`](https://eslint.org/docs/rules/require-unicode-regexp ) for more information.
This change enables `require-unicode-regexp` and fixes the issues raised by the rule.
* Remove case-insensitive flag from regexps
2020-08-14 09:18:42 -02:30
Whymarrh Whitby
884775cf71
Fix no-negated-condition issues ( #9222 )
...
See [`no-negated-condition`](https://eslint.org/docs/rules/no-negated-condition ) for more information.
This change enables `no-negated-condition` and fixes the issues raised by the rule.
2020-08-14 09:17:43 -02:30
Whymarrh Whitby
c11888f287
Fix no-empty-function issues ( #9216 )
...
See [`no-empty-function`](https://eslint.org/docs/rules/no-empty-function ) for more information.
This change enables `no-empty-function` and fixes the issues raised by the rule.
2020-08-14 09:17:02 -02:30
Whymarrh Whitby
9b78d3ab07
Fix import/extensions issues ( #9217 )
...
See [`import/extensions`](https://eslint.org/docs/rules/import/extensions ) for more information.
This change enables `import/extensions` and fixes the issues raised by the rule.
2020-08-14 09:16:45 -02:30
Whymarrh Whitby
c188121c3d
Dedupe glob-parent versions ( #9220 )
2020-08-14 09:16:24 -02:30
Whymarrh Whitby
3bd22a2058
Fix no-template-curly-in-string issues ( #9221 )
...
See [`no-template-curly-in-string`](https://eslint.org/docs/rules/no-template-curly-in-string ) for more information.
This change enables `no-template-curly-in-string` and fixes the issues raised by the rule.
2020-08-13 19:01:55 -02:30
Whymarrh Whitby
944f6d4880
Fix no-process-exit issues ( #9219 )
...
See [`no-process-exit`](https://eslint.org/docs/rules/no-process-exit ) for more information.
This change enables `no-process-exit` and fixes the issues raised by the rule.
2020-08-13 19:01:40 -02:30
Whymarrh Whitby
82a0ee27f3
Fix prefer-rest-params issues ( #9215 )
...
See [`prefer-rest-params`](https://eslint.org/docs/rules/prefer-rest-params ) for more information.
This change enables `prefer-rest-params` and fixes the issues raised by the rule.
2020-08-13 18:05:18 -02:30
Whymarrh Whitby
146127c474
Fix no-prototype-builtins issues ( #9213 )
...
See [`no-prototype-builtins`](https://eslint.org/docs/rules/no-prototype-builtins ) for more information.
This change enables `no-prototype-builtins` and fixes the issues raised by the rule.
2020-08-13 18:04:51 -02:30
Whymarrh Whitby
b91cf74d14
Fix no-nested-ternary issues ( #9214 )
...
See [`no-nested-ternary`](https://eslint.org/docs/rules/no-nested-ternary ) for more information.
This change enables `no-nested-ternary` and fixes the issues raised by the rule.
2020-08-13 17:30:09 -02:30
Patryk Łucka
5991043cd7
Fix Etherscan redirect on notification click ( #9211 )
2020-08-13 13:51:31 -02:30
Whymarrh Whitby
954df6e482
Fix no-constant-condition issues ( #9210 )
...
See [`no-constant-condition`](https://eslint.org/docs/rules/no-constant-condition ) for more information.
This change enables `no-constant-condition` and fixes the issues raised by the rule.
2020-08-12 22:09:17 -02:30
Whymarrh Whitby
e8b31a77b9
Use copy-webpack-plugin@6.0.3 ( #9197 )
...
This updates the `copy-webpack-plugin` to the latest published version, 6.0.3,
resolving [a high-severity security advisory][1] with its `serialize-javascript`
dependency.
[1]: https://www.npmjs.com/advisories/1548
See https://www.npmjs.com/advisories/1548 for more information.
The `yarn audit` output:
```
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high │ Remote Code Execution │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ serialize-javascript │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=3.1.0 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ copy-webpack-plugin │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ copy-webpack-plugin > serialize-javascript │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1548 │
└───────────────┴──────────────────────────────────────────────────────────────┘
```
The relevant [`v6.0.0`][2] breaking changes:
- minimum supported Node.js version is 10.13
- ✅ We use 10.18.1 locally and on CI
- the plugin now accepts an object, you should change `new CopyPlugin(patterns, options)` to `new CopyPlugin({ patterns, options })`
- ✅ Updated `.storybook/webpack.config.js`
[2]:https://github.com/webpack-contrib/copy-webpack-plugin/releases/tag/v6.0.0
2020-08-12 22:02:40 -02:30
Whymarrh Whitby
42e7d205b2
Fix no-dupe-else-if issues ( #9208 )
...
See [`no-dupe-else-if`](https://eslint.org/docs/rules/no-dupe-else-if ) for more information.
This change enables `no-dupe-else-if` and fixes the issues raised by the rule.
2020-08-12 21:22:02 -02:30
Whymarrh Whitby
853b89e314
Fix no-global-assign issues ( #9209 )
...
See [`no-global-assign`](https://eslint.org/docs/rules/no-global-assign ) for more information.
This change enables `no-global-assign` and fixes the issues raised by the rule.
2020-08-12 21:21:54 -02:30
Whymarrh Whitby
438bb954ef
Merge pull request #9193
...
Update webpack Terser Plugin
2020-08-12 21:21:31 -02:30
Whymarrh Whitby
cd370be728
Fix no-invalid-this issues ( #9207 )
...
See [`no-invalid-this`](https://eslint.org/docs/rules/no-invalid-this ) for more information.
This change enables `no-invalid-this` and fixes the issues raised by the rule.
2020-08-12 21:19:33 -02:30
Whymarrh Whitby
c0f05ccae6
Fix implicit-arrow-linebreak issues ( #9201 )
...
See [`implicit-arrow-linebreak`](https://eslint.org/docs/rules/implicit-arrow-linebreak ) for more information.
This change enables `implicit-arrow-linebreak` and fixes the issues raised by the rule.
2020-08-12 21:19:10 -02:30
Whymarrh Whitby
76bd7f98b6
Fix prefer-spread issues ( #9203 )
...
See [`prefer-spread`](https://eslint.org/docs/rules/prefer-spread ) for more information.
This change enables `prefer-spread` and fixes the issues raised by the rule.
2020-08-12 20:42:07 -02:30
Whymarrh Whitby
310b15ba4a
Fix no-plusplus issues ( #9206 )
...
See [`no-plusplus`](https://eslint.org/docs/rules/no-plusplus ) for more information.
This change enables `no-plusplus` and fixes the issues raised by the rule.
2020-08-12 20:36:44 -02:30
Whymarrh Whitby
548b0bbbd5
Fix no-eq-null issues ( #9205 )
...
See [`no-eq-null`](https://eslint.org/docs/rules/no-eq-null ) for more information.
This change enables `no-eq-null` and fixes the issues raised by the rule.
2020-08-12 20:32:44 -02:30
Whymarrh Whitby
f8ebfc2f63
Update PreferencesController#_validateERC20AssetParams tests ( #9204 )
...
This change fixes the `_validateERC20AssetParams` tests, ensuring that the given
options are all valid except those that are being tested. Previously the `symbol`
property was invalid _in addition to_ the `decimals` property.
2020-08-12 20:27:46 -02:30
Whymarrh Whitby
88f54e29fb
Fix no-empty issues ( #9202 )
...
See [`no-empty`](https://eslint.org/docs/rules/no-empty ) for more information.
This change enables `no-empty` and fixes the issues raised by the rule.
2020-08-12 18:20:29 -02:30
Whymarrh Whitby
3346c2fc07
Fix no-loop-func issues ( #9199 )
...
See [`no-loop-func`](https://eslint.org/docs/rules/no-loop-func ) for more information.
This change enables `no-loop-func` and fixes the issues raised by the rule.
2020-08-12 17:29:14 -02:30
Whymarrh Whitby
ef88d79fac
Fix no-useless-concat issues ( #9200 )
...
See [`no-useless-concat`](https://eslint.org/docs/rules/no-useless-concat ) for more information.
This change enables `no-useless-concat` and fixes the issues raised by the rule.
2020-08-12 17:07:44 -02:30
Whymarrh Whitby
9842b2f1ce
Fix no-useless-catch issues ( #9198 )
...
See [`no-useless-catch`](https://eslint.org/docs/rules/no-useless-catch ) for more information.
This change enables `no-useless-catch` and fixes the issues raised by the rule.
2020-08-12 16:37:15 -02:30
Whymarrh Whitby
a8863a3446
Fix consistent-return issues ( #9192 )
...
See [`consistent-return`](https://eslint.org/docs/rules/consistent-return ) for more information.
This change enables `consistent-return` and fixes the issues raised by the rule.
2020-08-12 16:36:57 -02:30
Whymarrh Whitby
d4f65e16b4
Use terser-webpack-plugin@2.3.8
2020-08-12 14:59:00 -02:30
Whymarrh Whitby
ca544a65ae
Use terser-webpack-plugin@1.4.5
2020-08-12 14:59:00 -02:30
Whymarrh Whitby
885125ad03
Fix no-case-declarations issues ( #9191 )
...
See [`no-case-declarations`](https://eslint.org/docs/rules/no-case-declarations ) for more information.
This change enables `no-case-declarations` and fixes the issues raised by the rule.
2020-08-12 14:11:27 -02:30
Brad Decker
b2813f0b54
colocate the base modal styles with the modal component ( #9151 )
...
finalizes the colocation of styles with the consuming components.
2020-08-12 12:49:45 -03:00
Erik Marks
163f45beed
Fix account modal back button styling ( #9184 )
2020-08-11 09:49:07 -07:00