Fix no-loop-func issues (#9199)

See [`no-loop-func`](https://eslint.org/docs/rules/no-loop-func) for more information.

This change enables `no-loop-func` and fixes the issues raised by the rule.

.eslintrc.js

@@ -48,6 +48,7 @@ module.exports = {
     'global-require': 'error',
     'guard-for-in': 'error',
     'no-case-declarations': 'error',
+    'no-loop-func': 'error',
     'no-useless-catch': 'error',
     'no-useless-concat': 'error',
     /* End v2 rules */

test/unit/migrations/023-test.js

@@ -38,6 +38,8 @@ let nonDeletableCount = 0
 let status
 while (transactions.length <= 100) {
   status = txStates[Math.floor(Math.random() * Math.floor(txStates.length - 1))]
+  // This is an old migration, let's allow it
+  // eslint-disable-next-line no-loop-func
   if (!deletableTxStates.find((s) => s === status)) {
     nonDeletableCount++
   }