1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-30 08:09:15 +01:00
Commit Graph

17160 Commits

Author SHA1 Message Date
Mark Stacey
28093b0c59 Fix fallback gas estimation (#19746)
* Fix fallback gas estimation

Our fallback gas estimation was failing due to a bug in the
`@metamask/controller-utils` package. This was causing gas estimation
to fail completely on certain networks (those not supported by our gas
estimation APIs and non EIP-1559 compatibile), and it was causing the
fallback gas estimation operation (in case our API was down) to fail
across all networks.

Fixes https://github.com/MetaMask/metamask-extension/issues/19735

* Add e2e tests

E2E tests have been added to capture gas estimation. Cases are added
for our API, for the fallback estimate, and for non-EIP-1559 estimates.

As part of this work, the legacy gas API had to be disabled. This was
being used in e2e tests but was dead code in production. It needed to
be disabled to ensure the code under test was reachable.

* Fix gas API referenced in e2e test

* Update unit test snapshots
2023-06-27 14:37:54 -02:30
Alex Donesky
3960fdfcf9 Add tokenId type validation in wallet_watchAsset middleware (#19738) 2023-06-27 14:35:33 -02:30
David Walsh
53edffe279 Fix #847 - Don't show account address on token pages (#19740)
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-06-27 14:33:30 -02:30
Nidhi Kumari
e8e6d7cd35 UX Multichain: fixed padding for edit screen (#19707)
* fixed padding for edit screen

* Use network picker for header trigger

* Fix swaps display

* updated snapshot

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-06-27 14:33:30 -02:30
Nidhi Kumari
5512e2921f removed portfolio link from wallet view (#19716)
* removed portfolio link from wallet view

* removed unused code

* updated test

* updated spec file

* updated test
2023-06-27 14:33:30 -02:30
Nidhi Kumari
0f330e21e5 added extra margin for unlocked state in full view in header (#19701)
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-06-27 14:33:30 -02:30
Dan J Miller
c76d91dfe7
Update changelog for v10.33.0 (#19664)
* Update changelog for v10.33.0

* Update CHANGELOG.md

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

---------

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-06-20 12:30:49 -02:30
Dan J Miller
ac3053d16a Run yarn lavamoat:auto for v10.33.0 2023-06-19 16:26:24 -02:30
MetaMask Bot
94c10bee96 Version v10.33.0 2023-06-16 16:44:05 +00:00
Victorien Gauch
e4923399a9
feat: add new linea mainnet network (#19326)
* feat: add new linea mainnet network

* fix: removed unused condition + lint code

* fix: update tests + fix network tab issue

* feat: add feature toggle for linea mainnet

* fix: add feature toggle for linea mainnet

* feat: add linea mainnet logo

* update @metamask/eth-json-rpc-infura package to support linea networks

* update linea mainnet block explorer url

* fix: refactor linea mainnet feature toggle

* fix: update linea mainnet chain id and rpc url

* fix: update settings-search unit test

* fix: update linea mainnet feature flag

* fix: remove useless async function keyword for linea mainnet feature flag
2023-06-16 14:05:33 -02:30
Garrett Bear
70d86ee67c
Feat/19274/ds popover update account list menu (#19534)
* update account list menu to use ds popover and fix accessibility issue

* close popover if user continues to tab to next items

* remove disable logic not doing anything

* add stylesheet

* add refs to track last menuitem

* cleaned up ref version for MenuItems

* fix test

* add click away option and fix test

* fix e2e test

* undo e2e test

* add account e2e

* fix click outside component

* remove additional line break

* remove commented out code

* add isOpen to story

* set width to 225px
2023-06-16 09:25:13 -07:00
Nidhi Kumari
a8a61ebc33
Updated contacts Title and copy changes in Send Flow (#19618)
* updated snapshot

* updated spacing for edit and delete in full screen

* updated ui

* reverted changes for contacts

* updated json
2023-06-16 21:36:27 +05:30
David Walsh
bc2a5aaf96
Fix #19619 - Submit the account creation form when pressing enter (#19620) 2023-06-16 08:13:08 -05:00
Daniel
1aae94fedc
Fix searchable item list height (#19634) 2023-06-16 15:06:25 +02:00
Dan J Miller
9a47ccf3cd
Merge pull request #19630 from MetaMask/master-sync
Master sync PR following v10.32.0
2023-06-16 08:21:41 -02:30
Guillaume Roux
0d0705bb68
[FLASK] Update rate limits for showInAppNotification and showNativeNotification (#19621) 2023-06-16 12:38:12 +02:00
Dan Miller
953af884de Merge branch 'develop' into master-sync 2023-06-15 21:19:01 -02:30
Dan J Miller
b1ef4e7738
Merge pull request #19310 from MetaMask/Version-v10.32.0
Version v10.32.0 RC
2023-06-15 21:09:21 -02:30
António Regadas
39e033ea00
[MMI] renames method for better understanding (#19622)
* better naming

* better naming

* undo change
2023-06-15 23:33:28 +01:00
Alex Donesky
c16b35c029
Extend wallet_watchAsset to support ERC721 and ERC1155 tokens (#19454)
* Extend wallet_watchAsset to support ERC721 and ERC1155 tokens
2023-06-15 15:18:12 -05:00
Daniel
8b3e3c8a58
Swaps UI update (#19169) 2023-06-15 20:17:21 +02:00
Mark Stacey
1f576641dc
Enable e2e debug flag in CI (#19588)
E2E tests will now run in debug mode on CI, printing out each step that
the driver takes during a test. This should make debugging intermittent
failures much easier.
2023-06-15 14:48:15 -02:30
legobeat
00607d2298
devDeps: socketcluster-client@14.3.1->14.3.2 (#19055)
CVE-2021-32640 / GHSA-6fc8-4gx4-v693
2023-06-16 01:58:45 +09:00
António Regadas
1520f57b77
MMI start script and fixes a bug preventing it to run (#19594)
* adds MMI start script and fixes a bug preventing it to run

* lint fix
2023-06-15 17:57:35 +01:00
David Walsh
d2f0b2f785
UX: Ensure 'Connect Hardware' route is functioning properly (#19612)
* UX: Ensure 'Connect Hardware' route is functioning properly

* restore create-account page

---------

Co-authored-by: Bernardo Garces Chapero <bernardo.chapero@consensys.net>
2023-06-15 11:55:23 -05:00
Olusegun Akintayo
a0e6737848
Fix unknown processing time not showing in warning color (#19527) 2023-06-15 10:52:08 -05:00
legobeat
f286d16664
devDeps: bump and align devDependencies (#19194)
* devDeps: madge@^5.0.1->^6.1.0

* devDeps: dependency-tree@^8.1.2->^10.0.7

* devDeps: gh-pages@^3.2.3->^5.0.0

* devDeps: del@^3.0.0->^6.1.1

* devDeps: chalk@^3.0.0->^4.1.2

* dedupe

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-06-16 00:47:39 +09:00
Bernardo Garces Chapero
55a1514513
fix signature controller patch (#19607) 2023-06-15 15:12:59 +01:00
David Walsh
276d9c74c6
Fix #19437 - Prevent Connected Sites global menu item from being clicked during confirmation (#19598)
* Fix #19437 - Prevent Connected Sites global menu item from being clicked during confirmation

* Add tests
2023-06-15 08:36:28 -05:00
David Walsh
b6f42bacf7
UX: Add portfolio button in overview (#19601) 2023-06-15 08:17:29 -05:00
Elliot Winkler
436a3dff4e
Sync NetworkController lookupNetwork tests w/ core (#19401)
* Sync NC lookupNetwork tests with core

This makes it easier to visually compare differences in the
NetworkController unit tests between core and this repo.

* Add types for toBeFulfilled matcher

* Fix lint again
2023-06-15 10:12:43 -02:30
Danica Shen
74d365cbaa
feature(19493): eliminate e2e flakyness for eth-sign (#19606) 2023-06-15 13:13:54 +01:00
Victorien Gauch
1fca9255c1
fix: refactor linea goerli testnet implementation (#19321)
* fix: refactor linea goerli testnet implementation

* fix: rename linea goerli network

* feat: add linea testnet logo

* update linea goerli block explorer url

* update @metamask/eth-json-rpc-infura package to version 8.1.0

* fix: refactor ticker map object in shared/constants/networks.ts files
2023-06-15 09:08:07 -02:30
Danica Shen
2648c783ad
feature(19496): eliminate flow e2e flakyness in terms of asserting content for DOM (#19600) 2023-06-15 11:01:44 +01:00
Nicholas Ellul
46a2604df0
Fix flakey tests in metamask controller tests (#19312)
* Refactor metamask controller tests to isolate mv3 specific setup
2023-06-14 15:38:40 -04:00
David Walsh
875bad125f
Fix #19439 - Allow Account Picker during Send flow (#19522)
* Fix #19439 - Allow Account Picker during Send flow

* Disable any network change with confirmations pending

* Disable the settings menu during an unconfirmed transaction
2023-06-14 13:49:14 -05:00
George Marshall
f4f80c223e
Adding deprecation tags to popover and old modals (#19556)
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-06-14 09:47:16 -07:00
legobeat
bcfda8b11c
devDeps: degenerator@3.0.1->3.0.4 (#19178)
- CVE-2023-32314 / GHSA-whpj-8f3w-67p5
- CVE-2023-32313 / GHSA-p5gc-c584-jj6v
2023-06-14 13:53:12 -02:30
Nidhi Kumari
bdb26b04fc
updated components with Multichain Prefix (#19593) 2023-06-14 21:21:19 +05:30
Elliot Winkler
7701b8b417
Sync NetworkController getEIP1559Compatibility tests w/ core (#19419)
This makes it easier to visually compare differences in the
NetworkController unit tests between core and this repo.
2023-06-14 08:35:43 -07:00
Elliot Winkler
312dadf91f
Sync NetworkController setProviderType tests (#19406)
This makes it easier to visually compare differences in the
NetworkController unit tests between core and this repo.
2023-06-14 09:23:36 -06:00
Elliot Winkler
9c91db5d31
Sync rollbackToPreviousProvider tests w/ core (#19428)
This makes it easier to visually compare differences in the
NetworkController unit tests between core and this repo.
2023-06-14 09:23:16 -06:00
Mark Stacey
b43900f743
Update message manager and signature controller (#19370)
* Update message manager and signature controller

The packages `@metamask/message-manager` and
`@metamask/signature-controller` have been updated to the latest
versions. These versions were part of part of the [core monorepo v53](MetaMask/core#1385)
release. The remaining packages released as part of v53 will be updated
in later PRs.

These releases included a few breaking changes, but none that affect
the extension. Both packages now expect `getCurrentChainId` to return
`Hex`, but that was already the case here. Additionally the signature
controller now has a peer dependency on the approval controller v3,
which is already present and at the correct version.

Relates to #19271

* Ignore error caused by TS bug

* Update types to omit metadata for encryption requests

* Update lavamoat policy
2023-06-14 11:27:41 -02:30
Mark Stacey
40d1df1e0d
Update lockfile (#19583)
The lockfile was stale on `develop`; it has now been updated.
2023-06-13 13:00:48 -02:30
Nidhi Kumari
c59941c7bc
UX Multichain: UI fixes for settings page (#19574)
* fixed spacings and UI for settings page

* lint fix
2023-06-13 20:47:35 +05:30
Nidhi Kumari
cc0b30776a
UX Multichain: updated enums for multichain token list item (#19575)
* updated enums for multichain token list iteam

* updated snapshot
2023-06-13 20:47:21 +05:30
George Marshall
6c3f31d382
Adding background/default to BorderColor enum to prevent propType error and updating tests (#19571) 2023-06-13 08:11:21 -07:00
David Walsh
28137798b6
UX: Multichain: Move Add Account and Import Account into Account Menu Popover (#19346)
* UX: Multichain: Move Add Account and Import Account into Account Menu Popover

* Create a new CreateAccount component for the Account Menu

* Add actions for import form

* Use separate actions for cancel vs. submit

* Fix jest tests

* Remove commented route navigation

* Accommodate for failing import

* Fix tests

* Remove routes for new account and import

* Remove old create account page

* Move import-account files to multichain directory

* Fix paths on the import files

* Remove deprecated component library variables

* Fix error property of add form

* Fix user-actions-benchmark
2023-06-13 10:07:01 -05:00
Mark Stacey
abd2a5559e
Update @metamask/gas-fee-controller to v6 (#19366)
* Update `@metamask/gas-fee-controller` to v6

The `@metamask/address-book-controller` package has been updated to v3.
This version was part of the [core monorepo v53](MetaMask/core#1385)
release. The remaining packages released as part of v53 will be updated
in later PRs.

This release included a number of breaking changes, but most of them
do not affect the extension:

* Bump to Node 16
  * The extension already uses Node.js v16
* The `getChainId` constructor parameter now expects a `Hex` return
type rather than a decimal string
  * The extension was already passing in a `getChainId` parameter that
returned `Hex`
* The gas fee controller messenger now requires the
`NetworkController:stateChange` event instead of the
`NetworkController:providerConfigChange` event
  * This does not apply if `onNetworkStateChange` and `getChainId` are
provided to the constructor, which is the case here.
* Update `@metamask/network-controller` dependency and peer dependency
  * This dependency is only used for types, and none of the type
changes affect how the extension interacts with this controller.

The one change that did have an impact is that the constructor
parameter `onNetworkStateChange` now expects event handlers to be
passed the full network state.

Relates to #19271

* Ensure chainid always matches mainnet in test builds

This is a bit strange, but this is how the tests were setup previously.

* Fix accidental state mutation

* Remove hardcoded mainnet chain ID from test builds
2023-06-13 12:13:13 -02:30
Frederik Bolding
be7900e9e9
[FLASK] Bump RateLimitController to v3 (#19578)
* Bump RateLimitController to latest

* Regen LavaMoat policies
2023-06-13 15:04:28 +02:00