1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-29 15:50:28 +01:00
Commit Graph

17318 Commits

Author SHA1 Message Date
Mark Stacey
1ed8f99fdf Remove fallback phishing warning configuration (#20327)
* Remove fallback phishing warning configuration

The package `@metamask/phishing-controller` has been updated from v4
v6. The only breaking changes are a minimum Node.js version bump, and
the removal of the fallback phishing configuration.

The fallback phishing configuration was resulting in MetaMask being
incorrectly flagged as malware, and the stale config was causing
problems for sites that had been blocked in the past but have since
been unblocked. This should substantially reduce the bundle size as
well.

* Update LavaMoat policies

* Update test state to include example blocked site

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-08-01 00:17:07 -02:30
Dan J Miller
6f0caf4d3f
Capture Sentry errors prior to initialization (#20265) (#20330)
* Capture Sentry errors prior to initialization

Sentry errors captured before/during the wallet initialization are
currently not captured because we don't have the controller state yet
to determine whether the user has consented.

The Sentry setup has been updated to check the persisted state for
whether the user has consented, as a fallback in case the controller
state hasn't been initialized yet. This ensures that we capture errors
during initialization if the user has opted in.

* Always await async check for whether the user has opted in

* Remove unused import

* Update JSDoc return type

* Remove unused driver method

* Fix metametrics controller unit tests

* Fix e2e tests

* Fix e2e test on Firefox

* Start session upon install rather than toggle

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 20:35:50 -02:30
Dan J Miller
d09f375b2c Fix migration 77 (#20276)
* Handle the case where tokensChainsCache data is undefined in migration 77

* Delete parts of state that should have been removed in migrations 82,84,86 and 88

* Create 077-supplements.md

* Update 077-supplements.md

* Update 077-supplements/*.js code comments

* Fix types and jsdoc

* Type/lint fix

* Cleanup

* Add 'should set data to an empty object if it is null' test case to 077.test.js

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Modify deletion criteria so that all decimal chain id proprties are deleted in migration 88 supplement

* Readme.md

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Lint fix

* Only delete decimal chain id keyed-entries in migration 88 supplement if there are hexadecimal keyed entries as well

* Remove redundant test

* Add 'does not delete' cases for nftcontroller related tests in 077.test.js

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 20:01:15 -02:30
Nicholas Ellul
db92bef002 Update @metamask/phishing-controller to v4.0.0 (#18840)
* Update phishing controller to v4.0.0

* Move phishing e2e test utilities into its own helper.js

* Update phishing detection e2e test

* Update MetaMask Controller test mocks

* Update mv3 phishing tests

* Fix test for 500 error on warning page

* Allow for directories in test folder

* Update migration number

* Linting fixes

* Remove fail on console error

* Separate mocks from helpers

* Have migration delete PhishingController state entirely

* Remove phishing detection directory

* Only delete the listState in migration

* Bump migration version
2023-07-31 17:55:48 -02:30
David Walsh
f1af52cbdf Fix #20162 - Add Whats New for Global Menu (#20244) 2023-07-28 20:48:40 -02:30
Howard Braham
3c65b3fa7f fix(clipboard): Increase DEFAULT copy to clipboard time (#20008) 2023-07-27 15:59:16 -02:30
Nicholas Ellul
51cad751de Add improved downloading logic when exporting state logs (#19872)
* Add improved downloading logic when exporting state logs

* Make test for state logs download only apply to firefox

* Remove eslint override

* Add file extension to test

* Move make jest global.Blob accessible to window
2023-07-27 15:45:51 -02:30
David Walsh
5db22ceb84 UX: Ensure currently selected account displays when Account Menu opens (#20166)
* UX: Ensure currently selected account displays when Account Menu opens

* Jest tests
2023-07-26 21:06:46 -02:30
David Walsh
41bab4a6e1 UX: Show Checksum Addresses in Account Menu 2023-07-26 17:42:54 -02:30
David Walsh
f14a0ddb94 UX: Ensure block explorer link is for desired account (#20144) 2023-07-26 17:42:47 -02:30
David Walsh
78a0587c97 Fix #20006 - Add Address Details and View on Explorer to Global Menu (#20013)
* Fix #20006 - Add Address Details and View on Explorer to Global Menu

* Fix tests
2023-07-26 17:42:34 -02:30
Dan J Miller
d8c49d9a99 v10.34.2 2023-07-26 17:32:27 -02:30
Dan J Miller
ddac73b5ce
Merge pull request #20175 from MetaMask/Version-v10.34.1
Version v10.34.1 RC
2023-07-26 01:29:33 -02:30
Dan J Miller
9ee7459d0f Update yarn.lock for v10.34.1, which updated sentry/cli -> node-fetch dep version, but doesn't include b7da0a9 2023-07-25 23:55:20 -02:30
Dan J Miller
40314a84c9 Update changelog for v10.34.1 2023-07-25 23:55:12 -02:30
Dan J Miller
b1fb8204f3 Migration 89: ensure providerConfig in state has an id property (#20181)
* Migration 89: ensure providerConfig in state has an id property

* Exit transformState function early if providerConfig already has an id

* Update migrations/index.js

* Code cleanup
2023-07-25 21:18:40 -02:30
Dan J Miller
374656a3d1 Fix sentry sourcemaps (#20122)
* Update sentry/cli to 2.19.4

* Ensure sentry files are loaded and referenced with a valid url

* Temp to eliminate errors in sentry (should be split into other PRs)
2023-07-25 18:03:42 -02:30
Mark Stacey
fbae250b0a Fix invalid state persistence error (#20080)
* Fix invalid state persistence error

We have been seeing Sentry errors showing that state persistence has
been failing for some users that have invalid `NetworkController`
state. This has been fixed by updating to
`@metamask/base-controller@v3.2.0`, which is more tolerant of
unexpected state properties.

* Update LavaMoat policies

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-25 18:02:54 -02:30
Mark Stacey
f01e8379fa v10.34.1 2023-07-18 16:50:03 -02:30
Dan J Miller
839543c5db
Merge pull request #19848 from MetaMask/Version-v10.34.0
Version v10.34.0 RC
2023-07-14 15:06:12 -02:30
Dan J Miller
c25d47952e Remove failing audit exclusion for GHSA-h755-8qp9-cq85 2023-07-14 09:35:58 -02:30
Elliot Winkler
65946c47c4 Restore support for Linea networks (#20011)
When the NetworkController in this repo was replaced with
`@metamask/network-controller`, support for Linea networks was lost
as it did not support it at that time. `@metamask/network-controller`
has since been updated, so this commit bumps that package to restore
support.
2023-07-14 09:35:58 -02:30
Mark Stacey
ccc4cf1bb9 Resolve two new security advisories (#19940)
Two new security advisories have been resolved. These advisories are
causing CI to fail on `develop`. Neither presents any risk to us,
as they are prototype pollution issues that are prevented by lockdown.

The first advisory isn't easy for us to patch. It's caused by an
outdated version of `protobufjs` used by `@trezor/transport`. It has
been ignored for now, until Trezor updates that package.

For the second advisory (related to `tough-cookie`), it was resolved
by updating that dependency in our lockfile.
2023-07-14 09:35:58 -02:30
Elliot Winkler
c9d2e61400 Bump @metamask/network-controller to 10.3.0 (#19903)
In the new version of NetworkController, it will now precreate network
clients for built-in and custom networks and expose those network
clients for consumers. This furthers the multichain UX project by making
it possible for MetaMask to interface with multiple networks
simultaneously.

This commit also upgrades `@metamask/gas-fee-controller` to prevent a
peer dependency warning from showing up as well as
`@metamask/controller-utils` in order to reduce the dependency tree.
There are no user-facing changes to either package.
2023-07-14 09:35:51 -02:30
David Walsh
6c04d76502 Fix #19941 - Correctly show network name and selection when chainIds collide (#19947) 2023-07-14 05:54:02 -02:30
Nidhi Kumari
710101991c fixed button in wallet-overview (#19920)
* fixed button in wallet-overview

* lint fix

* updated selector css with class
2023-07-14 05:54:02 -02:30
Dan J Miller
3c981d78d5
Update changelog for v10.34.0 (#20002) 2023-07-13 15:15:53 -02:30
David Walsh
fac889c111 Fix #19548 - Increase address copy to clipboard time (#19948) 2023-07-13 15:11:27 -02:30
Mark Stacey
88c433cd09 Prevent controller events from crashing (#19963)
* Prevent controller events from crashing

The package `@metamask/base-controller` has been updated to v3.1, which
includes a change to how event subscriber errors are handled. Errors
thrown in event subscribers will no longer interrupt event publishing.

Subscriber errors are caught and thrown in a timeout handler, ensuring
that they are logged and captured by Sentry. We can find any subscriber
errors by looking at the background console, or at the Sentry
dashboard.

Fixes #19801

* Update LavaMoat policies

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-13 15:09:41 -02:30
Dan J Miller
f145331665 Fix memory based performance problem caused by use of lodash memoize in box component (#19993) 2023-07-13 15:03:01 -02:30
Dan J Miller
5529c5963e Merge branch 'master' into Version-v10.34.0 2023-07-13 14:05:19 -02:30
Monte Lai
f4305adb9e fix: fetch for snap registry (#19866) 2023-07-10 13:54:52 -02:30
Matthew Walsh
ec7c64d4fc Provide missing history property (#19896) 2023-07-10 13:54:52 -02:30
George Weiler
96f2ab4dae feat: adds linea mainnet buyable support in anticipation of July 11 launch (#19854)
* feat: adds linea mainnet support in anticipation of July 11 launch

* chore: fixes linting issue

* chore: adds comma for linting

---------

Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-07-10 13:54:34 -02:30
Dan J Miller
e72f829cde
Merge pull request #19910 from MetaMask/Version-v10.33.1
Version v10.33.1 RC
2023-07-07 16:37:57 -02:30
Dan J Miller
5f6a61bec5 Update lavamoat for v10.33.1 2023-07-07 15:58:18 -02:30
Matthew Walsh
779609de8d Patch signature controller to catch message promise (#19927) 2023-07-07 14:01:00 -02:30
Matthew Walsh
f31702653e Provide missing history property (#19896) 2023-07-07 14:01:00 -02:30
Dan J Miller
9187f32178 Version v10.33.1 2023-07-07 14:01:00 -02:30
Matthew Walsh
3a42b01153 Fix infinite spinner when signing typed messages (#19894)
* Use fixed message-manager

* Remove resolution

* Dedupe

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-07-07 06:16:37 -02:30
OGPoyraz
64cbe1f2f8 Accept SignController approval request from frontend (#19184) 2023-07-07 06:16:37 -02:30
Nicholas Ellul
524ab017c7 Add edge case handling for tx utilities (#19907) 2023-07-07 06:16:37 -02:30
Dan J Miller
1c8b4bb27a Version v10.34.0 2023-06-30 12:44:27 -02:30
Dan J Miller
6bde562b73
Merge pull request #19841 from MetaMask/master-sync
Master sync following v10.33.0
2023-06-30 12:31:54 -02:30
Albert Olivé
9e5eada190
Added code fences to updateExtensionUninstallUrl (#19845) 2023-06-30 16:27:16 +02:00
Albert Olivé
7c7b5fe3aa
[MMI] Added custom title for institutional (#19844)
* Added custom title for institutional

* passing prop isMMI to notification view
2023-06-30 15:53:55 +02:00
Albert Olivé
17c5964735
[MMI] Removed institutional portfolio dashboard (#19842)
* Removed institutional portfolio dashboard

* Fixed eslint

* Removed unused key
2023-06-30 15:19:59 +02:00
weizman
a3f811957e
fix: skip snow usage for MV3 test build (#19827)
* try fix

* fix lint for app-init.js

* fix lint for use-snow.js

* remove comment in app-init.js

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-06-30 13:22:07 +01:00
Albert Olivé
5545e5e581
Added code fence to remove backup notice (#19840) 2023-06-30 14:03:47 +02:00
Dan J Miller
865f9eeff8 Merge branch 'develop' into master-sync 2023-06-30 09:03:40 -02:30