1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Commit Graph

4674 Commits

Author SHA1 Message Date
Alex Donesky
13c2614b0d Use higher gasfees when attempting to speedup or cancel a transaction () 2021-08-25 17:02:01 -07:00
ryanml
d1d6eac49c Temporarily Disabling Mobile Sync () 2021-08-25 11:56:23 -07:00
ryanml
9d6fee3c07 Updating decimal precision to 9 (getRoundedGasPrice) () 2021-08-25 11:55:46 -07:00
Dan J Miller
f6cd702f1b Dont default gas limit in gas popover when non is available on transaction params ()
* Dont default gas limit when non is available on transaction params

* Fix unit tests
2021-08-18 02:57:41 -07:00
ryanml
1a01172d93 Fix content cutoff issue (Mobile Sync View () 2021-08-18 02:19:42 -07:00
Dan Finlay
87d8598441 Increase saliency of mobile sync warning ()
* Increase warning saliency of qr sync

* Remove duplciate locale entries

* Revise wording per Antonela feedback

* Avoid all caps

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
2021-08-17 18:21:01 -07:00
Dan J Miller
17ae98ac39 Allow submission of transactions with dapp suggested gas fees, while estimates are loading ()
* Allow submission of transactions with dapp suggested gas fees, while estimates are loading

* Allow editing of transactions with dapp suggested feeds, while estimates are still loading

* Ensure that advanced gas is always editible inline when gas is loading

* Ensure that insufficient balance error is shown when gas is loading if the user has customized the gas

* Only set gas price insufficient errors if the current network is non-eip-1559, or the txparams actually have a gas price

* Remove unnecessary param

* lint fix

* ensure insufficient balance warning is showing when loading

* Ensure that eip1559 network transactions do not combined eip1559 and non-eip1559 gas fee properties

* Lint fix
2021-08-17 13:11:07 -07:00
Dan J Miller
da42d60df1 Allow advanced inline gas editing when there is an estimates unavailable error () 2021-08-17 13:09:25 -07:00
Dan J Miller
805859af4d Improve flashing behaviour for loading gas estimates (on confirm screen) ()
* Improve flashing behaviour for loading gas estimates

* Fix typo

* renderHeartBeatIfInTest
2021-08-16 18:00:11 -07:00
Dan J Miller
b6086ebc17 Allow editing custom gas while estimate is loading () 2021-08-16 18:00:00 -07:00
Alex Donesky
4da940fdd4 Add low/medium/high gas recommendations to the speedup/cancel gas popovers () 2021-08-16 17:57:09 -07:00
ryanml
b7bab56a04 Return an empty string when date is not provided [Date display utils] () 2021-08-16 17:56:56 -07:00
Daniel
f5f923d208 Fix Insufficient number of substitutions for key "swapYourTokenBalance" ()
* Fix Insufficient number of substitutions for key "swapYourTokenBalance"

* Use an empty string if there is no default symbol

* Add ? after SWAPS_CHAINID_DEFAULT_TOKEN_MAP[chainId]
2021-08-16 17:56:45 -07:00
David Walsh
a0d8894989 Remove unwanted console.log from codebase () 2021-08-16 17:56:33 -07:00
Dan J Miller
de388a7b1c Ensure transaction activity log supports EIP-1559 ()
* Ensure transaction activity log supports EIP-1559

* unit test fix

* Add estimated base fee to swaps txMeta

* fix lint and tests

* Improve activity log copy
2021-08-06 19:49:33 -02:30
Alex Donesky
9566cd09c0 Hide gasTiming on edit-gas-popover when form is in error ()
* Hide gasTiming on edit-gas-popover when form is in error

* Show unknown processing error if maxFeePerGas is too low for network conditions

* remove unnecessary change

* remove unnecessary function wrapper
2021-08-06 19:30:11 -02:30
Dan J Miller
738d2722c5 Fixes updates on the confirm screen. ()
* Fixes updates on the confirm screen.

* Better handling of internal send transactions

* maxFee -> maxFeePerGas property name fix

* Remove redundant setEstimateToUse call in onManualChange

* Fix unit tests

* rebase error fix

* Fixes to speedup loading and transaction breakdown priority fee

* Fix lint and unit tests

* Ensure gas price based transaction that have been customized (e.g. speed up and retry) are properly initialized in useGasFeeInputs

* Clean up

* Link fix
2021-08-06 19:30:10 -02:30
David Walsh
39e5750981 EIP-1559 - Ensure form always displays when there are errors () 2021-08-06 01:45:53 -02:30
Alex Donesky
2089767d96 fix confirm transaction details to match spec () 2021-08-06 01:45:53 -02:30
David Walsh
0377e2c64e Restore heartbeat to transaction confirmation, use isGasEstimatesLoading more broadly () 2021-08-06 01:45:53 -02:30
Alex Donesky
99fecbf6d2 Separate out non blocking gas errors () 2021-08-06 01:45:53 -02:30
Alex Donesky
f3995b72b0 Add fee level education button to swaps edit gas popover () 2021-08-06 01:45:53 -02:30
David Walsh
df6c05eb17 Fix NumericInput proptype error () 2021-08-06 01:45:53 -02:30
Dan J Miller
c2bfa57981 Allow max fee to be equal to max priority fee () 2021-08-05 14:23:50 -02:30
Dan J Miller
48bfd6c7f6 Use bignumber for number comparisons in useGasFeeInput ()
* Use bignumber for number comparisons in useGasFeeInput

* fix
2021-08-05 14:23:49 -02:30
Dan J Miller
825e8b7bbf Ensure that gas fee inputs fallback to tx params values if api is down ()
* Ensure that gas fee inputs fallback to tx params values if down

* ensure getGasFeeEstimate fallback is a string
2021-08-05 10:49:24 -02:30
Dan J Miller
aa0f35a8ba Ensure that gas fee minimum errors show when api is down ()
* Fix legacy unapproved tx handling

* clean up
2021-08-04 20:24:40 -02:30
Dan J Miller
7384aea541 Fix legacy unapproved tx handling () 2021-08-04 20:24:40 -02:30
Alex Donesky
ab1cd1152e tiny lost code change from 9.8.4 RC () 2021-08-04 20:24:40 -02:30
David Walsh
efed7c2980 EIP-1559 - Fix mislabeled MaxPriority fee key () 2021-08-04 20:24:40 -02:30
Alex Donesky
02c0cbede9 Stop GasFeeController polling when pop closes ()
* Stop GasFeeController polling when pop closes

* Stop estimate gas polling on window unload

* lint + comments

* Improve client closed logic

* lint

* Add back _beforeUnload on unmount in gas-modal-page-container

* Add full check and call onClientClosed method for notifcation environment

* Add gas pollingToken tracking to appStateController and use to disconnect polling for each environment type

* remove unused method

* move controller manipulation logic from background.js to metamask-controller, disaggregate methods

* add beforeunload handling to reset gas polling tokens from root of send page

* cleanup, lint and address feedback

* clear appState gasPollingTokens when all instances of all env types are closed, fix pollingTokenType arg from onEnvironmentTypeClosed call in metamask-controller

* mock new methods to fix tests

* final bit of cleanup + comments

Co-authored-by: Dan Miller <danjm.com@gmail.com>
2021-08-04 20:24:40 -02:30
David Walsh
1f578fcb1b Provide pointer cursor for radio group buttons () 2021-08-04 20:24:40 -02:30
Dan J Miller
e1efc7170c Show advanced options, and hide radio buttons, for advanced gas settings users ()
* Show advanced options, and hide radio buttons, for users with advanced gas settings turned on

* Improve naming and copy

* lint fix

* Lint fix
2021-08-04 20:24:40 -02:30
David Walsh
5d7eba2684 EIP-1559 - Prevent uncaught exception when passing fees to getGasFeeTimeEstimate () 2021-08-04 20:24:40 -02:30
David Walsh
179f368ae5 EIP-1559 - Temporarily remove the loading heartbeat from the transaction detail () 2021-08-04 20:24:40 -02:30
David Walsh
f17514489f EIP-1559 - Remove unncessary props from AdvancedFormControls () 2021-08-04 20:24:40 -02:30
Dan J Miller
b9d5c431c1 Ensure gas fees update in popover on poll for new values () 2021-08-04 20:24:40 -02:30
Alex Donesky
0dcdbdd99e remove unnecessary conversion call ()
* remove unnecessary conversion call

* Pass args to GasTiming as decGwei

* lint
2021-08-04 13:54:15 -02:30
ryanml
0eef0d424d Fixing errors in EditGasDisplay () 2021-08-04 13:54:15 -02:30
Dan J Miller
8f50afb0dc Allow max priority fee to be below 1, and only require it to be greater than 0 () 2021-08-04 13:54:15 -02:30
Dan J Miller
8a31aaadcb Allows users to set a max priority fee below suggested, just showing a warning in that case () 2021-08-04 13:54:15 -02:30
Dan J Miller
17a4b5224a Rename effective gas price field to total gas fee () 2021-08-04 13:54:15 -02:30
Alex Donesky
ce88b87860 Remove estimate detail above advanced gas controls in non-1559 network ()
* Remove estimate detail above advanced gas controls in non-1559 network

* lint

* remove gasEstimate localization text
2021-08-03 22:13:09 -02:30
ryanml
3c0846df84 Fall back to aggregator name when icon is unavailable (Swaps Load View) () 2021-08-03 22:13:09 -02:30
David Walsh
c4c1504e09 EIP-1559 - Show minium native currency in banner when on testnets () 2021-08-03 22:13:09 -02:30
Daniel
474d7571b6 Fix a position of a tooltip icon () 2021-08-03 14:01:25 -02:30
Alex Donesky
340c3d2876 Add gasPrice to be used on non-1559 networks for transaction details on confirm screen () 2021-08-03 14:01:25 -02:30
David Walsh
29072a0cf0 EIP-1559 - Provide better validation for gas price and gas limit () 2021-08-03 14:01:25 -02:30
Dan J Miller
ac32efd814 Ensure that gas price in popover updates when api provided estimate updates () 2021-08-03 14:01:25 -02:30
David Walsh
ce61eaacdf EIP-1559 - Ensure transaction detail font-size and icon colors are consistent with Figma design () 2021-08-03 14:01:25 -02:30