1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00
Commit Graph

15134 Commits

Author SHA1 Message Date
PeterYinusa
1370f19cba
Portfolio site e2e (#15921)
* add env variables to test build

* add data-testid attribute to home component

* add method to retrieve the url of the current page

* add portfolio site test

Co-authored-by: ryanml <ryanlanese@gmail.com>
2022-09-22 08:39:34 +01:00
ryanml
2623fedd16
Using NETWORK_TYPES constants where applicable (Refactor) (#15930) 2022-09-21 13:10:34 -07:00
Thomas Huang
da0e2f92b9
Continue converting tests from enzyme to @testing-library/react. (#15770)
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-09-21 11:38:35 -05:00
Dan J Miller
12c0a8d1d5
Fix display of edit button on confirm screen when sending tx with data to contract (#15812) 2022-09-21 11:22:36 -05:00
Filip Sekulic
2ba6e68c8b
NFT Approval and SetApprovalForAll confirmation screens header updated (#15727)
* Updated header for NFT approval and Set approval for all screens
2022-09-21 09:15:34 -05:00
Mark Stacey
6d9355c6bd
Merge pull request #15908 from MetaMask/master-sync
Sync `master` with `develop`
2022-09-20 22:23:54 -04:00
ryanml
10915d39ea Merge remote-tracking branch 'origin/develop' into master-sync 2022-09-20 13:27:30 -07:00
ryanml
d98c094283
Fixing PR display links in the changelog (#15883) 2022-09-20 12:42:37 -07:00
Dan J Miller
0278de708d
Merge pull request #15746 from MetaMask/Version-v10.19.0
Version v10.19.0
2022-09-20 16:48:50 -02:30
ryanml
e422c6b09b
Show correct base asset in Decrypt Request view (#15885) 2022-09-20 11:33:45 -07:00
ryanml
1dba5d2139 Fixing ENS input styling for confusable chars (#15893) 2022-09-20 10:21:23 -07:00
George Marshall
e69e207b7d
Adding Icon component and removing BaseIcon component (#15772)
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-09-20 12:15:14 -05:00
ryanml
abfa990aa4
Fixing ENS input styling for confusable chars (#15893) 2022-09-20 12:14:58 -05:00
Guillaume Roux
c9dc59ea2a
[FLASK] Snaps Insight (#15814)
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
2022-09-20 19:00:07 +02:00
Christian Engel
8b5630025b
[German] Fix some spelling errors and messages that don't make sense (#15592)
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-09-20 11:11:03 -05:00
Frederik Bolding
d054175b2e
[FLASK] Fix an issue with installing and updating snaps with 0 permissions (#15796)
* Fix an issue with installing snaps with 0 permissions

* Fix some issues

* Fix lint

* Fix code fencing

* UI improvements for no permission use-case

* Fix redirect

* Delay BIP44 test slightly

* Add more delay

* Fix update UI
2022-09-20 14:46:25 +02:00
Dan Miller
b497797b60 Update lavamoat again 2022-09-19 21:34:14 -02:30
Dan Miller
9360239e5d Update lavamoat policy for v10.19.0 RC, after 0402e04 2022-09-19 20:45:11 -02:30
Niranjana Binoy
0402e043f8 updating the copy and title on token dettection toggle in advanced settings and notification in import tokens (#15880) 2022-09-19 21:34:00 +01:00
Niranjana Binoy
8fcdea7b56
updating the copy and title on token dettection toggle in advanced settings and notification in import tokens (#15880) 2022-09-19 17:53:21 -02:30
ryanml
51f1e4f238 Bump @metamask/etherscan-link from 2.1.0 to 2.2.0 (#15881) 2022-09-19 21:17:46 +01:00
ryanml
c0065b4c5d
Bump @metamask/etherscan-link from 2.1.0 to 2.2.0 (#15881) 2022-09-19 12:31:45 -07:00
Dan J Miller
341d4de8da Revert "Ensure that 'tokens found in this account' message is only shown when token detection activated (#15823)" (#15879)
This reverts commit b359844dc5.
2022-09-19 19:52:56 +01:00
Dan J Miller
5b917444d4
Revert "Ensure that 'tokens found in this account' message is only shown when token detection activated (#15823)" (#15879)
This reverts commit b359844dc5.
2022-09-19 15:41:48 -02:30
Dan J Miller
1bbeb80dff Ensure the seed phrase reminder is displayed with precedence over the network deprecation warning (#15869)
* Ensure the seed phrase reminder is displayed with precedence over the network deprecation message

* Prevent error when attempting to get balance before account info has been fully sete

* Fix implementation of seedphrase-reminder-display-fix

* Prioritize seed phrase reminder notification over portfolio tooltip, and that tooltip over testnet deprecation
2022-09-19 19:00:50 +01:00
Dan J Miller
e6017ee2a4 Don't display DetectedTokenSelectionPopover if there are no detected tokens (#15877)
* Don't display DetectedTokenSelectionPopover if there are no detected tokens

* adding length greater than 0 check as a 0 is displayed at the end of teh page previously

Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
Co-authored-by: ryanml <ryanlanese@gmail.com>
2022-09-19 19:00:35 +01:00
Dan J Miller
5c41ff0aa1 Ensure New Network Info popup doesn't show when switching to testnets (#15867)
* Ensure New Network Info popup doesn't show when switching to testnets

* Update ui/pages/routes/routes.component.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Fix typo

* Fix isTestNet property name casing

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2022-09-19 19:00:16 +01:00
Dan J Miller
17b7b72886
Ensure the seed phrase reminder is displayed with precedence over the network deprecation warning (#15869)
* Ensure the seed phrase reminder is displayed with precedence over the network deprecation message

* Prevent error when attempting to get balance before account info has been fully sete

* Fix implementation of seedphrase-reminder-display-fix

* Prioritize seed phrase reminder notification over portfolio tooltip, and that tooltip over testnet deprecation
2022-09-19 15:10:30 -02:30
Dan J Miller
d38ba20cca
Don't display DetectedTokenSelectionPopover if there are no detected tokens (#15877)
* Don't display DetectedTokenSelectionPopover if there are no detected tokens

* adding length greater than 0 check as a 0 is displayed at the end of teh page previously

Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
Co-authored-by: ryanml <ryanlanese@gmail.com>
2022-09-19 15:10:05 -02:30
ryanml
c8935c6951
Fixing hex address display bug when editing transaction (#15873) 2022-09-19 09:09:12 -07:00
Dan J Miller
b5049a1736
Ensure New Network Info popup doesn't show when switching to testnets (#15867)
* Ensure New Network Info popup doesn't show when switching to testnets

* Update ui/pages/routes/routes.component.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Fix typo

* Fix isTestNet property name casing

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2022-09-19 13:09:28 -02:30
Dan J Miller
5c970fc0ba Properly configure ethereumjs Common for Sepolia network (#15871) 2022-09-19 16:02:53 +01:00
seaona
9e1cbe2723
Get ether from faucet fix message (#15875)
Co-authored-by: ryanml <ryanlanese@gmail.com>
2022-09-19 17:01:32 +02:00
Nicolas Ferro
1b563188bf
Ability to buy tokens with Coinbase Pay and Transak (#15551)
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Brad Decker <git@braddecker.dev>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-09-19 10:00:57 -05:00
seaona
b88b39f485
10.19.0 Changelog (#15755)
* 10.19.0 Changelog - first draft

* Remove non-changelog PRs

* Cleanup by removing uncategorized commits that should not go to the Changelog

* Re-write commit descriptions

* Re-phrasing more descriptions

* Add missing spaces and fix URLs for gridplus

* Flask description updated for snap_getBip44Entropy

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Flask description updated for snap_getBip32Entropy

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Flask description updated for Dapp triggered Snap updates

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Flask description updated for fix permissions

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

* Move to the proper categories Flask PRs

* Remove Snap package update as has no user-facing changes

* Fix Changelog

* Add space after Unreleased

* Add Swaps fix for redirect to Activity tab

* Last PR entries added

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-09-19 16:53:11 +02:00
Dan J Miller
075a6fb86a
Properly configure ethereumjs Common for Sepolia network (#15871) 2022-09-19 08:17:40 -05:00
Dan J Miller
060fc9453c Correct when setApprovalForAll message is shown (#15863) 2022-09-19 13:06:59 +01:00
seaona
dd660f83ae
Add test insights on circle ci for test-unit job (#15839)
* Test results for jest

* Add jest-junit package for reporting

* Order alphabetically
2022-09-19 13:30:34 +02:00
Dan J Miller
789c06a5b7
Correct when setApprovalForAll message is shown (#15863) 2022-09-16 15:41:31 -05:00
Filip Sekulic
6e13524bcd
Remove related UI code from the app dir (#15384)
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
2022-09-16 14:05:21 -05:00
Jyoti Puri
c2b7690119
Make metrics related actions idempotent (#15737) 2022-09-16 22:34:14 +05:30
Mark Stacey
f465089c2a
Make environment variables higher precedence than config (#15858)
Environment variables are now considered as higher-precedence than
configuration by our build system. This means that if the same value is
set in `.metamaskrc` and in an environment variable, the environment
variable is what will be used. Previously the reverse was true, the
configuration would take precedence.

It is conventional for CLI tools to consider environment variables as
higher precedence than configuration. This makes our build system less
surprising for most people.
2022-09-16 14:28:43 -02:30
Jyoti Puri
441e894e9a
Graph improvements (#15793) 2022-09-16 22:26:36 +05:30
Mark Stacey
db158c242c Fix portfolio URL configuration (#15849)
The portfolio URL added in #15407 was meant to be configurable via
environment variable or the `.metamaskrc` file, but that configuration
was broken. Instead the default value was always used.

That configuration has been fixed. The portfolio URL can be set either
by environment variable or configuration file.
2022-09-16 15:53:13 +01:00
Matthew Epps
dc1b658348 Add entry point for metalabs dapp into metamask home page (#15407)
Co-authored-by: Dan Miller <danjm.com@gmail.com>
2022-09-16 15:52:57 +01:00
PeterYinusa
6bd284a016 Case insensitive modifier for Firefox (#15831)
JSON.parse: unexpected character at line 1 column 1 of the JSON data

JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
2022-09-16 15:52:28 +01:00
Elliot Winkler
d91eabfd16
Add initial provider API tests for Infura client (#15556)
We are working on migrating the extension to a unified network
controller, but before we do so we want to extract some of the existing
pieces, specifically `createInfuraClient` and `createJsonRpcClient`,
which provide the majority of the behavior exhibited within the provider
API that the existing NetworkController exposes. This necessitates that
we understand and test that behavior as a whole.

With that in mind, this commit starts with the Infura-specific network
client and adds some initial functional tests for `createInfuraClient`,
specifically covering three pieces of middleware provided by
`eth-json-rpc-middleware`: `createNetworkAndChainIdMiddleware`,
`createBlockCacheMiddleware`, and `createBlockRefMiddleware`.

These tests exercise logic that originate from multiple different places
and combine in sometimes surprising ways, and as a result, understanding
the nature of the tests can be tricky. I've tried to explain the logic
(both of the implementation and the tests) via comments. Additionally,
debugging why a certain test is failing is not the most fun thing in the
world, so to aid with this, I've added some logging to the underlying
packages used when a request passes through the middleware stack.
Because some middleware change the request being made, or make new
requests altogether, this greatly helps to peel back the curtain, as
failures from Nock do not supply much meaningful information on their
own. This logging is disabled by default, but can be activated by
setting `DEBUG=metamask:*,eth-query DEBUG_COLORS=1` alongside the `jest`
command.

We use this logging by bumping `eth-block-tracker`, and
`eth-json-rpc-middleware`.
2022-09-16 10:48:33 -02:30
Mark Stacey
5bfc2f379d
Fix portfolio URL configuration (#15849)
The portfolio URL added in #15407 was meant to be configurable via
environment variable or the `.metamaskrc` file, but that configuration
was broken. Instead the default value was always used.

That configuration has been fixed. The portfolio URL can be set either
by environment variable or configuration file.
2022-09-16 10:43:59 -02:30
Dan Miller
5f21cbeeff Fix bug introduced when resolving conflict during cherry-pick of 7ffcad3328 2022-09-15 20:42:50 -02:30
Mark Stacey
929a1a0d52
Update eth-json-rpc-infura (#15845)
* Update `eth-json-rpc-infura`

The package `eth-json-rpc-infura@5` has been updated to
`@metamask/eth-json-rpc-infura@7`. This update includes TypeScript
support, and it drops support for older node.js versions. The exports
have also been changed from default to named exports.

See here for a full list of changes: https://github.com/MetaMask/eth-json-rpc-infura/blob/main/CHANGELOG.md#700

* Fix LavaMoat policy issue

The `web3` package used by `@metamask/controllers` unintentionally
overwrites the `XMLHttpRequest` global, which breaks things. This was
fixed by revoking `web3`'s write access to that global using a policy
override.

Previously this policy override was applied to `web3`, but for some
unknown reason, this update caused that override to no longer apply.
2022-09-15 14:41:18 -02:30