1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Commit Graph

17845 Commits

Author SHA1 Message Date
OGPoyraz
e351a6bbe2
fix: minimise public api of tx controller (#20361) 2023-08-03 13:42:44 +02:00
Jyoti Puri
8c46f85764
Confirmation page alerts (#20125) 2023-08-03 16:24:54 +05:30
Nidhi Kumari
03f315e82d
Added e2e test for ipfs toggle (#20360)
* added test for image

* nit fix
2023-08-03 14:52:52 +05:30
Nidhi Kumari
d4e33b0d44
close popover on backgroiund click (#20359) 2023-08-03 10:14:26 +05:30
Victor Thomas
97073e1907
Move "Enable Opensea API" and "NFT Autodetect" into Security & Privacy settings (#20278)
* move opensea api and nft settings to security tab

* DS techdebt; experimental tab

* rerouting the NFT tab enable autodetect to setting

* reverting vscode settings and preferences.js

* Rerouting NFT tab autodetect setting banner link

* resolving settingsRef collision
2023-08-02 18:46:36 -04:00
Ariella Vu
6947133899
Update critical error styles (#20350) 2023-08-03 00:23:00 +02:00
Dan J Miller
8e8bef1f87
Merge pull request #20373 from MetaMask/master-sync
Master sync PR following v10.34.2
2023-08-02 19:11:53 -02:30
Alex Donesky
bf9311555d
bump @metamask/network-controller from v10.3.1 to v11.0.0 (#20367)
* bump @metamask/network-controller from v10.3.0 to v11.0.0

* add lavamoat policy files

* fix

* tweak
2023-08-02 16:22:35 -05:00
Dan J Miller
39edef5136 Merge origin/develop into master-sync 2023-08-02 18:20:46 -02:30
infiniteflower
1099a3763b
Feat/swaps link buy gas (#20241)
* Add link to buy more ETH if insufficient gas

* Fix lint error

* Use native currency per network

* Use localized msg for buy more gas

* Add the word "more"

* Fix smart tx not showing msg

* Pull out not enough balance into own component

* Add story for not enough balance

* Fix btn text not being aligned with rest of text

* Move inline style to class, remove empty classname

* Update ui/pages/swaps/prepare-swap-page/not-enough-balance.stories.tsx

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/swaps/prepare-swap-page/index.scss

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Remove line

* Move BannerAlert back into review-quote and use BannerAlert props

* Remove unused CSS

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-08-02 14:58:12 -04:00
Nidhi Kumari
f91d4fb858
Updated copy change for the IPFS toggle (#20358)
* updated ipfs toggle copy

* removed unused entries
2023-08-02 10:27:32 -07:00
Olusegun Akintayo
ef5d171f54
Whats new blockaid popup (#20071)
* deprecate opensea security alerts check

Signedoff-by: Olusegun Akintayo <akintayo.segun@gmail.com>

set metrics to []

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

fix jest tests

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

Remove sec provider spec

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

lint fix

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

What's new for blockaid...with placeholder texts

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

i18n

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

lint fixes

Rebase to develop
Add image to whatsnew blockaid.

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

Fixed i18n

Fixed snapshot for ui/pages/settings/experimental-tab/experimental-tab.test.js

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

Fix i18n messages

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

lint fixes

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

Add unit tests

Lint fixes

use new image that works for both dark and light mode

22 is taken

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* comment out blockaid

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* rever change in builds.yml

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* reverted changes in test/e2e/tests/security-provider.spec.js

* fix unit test

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

---------

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
2023-08-02 16:14:02 +01:00
Guillaume Roux
36c0dfb1f2
Check for blocked snaps on extension startup (#20336)
* allow `SnapController` to call `SnapsRegistry:update`

* call `SnapController:updateBlockedSnaps` on extension startup

* only check if at least one snap is installed
2023-08-02 15:16:43 +02:00
Nidhi Kumari
ad919026ab
UX Improvement: Fixed tooltip for token-list-item (#20258)
* updated tooltip for token-list-item

* updated snapshot
2023-08-02 15:07:12 +05:30
Ariella Vu
446c7bb3fe
Security Alert Settings: update copy to match figma (#20300)
* securityAlert: fix settings copy

* securityAlert: fix settings copy - update snapshop
2023-08-02 11:29:18 +02:00
Dhruv
484fd1a436
Updating deprecated code and using design system components (#19562) 2023-08-01 21:47:57 -07:00
jainex
023249a944
migration of HeaderBase to use TS Box version (#20250)
* migration of  HeaderBase to use TS Box version

* migration of  HeaderBase to use TS Box version

* update snapshot

* fix lint error

* Some small updates to types and removing deprecated storyook functions

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 17:36:55 -07:00
Dan J Miller
35c6305181
Merge pull request #20217 from MetaMask/Version-v10.34.2
Version v10.34.2
2023-08-01 21:02:31 -02:30
Dan J Miller
fdc22247be
Update CHANGELOG.md
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 20:37:16 -02:30
Dan J Miller
5ed415d807 Fix migration 88 to handle the case where chainId keys can be undefined (#20345)
* Fix migration 88 to handle the case where chainId keys can be undefined

* Add migration 91 to delete network configurations that have no chainId

* Lint fix

* Update migration number

* Update migration 91 description

* Update version numbers in 091.test.js

* Fix 088.test.ts typescript problem

* Fix 088.test.ts typescript problem

* Update app/scripts/migrations/091.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Change app/scripts/migrations/091.test.js to typescript

* clone oldstorage for test result comparisons in 091.test.js

* Lint fix

* Add missing test case

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 20:24:20 -02:30
Dan J Miller
b825ee8e37
Fix migration 88 to handle the case where chainId keys can be undefined (#20345)
* Fix migration 88 to handle the case where chainId keys can be undefined

* Add migration 91 to delete network configurations that have no chainId

* Lint fix

* Update migration number

* Update migration 91 description

* Update version numbers in 091.test.js

* Fix 088.test.ts typescript problem

* Fix 088.test.ts typescript problem

* Update app/scripts/migrations/091.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Change app/scripts/migrations/091.test.js to typescript

* clone oldstorage for test result comparisons in 091.test.js

* Lint fix

* Add missing test case

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 20:24:02 -02:30
Dan J Miller
ab967487da Update changelog 2023-08-01 19:55:43 -02:30
Dan J Miller
75377cf890
Update CHANGELOG.md
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 19:52:18 -02:30
Brad Decker
038eb63eb0
Upgrade to yarn 4 (#20249) 2023-08-01 17:19:19 -05:00
Pritam Dhara
5b5ca4599e
Replaces SEVERITIES const with Severity enum in BannerAlert (#20200)
* Replaces SEVERITIES const with Severity enum in BannerAlert

* Replaced SEVERITIES with Severity in banner-alert.constants.js

* Used BANNER_ALERT_SEVERITIES instead of SEVERITIES in banner-alert.stories.js

* Updated README for usage of Severity instead of SEVERITIES

* Updates to stories and docs link

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:41:30 -07:00
jainex
d879f08763
Update ModalOverlay to use TS Box version (#20203)
* Update ModalOverlay to use TS Box version

* fix jest error

* lint error fix

* Fix lint errors and improve ModalOverlay's TypeScript typings

* Some small updates to story and docs

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:39:08 -07:00
Dhruv
d375dc550d
Part of #18714: Replacing deprecated constants (#19843)
* replacing constants

* updating ButtonLink component

* Updates to responsive typography

* lint fixes

* snapshot updates

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:37:16 -07:00
Pritam Dhara
067d385012
Replaced ActionableMessage Instances in edit-gas (#20196)
* Replaced ActionableMessage Instances in edit-gas

* Updated BannerAlert className

* Changed errorKey to errorMessage

* Removing CSS and restoring local key

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:21:42 -07:00
Dhruv
9b55791af7
fix/migrate AvatarAccount to TS (#20208)
* migrating AvatarAccount to TS

* updates

* reverting changes to diameter

* suggested changes

* adding explicit types for AvatarAccountDiameter

* updating documentation

* Some small updates to types

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-08-01 14:19:32 -07:00
Ashis Kumar Pradhan
512fdcae56
Replaced with new checkbox in ConnectedAccountsPermissions (#20228)
* Replaced with new checkbox in ConnectedAccountsPermissions

* removed a typo

* fixed linting issue

* Small updates to styles

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-08-01 14:17:19 -07:00
Brad Decker
4e083017d6
fix weird lockfile irregularities (#20333)
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-08-01 16:10:52 -05:00
Gauthier Petetin
ee48d8f0b7
Fix/check pr labels (#20353)
* fix(action): default branch is develop, not main

* fix(action): add missing documentation
2023-08-01 18:06:59 -03:00
David Walsh
034626a57d
Fix ipfs-ens-resolution.spec.js E2E intermittent failure (#20311)
* Fix ipfs-ens-resolution.spec.js E2E intermittent failure

* Wait for URL change instead of large delay
2023-08-01 13:26:42 -05:00
Nidhi Kumari
4c37448c97
Added IPFS toggle (#20172)
* added ipfs toggle

* added placeholder valur

* fixed snapshot

* updated tests

* updated spec file

* hide input if toggle is disabled

* updated e2e tests for nft image

* fixed view-ercc-1155 spec

* updated e2e tests for nfts

* added ipfs toggle modal

* updated UI for ipfs

* updated tests

* updated classname

* added placeholder image

* lint fix

* removed prop ipfsEnabled and used with selector

* fixed ui for ipfs toggle

* updated test

* updated  test to handle cases

* nit fix

* ensure default image height match nft image
2023-08-01 23:51:51 +05:30
David Walsh
e27a9e4344
UX: Update Batch Account Setting Description (#20269) 2023-08-01 13:17:58 -05:00
David Walsh
7ca418de1f
UX: Cleanup of NetworkListMenu properties (#20304) 2023-08-01 13:17:48 -05:00
Daniel
24ca518315
Reset price ack if price diff in % changed, insufficient gas event, log a page load event once (#19961) 2023-08-01 18:18:14 +02:00
infiniteflower
10ffc1ec84
Chore/refactor smart swap modal (#20239)
* Add story for smart tx popover

* Use tsx for smart tx popover story and add btn to open it

* Refactor smart tx popover component to tsx and style

* Fix modal not triggering

* Remove bold from bullet points

* Adjust margins
2023-08-01 15:31:53 +02:00
Daniel
2ad2827bab
Redirect to homepage from Swaps asap without waiting for state cleanup (#20236) 2023-08-01 15:28:11 +02:00
Jyoti Puri
4e52fe2494
Adding metrics events for blockaid (#20091) 2023-08-01 16:59:41 +05:30
António Regadas
2b5c112a02
[MMI] swap button redirect when account is Custody (#20234)
* wip

* adds test

* add value to constants

* clean up
2023-08-01 11:17:36 +01:00
António Regadas
c92f3b32b2
hides the CancelSpeedupPopover (#20180) 2023-08-01 11:16:49 +01:00
witmicko
d11ef07ae1
solves 1114 (#20307)
* fixes 207
2023-08-01 07:04:23 +01:00
Thomas Huang
b9f647f478 [skip-e2e] Update changelog for v10.34.2 (#20238) 2023-08-01 00:17:20 -02:30
Mark Stacey
1ed8f99fdf Remove fallback phishing warning configuration (#20327)
* Remove fallback phishing warning configuration

The package `@metamask/phishing-controller` has been updated from v4
v6. The only breaking changes are a minimum Node.js version bump, and
the removal of the fallback phishing configuration.

The fallback phishing configuration was resulting in MetaMask being
incorrectly flagged as malware, and the stale config was causing
problems for sites that had been blocked in the past but have since
been unblocked. This should substantially reduce the bundle size as
well.

* Update LavaMoat policies

* Update test state to include example blocked site

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-08-01 00:17:07 -02:30
Mark Stacey
990dc33fc6
Remove fallback phishing warning configuration (#20327)
* Remove fallback phishing warning configuration

The package `@metamask/phishing-controller` has been updated from v4
v6. The only breaking changes are a minimum Node.js version bump, and
the removal of the fallback phishing configuration.

The fallback phishing configuration was resulting in MetaMask being
incorrectly flagged as malware, and the stale config was causing
problems for sites that had been blocked in the past but have since
been unblocked. This should substantially reduce the bundle size as
well.

* Update LavaMoat policies

* Update test state to include example blocked site

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
2023-07-31 22:26:40 -02:30
Mark Stacey
36b1991b44
Fix prep-deps CI step (#20312)
The CI job `prep-deps` was broken in #20096 for forks and non-PR builds
(e.g. the `develop` branch builds). Non-PR builds were broken because
of the `set -u` flag, which complained about a PR-specific environment
variable being unset. Fork builds were broken because the draft check
relied upon secrets (which aren't included in CI runs on forks).

The script is now tolerant of missing environment variables, and skips
the draft check for forks.
2023-07-31 20:36:14 -02:30
Dan J Miller
6f0caf4d3f
Capture Sentry errors prior to initialization (#20265) (#20330)
* Capture Sentry errors prior to initialization

Sentry errors captured before/during the wallet initialization are
currently not captured because we don't have the controller state yet
to determine whether the user has consented.

The Sentry setup has been updated to check the persisted state for
whether the user has consented, as a fallback in case the controller
state hasn't been initialized yet. This ensures that we capture errors
during initialization if the user has opted in.

* Always await async check for whether the user has opted in

* Remove unused import

* Update JSDoc return type

* Remove unused driver method

* Fix metametrics controller unit tests

* Fix e2e tests

* Fix e2e test on Firefox

* Start session upon install rather than toggle

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 20:35:50 -02:30
Dan J Miller
d09f375b2c Fix migration 77 (#20276)
* Handle the case where tokensChainsCache data is undefined in migration 77

* Delete parts of state that should have been removed in migrations 82,84,86 and 88

* Create 077-supplements.md

* Update 077-supplements.md

* Update 077-supplements/*.js code comments

* Fix types and jsdoc

* Type/lint fix

* Cleanup

* Add 'should set data to an empty object if it is null' test case to 077.test.js

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Modify deletion criteria so that all decimal chain id proprties are deleted in migration 88 supplement

* Readme.md

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Lint fix

* Only delete decimal chain id keyed-entries in migration 88 supplement if there are hexadecimal keyed entries as well

* Remove redundant test

* Add 'does not delete' cases for nftcontroller related tests in 077.test.js

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 20:01:15 -02:30
Dan J Miller
3b0d37c3bf
Fix migration 77 (#20276)
* Handle the case where tokensChainsCache data is undefined in migration 77

* Delete parts of state that should have been removed in migrations 82,84,86 and 88

* Create 077-supplements.md

* Update 077-supplements.md

* Update 077-supplements/*.js code comments

* Fix types and jsdoc

* Type/lint fix

* Cleanup

* Add 'should set data to an empty object if it is null' test case to 077.test.js

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Modify deletion criteria so that all decimal chain id proprties are deleted in migration 88 supplement

* Readme.md

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update app/scripts/migrations/077.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Lint fix

* Only delete decimal chain id keyed-entries in migration 88 supplement if there are hexadecimal keyed entries as well

* Remove redundant test

* Add 'does not delete' cases for nftcontroller related tests in 077.test.js

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-07-31 19:43:51 -02:30