Elliot Winkler
05fb01802d
Re-enable tests for subscription-based RPC methods ( #18994 )
...
NetworkController doesn't handle `eth_subscribe` or `eth_unsubscribe`
specially, but as it's supported by Infura, we want to make sure we
exercise these RPC methods in the network client tests, even if it is
just to ensure that they get passed through to the network.
We had tests for these RPC methods, but they were commented out in
c095b1accdbd23a49013
2023-05-10 09:34:10 -02:30
legobeat
23b8b15e5c
builds.yml: add env var EDITOR_URL ( #19074 )
2023-05-10 19:33:57 +09:00
Vinicius Stevam
df3db6e559
Adopt ApprovalType from core ( #18567 )
2023-05-10 06:36:01 +01:00
Harsh Shukla
e991439718
Part of #17670 & #18714 : Replace Typography with Text component in token-details-page.js ( #18741 )
...
* Worked on issue #17670 & #18714 in file token-details-page.js in file
* Worked on issue #17670 & #18714 in file token-details-page.js in file
* Update token-details-page.js
2023-05-09 17:55:30 -07:00
Dhruv
490e0770c7
Changes to edit-gas-display.component.js ( #19037 )
...
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-09 17:52:16 -07:00
George Marshall
32688c2e3c
Adding ModalFocus component ( #18979 )
2023-05-09 14:33:29 -07:00
George Marshall
62ffd8022a
Some style, accessibility and sematic html updates to modal sub components ( #19034 )
2023-05-09 14:09:10 -07:00
Olaf Tomalka
a1ff530430
Made builds.yml variable errors more helpful ( #19066 )
2023-05-09 21:47:42 +02:00
Pedro Figueiredo
6e180af313
remove pre commit hook for branch names ( #19077 )
...
* remove pre commit hook for branch names
* bail with ticket number 0 detected
2023-05-09 20:39:38 +01:00
Mark Stacey
9847179f54
Set network status to "unknown" when ID is invalid ( #19068 )
...
We now set the network status to "unknown" rather than "unavailable"
when the network ID is invalid. This better reflects what we know when
this happens, and it makes the network controller better aligned with
the core network controller.
This was accomplished by using a regular error for the network ID
assertion rather than using `assert` directly. `assert` would throw an
error with a `code` property, which resutled in us treating it like an
RPC error.
This isn't tested, but it was found in the course of porting unit tests
from core to extension. It will be covered by these tests, which will
be added in the next PR.
This change should have no functional impact because we treat these two
network statuses as equivalent. The distinction between unknown and
unavailable is useful only for debugging.
2023-05-09 15:44:14 -02:30
Nidhi Kumari
6535e34943
Replaced all fa-icon-circle with INFO icon ( #17539 )
...
* replace all fa-icon-circle with INFO icon
* updated classnames
* updated classnames
* updated snapshots
* updated colors
* resolved errors
* fixed relative import
* fixed lint errors
* added story for alerts tab
* update snapshot
* updated info-circle
* updated enum for iconName
* removed classnames
* updated iconName in settings
* fixed lint errors and snapshots
2023-05-09 23:04:58 +05:30
Nidhi Kumari
cde449925b
UX Multichain: updated margin top for assets tab ( #19071 )
...
* updated margin top for assets tab
* remove changes from yml file
* remove changes from yml file
2023-05-09 11:32:56 -05:00
Dominik Rudzki
4cb3284136
Fix popover scroll button WhatsNewPopup hiding ( #19017 )
...
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-05-09 11:32:29 -05:00
David Walsh
09b113e0df
Fix #19060 - Ensure there's multiple accounts before focusing search ( #19062 )
2023-05-09 07:38:36 -05:00
David Walsh
124678e701
Fix #19059 - Show network picker when locked ( #19063 )
2023-05-09 01:06:54 -07:00
David Walsh
ecea162b10
UX: Multichain: Update deprecated variables ( #19058 )
2023-05-09 01:05:47 -07:00
David Walsh
b981377304
UX: Multichain: Disable network and account picker when necessary ( #18909 )
2023-05-08 12:32:39 -05:00
Dhruv
c4e7b5532d
Changes to custody-labels.js ( #19038 )
2023-05-08 12:28:46 -05:00
legobeat
37b481f305
devDeps: react-devtools@4.16.0->4.27.6 ( #18869 )
2023-05-09 00:11:36 +09:00
David Walsh
995887aa92
UX: Multichain: Ensure network picker renders properly for long and short names ( #18974 )
...
* UX: Multichain: Ensure network picker renders properly for long and short network names
* Updatte ui/components/multichain/app-header/app-header.js
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/multichain/app-header/app-header.js
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/multichain/app-header/app-header.js
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/multichain/app-header/app-header.js
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/multichain/app-header/app-header.js
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/multichain/app-header/app-header.scss
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Update ui/components/multichain/app-header/app-header.scss
Co-authored-by: George Marshall <george.marshall@consensys.net>
* Fix jest issue
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-05-08 09:50:13 -05:00
David Walsh
90630edef7
Fix #18916 - UX: Multichain: Network picker design updates ( #18962 )
...
* Remove border radius from network menu list
* Provide background color for test network avatars
* Make button size large
* Update ui/components/multichain/network-list-item/network-list-item.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Fix lint
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-05-08 09:50:04 -05:00
Harsh Shukla
4ad281c806
Part of #17670 & #18714 : Replace Typography with Text component: nft-details.js ( #18771 )
...
* Update nft-details.js
* Update nft-details.test.js.snap
* Update nft-details.js
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update nft-details.test.js.snap
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-05-08 19:52:33 +05:30
António Regadas
7ebd561ff9
[MMI] adds mmi logic in home view ( #18960 )
...
* adds mmi logic to home container
* adds code fences to home component
* adds code fences to home component
* lint fix
* lint fix
* updates fences and runs prettier
* version bump
* clean up code fence
2023-05-08 15:09:00 +01:00
David Walsh
a5494fc637
UX: Multichain: Account Details Fixes ( #18999 )
...
* Fix account details editable label
* Fix font-weight of the password label
* Remove duplicate error
* Hide password warning on first screen after bad password, autofocus password field
* Fix jest failure
* Restore className
2023-05-08 09:03:34 -05:00
Harsh Shukla
dd04913e7e
Working on some lint issues in 2 files. ( #18633 )
...
* Addressed some lint issues.
* Worked on the mentioned lint issue.
* Worked on the CRLF lint issues.
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-05-08 08:55:25 -05:00
legobeat
1c199d3223
devDeps: storybook-dark-mode@1.1.2->2.1.1 ( #18866 )
...
* devDeps: @storybook/*->6.5.16
* devDeps: storybook-dark-mode@1.1.2->2.1.1
* add lavamoat build policy override
2023-05-08 22:48:29 +09:00
Nidhi Kumari
e8dd6a6ff1
UX Multichain: Added extra margin for native token ( #18988 )
...
* added extra margin for native token
* fixed lint errors
* added marginTop via css
* updated test
* added boxprops and margin bottom for tab component
* updated snapshot
* update asset list component
2023-05-08 19:17:45 +05:30
Dhruv
50f2d06223
Changes to confirm-data and confirm-hexdata ( #19041 )
2023-05-08 08:36:40 -05:00
Harsh Shukla
46f717feef
Update slider.component.js ( #19035 )
2023-05-08 08:34:24 -05:00
Vinicius Stevam
da8cb0bbc0
Fix fail to reject multiple approval requests ( #19050 )
2023-05-08 11:09:46 +01:00
Pedro Figueiredo
8df3bc9c1b
Label PRs based on the labels of the associated issue ( #17603 )
...
* Implement CI to copy issue labels over to PRs
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* clean up
* clean up
2023-05-08 09:51:02 +01:00
Monte Lai
0306422bbf
Add reveal to export private key ( #18170 )
...
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: Howard Braham <howrad@gmail.com>
* change js to tsx
* update to typescript
* add labels to circle animation
* add willHide prop to hold to reveal modal
* add test
* convert to design system
* fix lint
* fix type
* bump coverage
* rename
* remove comments
* remove ts comment and add fix exhuastive dep check
* update coverage
* add hide modal test
* use banneralert
* update label
* remove unused
* fix text
* update aria label messages
* change exportAccountAndGetPrivateKey to be async
* fix lint
* update coverage target
* update coverage
* update input component
* update coverage
* update coverage
* fix blank line
* use &&
* move plainKey to under !privateKeyInput
* update hold modal to display srp and private key message
* fix styling
* fix lint and test
* fix unused locales
* remove redundent check
* update storybook
* fix text alignment
* fix lint
* update snapshot
* fix test
* update coverage
* fix merge conflict
* refactor
* fix variant
* update snapshot
* fix test after merge
* fix test after merge conflict
* fix label text
* update to use label component
2023-05-06 17:04:20 -04:00
Olaf Tomalka
82f01a6b44
Fix build types not overriding the manifest ( #19027 )
2023-05-05 18:40:43 +02:00
Brad Decker
b60b9f441f
Bundle size reduction: Upgrading ethereumjs/tx and ethereumjs/common ( #18302 )
...
* upgrade ethereumjs/tx and deps
* Yarn dedupe
---------
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-05-05 10:55:41 -05:00
Dan J Miller
828fd35575
Merge pull request #19026 from MetaMask/master-sync
...
Master sync PR following v10.30.0 and v10.30.1
2023-05-05 11:57:21 -02:30
David Walsh
67dbac6b0d
Fix #18984 - UX: Multichain - Network connection fixes ( #19000 )
2023-05-05 09:02:28 -05:00
Albert Olivé
33f9d6f480
[MMI] Applied code fencing in transactions and pending tx tracker controllers ( #17909 )
...
* Applied code fencing in trabsactions and pending tx tracker controllers
* remove unneeded URL from the comment
* Added test
* Added useful comment
* Fixing code fences
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-05 15:58:40 +02:00
Danica Shen
395ac34bed
chore: refactor connect to dapp action in e2e ( #19015 )
...
* chore: refactor connect to dapp action in e2e
* chore: refactor 2nd dapp connection
* chore: rename to openDapp
2023-05-05 14:56:08 +01:00
Dhruv
69132e7785
Part of #18714 : Replacing Typography consts with enums ( #19013 )
...
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-05-05 13:17:22 +01:00
Albert Olivé
319696b4ef
[MMI] Added compliance details modal and compliance details component ( #18118 )
...
* Added compliance details modal and compliance details component
* Finished component
* Fixed test name
2023-05-05 14:07:51 +02:00
Matthew Walsh
f62d8fce61
Use core signature controller ( #18654 )
2023-05-05 13:05:52 +01:00
Dan Miller
1a55a7e4d1
Merge branch 'develop' into master-sync
2023-05-05 09:32:50 -02:30
Dan J Miller
409759da07
Merge pull request #19022 from MetaMask/Version-v10.30.1
...
Version v10.30.1 RC
2023-05-05 09:19:33 -02:30
Harsh Shukla
944d39ed3a
Part of #17670 : Replace Typography with Text component in smart-transaction-status.js ( #18743 )
...
* Update smart-transaction-status.js
* Update smart-transaction-status.js
* Update smart-transaction-status.js again.
* Update smart-transaction-status.js
* Update smart-transaction-status.js
* Update ui/pages/swaps/smart-transaction-status/smart-transaction-status.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update smart-transaction-status.js
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-05-05 12:15:39 +01:00
Harsh Shukla
9fae71505c
Part of #17670 Replace Typography with Text component for 4 files. ( #18793 )
...
* Worked on issue #17670 & #18714 for 4 other files.
* Updated snapshots.
* Update index.test.js.snap
* Update customize-nonce.test.js.snap
* Update signature-request.component.test.js.snap
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-05 12:14:09 +01:00
Harsh Shukla
36c4ff15b2
Update interactive-replacement-token-modal.js ( #19003 )
2023-05-05 12:09:13 +01:00
Dan Miller
18b80df043
Update changelog for v10.30.1
2023-05-05 08:23:24 -02:30
Frederik Bolding
e4e9f3c7ac
[FLASK] Disable RPC test ( #19011 )
...
* Disable RPC test
* Fix lint
2023-05-05 08:21:47 -02:30
MetaMask Bot
e3a7f91095
Version v10.30.1
2023-05-05 08:21:28 -02:30
Albert Olivé
c7bb906b03
[MMI] Added code fencing in account details modal and selected accounts ( #18070 )
...
* Added code fencing in account details modal and selected accounts
* Fixed pipeline issues
* Remove one code fence
2023-05-05 11:28:27 +02:00
