m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Ci test config improvement (#12223)

Browse Source 
* ci - use same resource class for chrome and ff e2e tests

* e2e:chrome - enable logging by default

* lint fix
This commit is contained in:
kumavis 2021-09-27 12:39:31 -10:00 committed by GitHub
parent 506fa2d744
commit d3f7464333
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.circleci/config.yml
View File

@ -391,7 +391,7 @@ jobs:
destination: test-artifacts destination: test-artifacts
test-e2e-firefox: test-e2e-firefox:
executor: node-browsers executor: node-browsers-medium-plus
steps: steps:
- checkout - checkout
- run: - run:

7
test/e2e/webdriver/chrome.js
View File

@ -16,13 +16,10 @@ class ChromeDriver {
.setChromeOptions(options); .setChromeOptions(options);
const service = new chrome.ServiceBuilder(); const service = new chrome.ServiceBuilder();
// Enables Chrome logging. // Enables Chrome logging. Default: enabled
// Especially useful for discovering why Chrome has crashed, but can also // Especially useful for discovering why Chrome has crashed, but can also
// be useful for revealing console errors (from the page or background). // be useful for revealing console errors (from the page or background).
if ( if (process.env.ENABLE_CHROME_LOGGING !== 'false') {
process.env.ENABLE_CHROME_LOGGING &&
process.env.ENABLE_CHROME_LOGGING !== 'false'
) {
service.setStdio('inherit').enableChromeLogging(); service.setStdio('inherit').enableChromeLogging();
} }
if (port) { if (port) {