From d3f7464333ae6aaa50901dc5b9b809e4bd34fa65 Mon Sep 17 00:00:00 2001
From: kumavis <kumavis@users.noreply.github.com>
Date: Mon, 27 Sep 2021 12:39:31 -1000
Subject: [PATCH] Ci test config improvement (#12223)

* ci - use same resource class for chrome and ff e2e tests

* e2e:chrome - enable logging by default

* lint fix
---
 .circleci/config.yml         | 2 +-
 test/e2e/webdriver/chrome.js | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 973ee001a..a2ab03bfc 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -391,7 +391,7 @@ jobs:
           destination: test-artifacts
 
   test-e2e-firefox:
-    executor: node-browsers
+    executor: node-browsers-medium-plus
     steps:
       - checkout
       - run:
diff --git a/test/e2e/webdriver/chrome.js b/test/e2e/webdriver/chrome.js
index bf3c2d023..9a1e1294b 100644
--- a/test/e2e/webdriver/chrome.js
+++ b/test/e2e/webdriver/chrome.js
@@ -16,13 +16,10 @@ class ChromeDriver {
       .setChromeOptions(options);
     const service = new chrome.ServiceBuilder();
 
-    // Enables Chrome logging.
+    // Enables Chrome logging. Default: enabled
     // Especially useful for discovering why Chrome has crashed, but can also
     // be useful for revealing console errors (from the page or background).
-    if (
-      process.env.ENABLE_CHROME_LOGGING &&
-      process.env.ENABLE_CHROME_LOGGING !== 'false'
-    ) {
+    if (process.env.ENABLE_CHROME_LOGGING !== 'false') {
       service.setStdio('inherit').enableChromeLogging();
     }
     if (port) {