m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-30 08:09:15 +01:00
Code

Remove non-existent metaMaskFee property (#9657)

Browse Source 
The `metaMaskFee` property on the "quote data" PropType was not used,
and it never existed in practice. This resulted in PropType errors.

The non-existent property has been removed.
This commit is contained in:
Mark Stacey 2020-10-20 10:35:34 -02:30 committed by GitHub
parent c3fafe311e
commit 97450cd8fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui/app/pages/swaps/select-quote-popover/mock-quote-data.js
View File

@ -7,7 +7,6 @@ const quoteDataRows = [
destinationTokenValue: '100000000000000000000', destinationTokenValue: '100000000000000000000',
isBestQuote: false, isBestQuote: false,
liquiditySource: 'AGG', liquiditySource: 'AGG',
metaMaskFee: '1.00 DAI',
networkFees: '$15.25', networkFees: '$15.25',
quoteSource: 'AGG', quoteSource: 'AGG',
rawNetworkFees: 10.25, rawNetworkFees: 10.25,
@ -24,7 +23,6 @@ const quoteDataRows = [
destinationTokenValue: '101000000000000000000', destinationTokenValue: '101000000000000000000',
isBestQuote: false, isBestQuote: false,
liquiditySource: 'RFQ', liquiditySource: 'RFQ',
metaMaskFee: '1.01 DAI',
networkFees: '$14.26', networkFees: '$14.26',
quoteSource: 'RFQ', quoteSource: 'RFQ',
rawNetworkFees: 10.26, rawNetworkFees: 10.26,
@ -41,7 +39,6 @@ const quoteDataRows = [
destinationTokenValue: '102000000000000000000', destinationTokenValue: '102000000000000000000',
isBestQuote: false, isBestQuote: false,
liquiditySource: 'DEX', liquiditySource: 'DEX',
metaMaskFee: '1.02 DAI',
networkFees: '$13.27', networkFees: '$13.27',
quoteSource: 'DEX', quoteSource: 'DEX',
rawNetworkFees: 10.27, rawNetworkFees: 10.27,
@ -58,7 +55,6 @@ const quoteDataRows = [
destinationTokenValue: '150000000000000000000', destinationTokenValue: '150000000000000000000',
isBestQuote: true, isBestQuote: true,
liquiditySource: 'AGG', liquiditySource: 'AGG',
metaMaskFee: '1.00 DAI',
networkFees: '$12.28', networkFees: '$12.28',
quoteSource: 'AGG', quoteSource: 'AGG',
rawNetworkFees: 10.28, rawNetworkFees: 10.28,
@ -75,7 +71,6 @@ const quoteDataRows = [
destinationTokenValue: '104000000000000000000', destinationTokenValue: '104000000000000000000',
isBestQuote: false, isBestQuote: false,
liquiditySource: 'RFQ', liquiditySource: 'RFQ',
metaMaskFee: '1.04 DAI',
networkFees: '$11.29', networkFees: '$11.29',
quoteSource: 'RFQ', quoteSource: 'RFQ',
rawNetworkFees: 10.29, rawNetworkFees: 10.29,
@ -92,7 +87,6 @@ const quoteDataRows = [
destinationTokenValue: '105000000000000000000', destinationTokenValue: '105000000000000000000',
isBestQuote: false, isBestQuote: false,
liquiditySource: 'DEX', liquiditySource: 'DEX',
metaMaskFee: '1.05 DAI',
networkFees: '$10.30', networkFees: '$10.30',
quoteSource: 'DEX', quoteSource: 'DEX',
rawNetworkFees: 10.30, rawNetworkFees: 10.30,

1
ui/app/pages/swaps/select-quote-popover/select-quote-popover-constants.js
View File

@ -8,7 +8,6 @@ export const QUOTE_DATA_ROWS_PROPTYPES_SHAPE = PropTypes.shape({
destinationTokenValue: PropTypes.string.isRequired, destinationTokenValue: PropTypes.string.isRequired,
isBestQuote: PropTypes.bool, isBestQuote: PropTypes.bool,
liquiditySource: PropTypes.string.isRequired, liquiditySource: PropTypes.string.isRequired,
metaMaskFee: PropTypes.string.isRequired,
networkFees: PropTypes.string.isRequired, networkFees: PropTypes.string.isRequired,
quoteSource: PropTypes.string.isRequired, quoteSource: PropTypes.string.isRequired,
rawNetworkFees: PropTypes.number.isRequired, rawNetworkFees: PropTypes.number.isRequired,