From 97450cd8fd9740392b7a4f0c6173d1392df62147 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Tue, 20 Oct 2020 10:35:34 -0230 Subject: [PATCH] Remove non-existent `metaMaskFee` property (#9657) The `metaMaskFee` property on the "quote data" PropType was not used, and it never existed in practice. This resulted in PropType errors. The non-existent property has been removed. --- ui/app/pages/swaps/select-quote-popover/mock-quote-data.js | 6 ------ .../select-quote-popover/select-quote-popover-constants.js | 1 - 2 files changed, 7 deletions(-) diff --git a/ui/app/pages/swaps/select-quote-popover/mock-quote-data.js b/ui/app/pages/swaps/select-quote-popover/mock-quote-data.js index f85aada1f..1a5462c6c 100644 --- a/ui/app/pages/swaps/select-quote-popover/mock-quote-data.js +++ b/ui/app/pages/swaps/select-quote-popover/mock-quote-data.js @@ -7,7 +7,6 @@ const quoteDataRows = [ destinationTokenValue: '100000000000000000000', isBestQuote: false, liquiditySource: 'AGG', - metaMaskFee: '1.00 DAI', networkFees: '$15.25', quoteSource: 'AGG', rawNetworkFees: 10.25, @@ -24,7 +23,6 @@ const quoteDataRows = [ destinationTokenValue: '101000000000000000000', isBestQuote: false, liquiditySource: 'RFQ', - metaMaskFee: '1.01 DAI', networkFees: '$14.26', quoteSource: 'RFQ', rawNetworkFees: 10.26, @@ -41,7 +39,6 @@ const quoteDataRows = [ destinationTokenValue: '102000000000000000000', isBestQuote: false, liquiditySource: 'DEX', - metaMaskFee: '1.02 DAI', networkFees: '$13.27', quoteSource: 'DEX', rawNetworkFees: 10.27, @@ -58,7 +55,6 @@ const quoteDataRows = [ destinationTokenValue: '150000000000000000000', isBestQuote: true, liquiditySource: 'AGG', - metaMaskFee: '1.00 DAI', networkFees: '$12.28', quoteSource: 'AGG', rawNetworkFees: 10.28, @@ -75,7 +71,6 @@ const quoteDataRows = [ destinationTokenValue: '104000000000000000000', isBestQuote: false, liquiditySource: 'RFQ', - metaMaskFee: '1.04 DAI', networkFees: '$11.29', quoteSource: 'RFQ', rawNetworkFees: 10.29, @@ -92,7 +87,6 @@ const quoteDataRows = [ destinationTokenValue: '105000000000000000000', isBestQuote: false, liquiditySource: 'DEX', - metaMaskFee: '1.05 DAI', networkFees: '$10.30', quoteSource: 'DEX', rawNetworkFees: 10.30, diff --git a/ui/app/pages/swaps/select-quote-popover/select-quote-popover-constants.js b/ui/app/pages/swaps/select-quote-popover/select-quote-popover-constants.js index 27f99be04..586faa82b 100644 --- a/ui/app/pages/swaps/select-quote-popover/select-quote-popover-constants.js +++ b/ui/app/pages/swaps/select-quote-popover/select-quote-popover-constants.js @@ -8,7 +8,6 @@ export const QUOTE_DATA_ROWS_PROPTYPES_SHAPE = PropTypes.shape({ destinationTokenValue: PropTypes.string.isRequired, isBestQuote: PropTypes.bool, liquiditySource: PropTypes.string.isRequired, - metaMaskFee: PropTypes.string.isRequired, networkFees: PropTypes.string.isRequired, quoteSource: PropTypes.string.isRequired, rawNetworkFees: PropTypes.number.isRequired,