m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix missing targetSubjectMetadata.name propType error (#13218)

Browse Source 
There was a propType error shown on the snap install screen about the
`name` property of `targetSubjectMetadata` being missing despite it
being marked as required. This property should not have been required,
it does not always exist.
This commit is contained in:
Mark Stacey 2022-01-05 19:02:44 -03:30 committed by GitHub
parent b9093e2a4d
commit 94dc287bb1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/components/app/permission-page-container/permission-page-container.component.js
View File

@ -14,7 +14,7 @@ export default class PermissionPageContainer extends Component {
request: PropTypes.object, request: PropTypes.object,
requestMetadata: PropTypes.object, requestMetadata: PropTypes.object,
targetSubjectMetadata: PropTypes.shape({ targetSubjectMetadata: PropTypes.shape({
name: PropTypes.string.isRequired, name: PropTypes.string,
origin: PropTypes.string.isRequired, origin: PropTypes.string.isRequired,
subjectType: PropTypes.string.isRequired, subjectType: PropTypes.string.isRequired,
extensionId: PropTypes.string, extensionId: PropTypes.string,

2
ui/pages/permissions-connect/choose-account/choose-account.js
View File

@ -139,7 +139,7 @@ ChooseAccount.propTypes = {
targetSubjectMetadata: PropTypes.shape({ targetSubjectMetadata: PropTypes.shape({
extensionId: PropTypes.string, extensionId: PropTypes.string,
iconUrl: PropTypes.string, iconUrl: PropTypes.string,
name: PropTypes.string.isRequired, name: PropTypes.string,
origin: PropTypes.string.isRequired, origin: PropTypes.string.isRequired,
subjectType: PropTypes.string, subjectType: PropTypes.string,
}), }),

2
ui/pages/permissions-connect/permissions-connect.component.js
View File

@ -34,7 +34,7 @@ export default class PermissionConnect extends Component {
targetSubjectMetadata: PropTypes.shape({ targetSubjectMetadata: PropTypes.shape({
extensionId: PropTypes.string, extensionId: PropTypes.string,
iconUrl: PropTypes.string, iconUrl: PropTypes.string,
name: PropTypes.string.isRequired, name: PropTypes.string,
origin: PropTypes.string.isRequired, origin: PropTypes.string.isRequired,
subjectType: PropTypes.string, subjectType: PropTypes.string,
}), }),