From 94dc287bb13a2b462a3b2376737fce4357c7ed05 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 5 Jan 2022 19:02:44 -0330 Subject: [PATCH] Fix missing `targetSubjectMetadata.name` propType error (#13218) There was a propType error shown on the snap install screen about the `name` property of `targetSubjectMetadata` being missing despite it being marked as required. This property should not have been required, it does not always exist. --- .../permission-page-container.component.js | 2 +- ui/pages/permissions-connect/choose-account/choose-account.js | 2 +- ui/pages/permissions-connect/permissions-connect.component.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/components/app/permission-page-container/permission-page-container.component.js b/ui/components/app/permission-page-container/permission-page-container.component.js index fee70f720..f4d7d2350 100644 --- a/ui/components/app/permission-page-container/permission-page-container.component.js +++ b/ui/components/app/permission-page-container/permission-page-container.component.js @@ -14,7 +14,7 @@ export default class PermissionPageContainer extends Component { request: PropTypes.object, requestMetadata: PropTypes.object, targetSubjectMetadata: PropTypes.shape({ - name: PropTypes.string.isRequired, + name: PropTypes.string, origin: PropTypes.string.isRequired, subjectType: PropTypes.string.isRequired, extensionId: PropTypes.string, diff --git a/ui/pages/permissions-connect/choose-account/choose-account.js b/ui/pages/permissions-connect/choose-account/choose-account.js index 0b6e8a08a..161f98532 100644 --- a/ui/pages/permissions-connect/choose-account/choose-account.js +++ b/ui/pages/permissions-connect/choose-account/choose-account.js @@ -139,7 +139,7 @@ ChooseAccount.propTypes = { targetSubjectMetadata: PropTypes.shape({ extensionId: PropTypes.string, iconUrl: PropTypes.string, - name: PropTypes.string.isRequired, + name: PropTypes.string, origin: PropTypes.string.isRequired, subjectType: PropTypes.string, }), diff --git a/ui/pages/permissions-connect/permissions-connect.component.js b/ui/pages/permissions-connect/permissions-connect.component.js index 0ac979ac5..2278af0c4 100644 --- a/ui/pages/permissions-connect/permissions-connect.component.js +++ b/ui/pages/permissions-connect/permissions-connect.component.js @@ -34,7 +34,7 @@ export default class PermissionConnect extends Component { targetSubjectMetadata: PropTypes.shape({ extensionId: PropTypes.string, iconUrl: PropTypes.string, - name: PropTypes.string.isRequired, + name: PropTypes.string, origin: PropTypes.string.isRequired, subjectType: PropTypes.string, }),