m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

centralize min gas const (#12387)

Browse Source
This commit is contained in:
Alex Donesky 2021-10-19 14:31:56 -05:00 committed by GitHub
parent d90ac2d8e6
commit 83d5eec2dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
shared/constants/gas.js
View File

@ -1,11 +1,11 @@
import { addHexPrefix } from 'ethereumjs-util'; import { addHexPrefix } from 'ethereumjs-util';
import { MIN_GAS_LIMIT_HEX } from '../../ui/pages/send/send.constants';
const TWENTY_ONE_THOUSAND = 21000;
const ONE_HUNDRED_THOUSAND = 100000; const ONE_HUNDRED_THOUSAND = 100000;
export const GAS_LIMITS = { export const GAS_LIMITS = {
// maximum gasLimit of a simple send // maximum gasLimit of a simple send
SIMPLE: addHexPrefix(TWENTY_ONE_THOUSAND.toString(16)), SIMPLE: addHexPrefix(MIN_GAS_LIMIT_HEX),
// a base estimate for token transfers. // a base estimate for token transfers.
BASE_TOKEN_ESTIMATE: addHexPrefix(ONE_HUNDRED_THOUSAND.toString(16)), BASE_TOKEN_ESTIMATE: addHexPrefix(ONE_HUNDRED_THOUSAND.toString(16)),
}; };

3
ui/pages/confirm-transaction-base/confirm-transaction-base.component.js
View File

@ -51,6 +51,7 @@ import {
} from '../../store/actions'; } from '../../store/actions';
import Typography from '../../components/ui/typography/typography'; import Typography from '../../components/ui/typography/typography';
import { MIN_GAS_LIMIT_DEC } from '../send/send.constants';
const renderHeartBeatIfNotInTest = () => const renderHeartBeatIfNotInTest = () =>
process.env.IN_TEST === 'true' ? null : <LoadingHeartBeat />; process.env.IN_TEST === 'true' ? null : <LoadingHeartBeat />;
@ -232,7 +233,7 @@ export default class ConfirmTransactionBase extends Component {
}; };
} }
if (hexToDecimal(customGas.gasLimit) < 21000) { if (hexToDecimal(customGas.gasLimit) < Number(MIN_GAS_LIMIT_DEC)) {
return { return {
valid: false, valid: false,
errorKey: GAS_LIMIT_TOO_LOW_ERROR_KEY, errorKey: GAS_LIMIT_TOO_LOW_ERROR_KEY,