From 83d5eec2dc7d0d00f35da3ec761fa2bc7d5dc7ee Mon Sep 17 00:00:00 2001 From: Alex Donesky Date: Tue, 19 Oct 2021 14:31:56 -0500 Subject: [PATCH] centralize min gas const (#12387) --- shared/constants/gas.js | 4 ++-- .../confirm-transaction-base.component.js | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/shared/constants/gas.js b/shared/constants/gas.js index 553414fff..ebae444a4 100644 --- a/shared/constants/gas.js +++ b/shared/constants/gas.js @@ -1,11 +1,11 @@ import { addHexPrefix } from 'ethereumjs-util'; +import { MIN_GAS_LIMIT_HEX } from '../../ui/pages/send/send.constants'; -const TWENTY_ONE_THOUSAND = 21000; const ONE_HUNDRED_THOUSAND = 100000; export const GAS_LIMITS = { // maximum gasLimit of a simple send - SIMPLE: addHexPrefix(TWENTY_ONE_THOUSAND.toString(16)), + SIMPLE: addHexPrefix(MIN_GAS_LIMIT_HEX), // a base estimate for token transfers. BASE_TOKEN_ESTIMATE: addHexPrefix(ONE_HUNDRED_THOUSAND.toString(16)), }; diff --git a/ui/pages/confirm-transaction-base/confirm-transaction-base.component.js b/ui/pages/confirm-transaction-base/confirm-transaction-base.component.js index 363b0fa6a..33a99df15 100644 --- a/ui/pages/confirm-transaction-base/confirm-transaction-base.component.js +++ b/ui/pages/confirm-transaction-base/confirm-transaction-base.component.js @@ -51,6 +51,7 @@ import { } from '../../store/actions'; import Typography from '../../components/ui/typography/typography'; +import { MIN_GAS_LIMIT_DEC } from '../send/send.constants'; const renderHeartBeatIfNotInTest = () => process.env.IN_TEST === 'true' ? null : ; @@ -232,7 +233,7 @@ export default class ConfirmTransactionBase extends Component { }; } - if (hexToDecimal(customGas.gasLimit) < 21000) { + if (hexToDecimal(customGas.gasLimit) < Number(MIN_GAS_LIMIT_DEC)) { return { valid: false, errorKey: GAS_LIMIT_TOO_LOW_ERROR_KEY,