m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Merge pull request #4717 from MetaMask/chrome-promise-bugfix

Browse Source 
Conditionally use Promise-based extension API when creating windows
This commit is contained in:
Dan Finlay 2018-07-03 11:16:35 -07:00 committed by GitHub
commit 2e9bd7e9d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/scripts/lib/notification-manager.js
View File

@ -26,15 +26,15 @@ class NotificationManager {
// bring focus to existing chrome popup // bring focus to existing chrome popup
extension.windows.update(popup.id, { focused: true }) extension.windows.update(popup.id, { focused: true })
} else { } else {
const cb = (currentPopup) => { this._popupId = currentPopup.id }
// create new notification popup // create new notification popup
extension.windows.create({ const creation = extension.windows.create({
url: 'notification.html', url: 'notification.html',
type: 'popup', type: 'popup',
width, width,
height, height,
}).then((currentPopup) => { }, cb)
this._popupId = currentPopup.id creation && creation.then && creation.then(cb)
})
} }
}) })
} }