m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 02:10:12 +01:00
Code

Merge pull request #4654 from TrejGun/bignumber

Browse Source 
fixes #4307 BigNumber casting issue
This commit is contained in:
Dan J Miller 2018-07-03 15:18:04 -02:30 committed by GitHub
commit 8def5281b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/app/conversion-util.js
View File

@ -140,7 +140,7 @@ const addCurrencies = (a, b, options = {}) => {
bBase,
...conversionOptions
} = options
const value = (new BigNumber(a, aBase)).add(b, bBase)
const value = (new BigNumber(a.toString(), aBase)).add(b.toString(), bBase)
return converter({
value,

22
ui/app/conversion-util.test.js Normal file
View File

@ -0,0 +1,22 @@
import assert from 'assert'
import {addCurrencies} from './conversion-util'
describe('conversion utils', () => {
describe('addCurrencies()', () => {
it('add whole numbers', () => {
const result = addCurrencies(3, 9)
assert.equal(result.toNumber(), 12)
})
it('add decimals', () => {
const result = addCurrencies(1.3, 1.9)
assert.equal(result.toNumber(), 3.2)
})
it('add repeating decimals', () => {
const result = addCurrencies(1 / 3, 1 / 9)
assert.equal(result.toNumber(), 0.4444444444444444)
})
})
})