1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 01:47:00 +01:00

Bump minimum Node.js version to 16 (#15131)

This commit is contained in:
Erik Marks 2022-07-02 23:32:18 -07:00 committed by GitHub
parent 7ee492b434
commit 08cc6c5e77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 7 deletions

View File

@ -3,10 +3,10 @@ version: 2.1
executors:
node-browsers:
docker:
- image: circleci/node:14-browsers
- image: circleci/node:16-browsers
node-browsers-medium-plus:
docker:
- image: circleci/node:14-browsers
- image: circleci/node:16-browsers
resource_class: medium+
environment:
NODE_OPTIONS: --max_old_space_size=2048

2
.nvmrc
View File

@ -1 +1 @@
v14
v16

View File

@ -165,7 +165,7 @@ describe('ComposableObservableStore', () => {
Example: exampleController,
},
}),
).toThrow(`Cannot read property 'subscribe' of undefined`);
).toThrow(`Cannot read properties of undefined (reading 'subscribe')`);
});
it('should throw if the controller messenger is omitted and updateStructure called with a BaseControllerV2 controller', () => {
@ -175,7 +175,7 @@ describe('ComposableObservableStore', () => {
});
const store = new ComposableObservableStore({});
expect(() => store.updateStructure({ Example: exampleController })).toThrow(
`Cannot read property 'subscribe' of undefined`,
`Cannot read properties of undefined (reading 'subscribe')`,
);
});

View File

@ -26,7 +26,7 @@ describe('transform utils', () => {
// This error is an artifact of how we're mocking the ESLint singleton,
// and won't actually occur in production.
await expect(() => lintTransformedFile()).rejects.toThrow(
`Cannot read property '0' of undefined`,
`Cannot read properties of undefined (reading '0')`,
);
expect(mockESLint).toBeDefined();
});

View File

@ -381,7 +381,7 @@
"yarn-deduplicate": "^3.1.0"
},
"engines": {
"node": "^14.15.1",
"node": "^16.0.0",
"yarn": "^1.16.0"
},
"lavamoat": {