From 08cc6c5e771d7be78d20e49b34e2e363c80253df Mon Sep 17 00:00:00 2001 From: Erik Marks <25517051+rekmarks@users.noreply.github.com> Date: Sat, 2 Jul 2022 23:32:18 -0700 Subject: [PATCH] Bump minimum Node.js version to 16 (#15131) --- .circleci/config.yml | 4 ++-- .nvmrc | 2 +- app/scripts/lib/ComposableObservableStore.test.js | 4 ++-- development/build/transforms/utils.test.js | 2 +- package.json | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 749402c7f..92afe9183 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,10 +3,10 @@ version: 2.1 executors: node-browsers: docker: - - image: circleci/node:14-browsers + - image: circleci/node:16-browsers node-browsers-medium-plus: docker: - - image: circleci/node:14-browsers + - image: circleci/node:16-browsers resource_class: medium+ environment: NODE_OPTIONS: --max_old_space_size=2048 diff --git a/.nvmrc b/.nvmrc index 958b5a36e..6f7f377bf 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v14 +v16 diff --git a/app/scripts/lib/ComposableObservableStore.test.js b/app/scripts/lib/ComposableObservableStore.test.js index 0beeacdfb..9d03eb98d 100644 --- a/app/scripts/lib/ComposableObservableStore.test.js +++ b/app/scripts/lib/ComposableObservableStore.test.js @@ -165,7 +165,7 @@ describe('ComposableObservableStore', () => { Example: exampleController, }, }), - ).toThrow(`Cannot read property 'subscribe' of undefined`); + ).toThrow(`Cannot read properties of undefined (reading 'subscribe')`); }); it('should throw if the controller messenger is omitted and updateStructure called with a BaseControllerV2 controller', () => { @@ -175,7 +175,7 @@ describe('ComposableObservableStore', () => { }); const store = new ComposableObservableStore({}); expect(() => store.updateStructure({ Example: exampleController })).toThrow( - `Cannot read property 'subscribe' of undefined`, + `Cannot read properties of undefined (reading 'subscribe')`, ); }); diff --git a/development/build/transforms/utils.test.js b/development/build/transforms/utils.test.js index ba273a15b..303b954d3 100644 --- a/development/build/transforms/utils.test.js +++ b/development/build/transforms/utils.test.js @@ -26,7 +26,7 @@ describe('transform utils', () => { // This error is an artifact of how we're mocking the ESLint singleton, // and won't actually occur in production. await expect(() => lintTransformedFile()).rejects.toThrow( - `Cannot read property '0' of undefined`, + `Cannot read properties of undefined (reading '0')`, ); expect(mockESLint).toBeDefined(); }); diff --git a/package.json b/package.json index 7345e1658..5b3b9ef71 100644 --- a/package.json +++ b/package.json @@ -381,7 +381,7 @@ "yarn-deduplicate": "^3.1.0" }, "engines": { - "node": "^14.15.1", + "node": "^16.0.0", "yarn": "^1.16.0" }, "lavamoat": {